Move runtime-global mod settings to Map generator

Post your ideas and suggestions how to improve the game.

Moderator: ickputzdirwech

Post Reply
User avatar
Therax
Filter Inserter
Filter Inserter
Posts: 470
Joined: Sun May 21, 2017 6:28 pm
Contact:

Move runtime-global mod settings to Map generator

Post by Therax »

A frequent point of confusion is that the settings accessed by Main menu -> Options -> Mod settings -> Map tab affect only new games, not existing saves. I have fielded several complaints that my mod is "not working" or "malfunctioning" due to this.

Suggestion:
1) Add a warning at the top of the existing Mod settings -> Map tab noting that changes made on that tab affect only new maps, and with instructions on how to change settings for an existing map, OR
2) Move the Mod settings -> Map tab to Main menu -> Play -> New game -> Map generator, alongside Resource settings, etc.
Miniloader — UPS-friendly 1x1 loaders
Bulk Rail Loaders — Rapid train loading and unloading
Beltlayer & Pipelayer — Route items and fluids freely underground

Rseding91
Factorio Staff
Factorio Staff
Posts: 13171
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: Move runtime-global mod settings to Map generator

Post by Rseding91 »

I think you might be misunderstanding how settings work. If a player changes the setting you get an event Lua side and you're meant to react to the new value. In that regard changing those settings runtime *should* effect the map and your mod not doing that would be a bug.
If you want to get ahold of me I'm almost always on Discord.

Nexela
Smart Inserter
Smart Inserter
Posts: 1828
Joined: Wed May 25, 2016 11:09 am
Contact:

Re: Move runtime-global mod settings to Map generator

Post by Nexela »

@rseding, You are thinking from inside out. not outside in.

In a NEW game the runtime-global settings (and user) are set to whatever is set when edited from the main menu (or default)

Changing these settings FROM the main menu then loading an existing game doesn't change the current maps value. I assume intended because they are the "default" values for runtime-global

Therax's point is that this is not very clear to the end user of the mod. Who add the mod to their game and edit the runtime settings from the main menu and wonder why it doesn't work in their existing save.

So I second the opinion that this needs to be made more clear to the end user.

User avatar
Optera
Smart Inserter
Smart Inserter
Posts: 2915
Joined: Sat Jun 11, 2016 6:41 am
Contact:

Re: Move runtime-global mod settings to Map generator

Post by Optera »

Just add a Line "Settings only apply to new games" to map and user settings when opened from main menu.
Potentially change the line to "Settings only apply to current game" when opened from running game.

User avatar
bobingabout
Smart Inserter
Smart Inserter
Posts: 7351
Joined: Fri May 09, 2014 1:01 pm
Contact:

Re: Move runtime-global mod settings to Map generator

Post by bobingabout »

I haven't tried it myself, but in theory, the settings are saved in the save game, so if the settings no longer match when the game is loaded, it SHOULD fire the same settings changed events as if you had changed them there and then in the running game.

I don't know what actually happens, but in theory that's what should happen.
at the very least, I think it does still fire the "mod configuration changed" event.
Creator of Bob's mods. Expanding your gameplay since version 0.9.8.
I also have a Patreon.

Rseding91
Factorio Staff
Factorio Staff
Posts: 13171
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: Move runtime-global mod settings to Map generator

Post by Rseding91 »

Optera wrote:
Fri Dec 14, 2018 7:04 am
Just add a Line "Settings only apply to new games" to map and user settings when opened from main menu.
Potentially change the line to "Settings only apply to current game" when opened from running game.
Seems reasonable: "Settings only apply to new games or to the current running game". I'll make a note to add it once the new GUI for mod settings is finished.
If you want to get ahold of me I'm almost always on Discord.

User avatar
steinio
Smart Inserter
Smart Inserter
Posts: 2631
Joined: Sat Mar 12, 2016 4:19 pm
Contact:

Re: Move runtime-global mod settings to Map generator

Post by steinio »

Rseding91 wrote:
Fri Dec 14, 2018 4:23 pm
Optera wrote:
Fri Dec 14, 2018 7:04 am
Just add a Line "Settings only apply to new games" to map and user settings when opened from main menu.
Potentially change the line to "Settings only apply to current game" when opened from running game.
Seems reasonable: "Settings only apply to new games or to the current running game". I'll make a note to add it once the new GUI for mod settings is finished.
:mrgreen: :D
Image

Transport Belt Repair Man

View unread Posts

Post Reply

Return to “Ideas and Suggestions”