Short delay when changing logistic request numbers

Post your ideas and suggestions how to improve the game.

Moderator: ickputzdirwech

Post Reply
User avatar
Maoman
Burner Inserter
Burner Inserter
Posts: 11
Joined: Sat Nov 12, 2016 10:55 am
Contact:

Short delay when changing logistic request numbers

Post by Maoman »

There should be a short one or two second delay between when you change the number for a logistics or auto trash slot and when that number is actually sent to the logistic network (or applied to your inventory, for auto trash slots). This would go a long way toward preventing people from accidentally requesting too much of an item or all of an item in your inventory being dumped into logistic trash slots when you edit a logistics rule.

(I know of the "request 1 item instead of stack" option, but that only helps when you initially create a request. It does nothing to help when editing an existing request or when creating and/or editing an auto trash slot.)

This isn't very easily expressed via screenshots, so here are two example scenarios, one for request slots, and one for trash slots:

If you request some iron, drag the slider to 200, then accidentally go too far and it hits 300 for just a second before you slide back down to 200, currently the request for 300 is applied instantly and the bots will bring you 300 iron. If it waits a second or two and only sends the bots a request once you've stopped on a number, you would instead get 200 iron like you actually wanted.

If you have an auto trash slot for iron currently set to 500 and you change it by manually typing in 100, you have to type "1" first. Currently, that "1" is applied instantly, even if you continue typing "100," so all but 1 iron immediately goes into your trash slots. Then you have to manually put the iron back in your inventory if you're outside of the logistics network, or your bots come out and take the iron out of your trash slots and you need a matching logistic request for 100 iron to have the robots put it back in your inventory instead of just taking it all away. If it waits a second or two for you to finish typing "100" and only applies the rule to your inventory once the number stops changing, all this is prevented.

(You may also want to consider a similar sort of delay when initially creating an auto trash slot, so it only sends all of that item to trash if you leave it at the default zero for a couple seconds, and you have a chance to raise the number a bit if you want to keep a stack or two of the item.)

User avatar
bobingabout
Smart Inserter
Smart Inserter
Posts: 7352
Joined: Fri May 09, 2014 1:01 pm
Contact:

Re: Short delay when changing logistic request numbers

Post by bobingabout »

I agree that this is a bit frustrating. when I was actively playing, I used to do that all the time.
Creator of Bob's mods. Expanding your gameplay since version 0.9.8.
I also have a Patreon.

User avatar
steinio
Smart Inserter
Smart Inserter
Posts: 2633
Joined: Sat Mar 12, 2016 4:19 pm
Contact:

Re: Short delay when changing logistic request numbers

Post by steinio »

Ok i read your wall of text and agree surprisingly.
How about saving the request only after closing the player inventory so changes take no effect during changing numbers.
Image

Transport Belt Repair Man

View unread Posts

User avatar
Ghoulish
Filter Inserter
Filter Inserter
Posts: 462
Joined: Fri Oct 16, 2015 8:40 am

Re: Short delay when changing logistic request numbers

Post by Ghoulish »

Totally agree, we've all requested more than we intended at some point. steinio's solution is pretty solid imho.l
See the daily™ struggles with my Factory! :D https://www.twitch.tv/repetitivebeats

User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 5206
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: Short delay when changing logistic request numbers

Post by eradicator »

+1

Also going the extra step to only apply changes on explicit player action (closing menu, pressing "apply", etc) would make it even better.
Author of: Belt Planner, Hand Crank Generator, Screenshot Maker, /sudo and more.
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.

Koub
Global Moderator
Global Moderator
Posts: 7199
Joined: Fri May 30, 2014 8:54 am
Contact:

Re: Short delay when changing logistic request numbers

Post by Koub »

Actually, this is a part of a wider issue that existed before. When the default logistic request became 1 stack (from 1 item) this became a common suggestion: a delay (or even better : an explicit validation) for any kind of modification to logistic request, but the devs chose to add an option "set logistic request stack size 1 instead of stack size" instead, half solving half the problem. This is one of the rare suboptimal decisions I can account on the dev team. I hope an explicit validation ("that's exactly what I want") will come and replace this wobbly feature. I can be either an OK button, or simply wait for the player to close the current menu (even better).
Koub - Please consider English is not my native language.

Jap2.0
Smart Inserter
Smart Inserter
Posts: 2339
Joined: Tue Jun 20, 2017 12:02 am
Contact:

Re: Short delay when changing logistic request numbers

Post by Jap2.0 »

Yeah, I think waiting for the player to close their inventory (or possibly something like 10 seconds of logistic setting inactivity) would help with this a great deal.
There are 10 types of people: those who get this joke and those who don't.

User avatar
bobingabout
Smart Inserter
Smart Inserter
Posts: 7352
Joined: Fri May 09, 2014 1:01 pm
Contact:

Re: Short delay when changing logistic request numbers

Post by bobingabout »

Koub wrote:
Mon Oct 08, 2018 6:52 pm
but the devs chose to add an option "set logistic request stack size 1 instead of stack size" instead, half solving half the problem.
I believe this is because the game is pretty hard wired for changes to take effect immediately, and to change the behaviour would have required more work than they were willing to do mid-version when the request originally came in.

Since we're currently between versions (0.17 in the works), this is the best time to ask again, and it may be considered.

honestly, this is one of those QoL things, and would make a large difference to anyone trying to set up logistic requests. Not just on the player, but chests too.
Creator of Bob's mods. Expanding your gameplay since version 0.9.8.
I also have a Patreon.

User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 5206
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: Short delay when changing logistic request numbers

Post by eradicator »

§several_people wrote: or simply wait for the player to close the current menu (even better).
Btw, while it certainly would be an improvement over the current situation i still think this is bad gui design. Factorio GUIs are closed by pressing esc/e, and not a usual "ok/apply" button like in e.g. windows. In most applications pressing esc would throw away any pending changes and restore the original values. So applying something when closing the window is completely intransparent to users who don't already know that this is happening.

Imho both solutions (timer + on_close) require some sort of text display to make the user aware of the situation, so they might just as well be combined. A (configurable) timer and on_close could display something like: "Changes will be applied in [27] seconds or when you close this window." where the [number] constantly ticks down. It might be feasible to hide the text as a tooltip on a number-only countdown to preserv factorios "guis don't have text" style.
Author of: Belt Planner, Hand Crank Generator, Screenshot Maker, /sudo and more.
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.

User avatar
Maoman
Burner Inserter
Burner Inserter
Posts: 11
Joined: Sat Nov 12, 2016 10:55 am
Contact:

Re: Short delay when changing logistic request numbers

Post by Maoman »

eradicator wrote:
Tue Oct 09, 2018 8:13 am
Btw, while it certainly would be an improvement over the current situation i still think this is bad gui design. Factorio GUIs are closed by pressing esc/e, and not a usual "ok/apply" button like in e.g. windows. In most applications pressing esc would throw away any pending changes and restore the original values. So applying something when closing the window is completely intransparent to users who don't already know that this is happening.

Imho both solutions (timer + on_close) require some sort of text display to make the user aware of the situation, so they might just as well be combined. A (configurable) timer and on_close could display something like: "Changes will be applied in [27] seconds or when you close this window." where the [number] constantly ticks down. It might be feasible to hide the text as a tooltip on a number-only countdown to preserv factorios "guis don't have text" style.
I was thinking a little "3... 2... 1... Applied" could appear near the bottom of the logistics slots or something, then the "Applied" will slowly fade away like text in the console/chat does (or to maintain "guis don't have text," a green check mark or something instead of the word applied).

User avatar
bobingabout
Smart Inserter
Smart Inserter
Posts: 7352
Joined: Fri May 09, 2014 1:01 pm
Contact:

Re: Short delay when changing logistic request numbers

Post by bobingabout »

Maoman wrote:
Fri Oct 12, 2018 4:12 pm
eradicator wrote:
Tue Oct 09, 2018 8:13 am
Btw, while it certainly would be an improvement over the current situation i still think this is bad gui design. Factorio GUIs are closed by pressing esc/e, and not a usual "ok/apply" button like in e.g. windows. In most applications pressing esc would throw away any pending changes and restore the original values. So applying something when closing the window is completely intransparent to users who don't already know that this is happening.

Imho both solutions (timer + on_close) require some sort of text display to make the user aware of the situation, so they might just as well be combined. A (configurable) timer and on_close could display something like: "Changes will be applied in [27] seconds or when you close this window." where the [number] constantly ticks down. It might be feasible to hide the text as a tooltip on a number-only countdown to preserv factorios "guis don't have text" style.
I was thinking a little "3... 2... 1... Applied" could appear near the bottom of the logistics slots or something, then the "Applied" will slowly fade away like text in the console/chat does (or to maintain "guis don't have text," a green check mark or something instead of the word applied).
That might be a little fancy.
Creator of Bob's mods. Expanding your gameplay since version 0.9.8.
I also have a Patreon.

Post Reply

Return to “Ideas and Suggestions”