Page 1 of 1

[1.0.0] Nuclear Reactor top-east-facing heat ending misalignment

Posted: Sat Nov 14, 2020 12:00 am
by kirazy
nuclear-reactor-heat-ending-misalignment.png
nuclear-reactor-heat-ending-misalignment.png (253.05 KiB) Viewed 3128 times
The sprite is misaligned in the spritesheet hr-reactor-connect-patches.png:
hr-reactor-connect-patches.png
hr-reactor-connect-patches.png (46.47 KiB) Viewed 3128 times
You can see how it's a few pixels down (fourth column) from the other two east-facing ends.

Re: [1.0.0] Nuclear Reactor top-east-facing heat ending misalignment

Posted: Sat Nov 14, 2020 12:06 am
by NotRexButCaesar
This looks like a mod issue to me: probably the same mod that changes the reactor color. Vanilla reactors look like this:
1.jpg
1.jpg (62.79 KiB) Viewed 3125 times

Re: [1.0.0] Nuclear Reactor top-east-facing heat ending misalignment

Posted: Sat Nov 14, 2020 12:29 am
by kirazy
Those are connected. I am speaking of the disconnected state. The image in the OP is edited to move the two reactors next to each other to more clearly show the issue.

The hr-reactor-connect-patch.png file posted here, where the misalignment is very obvious, is straight out of base/graphics/entity/nuclear-reactor.

Re: [1.0.0] Nuclear Reactor top-east-facing heat ending misalignment

Posted: Sat Nov 14, 2020 1:53 am
by valneq
How relevant is this if you never see them next to each other in this disconnected state? Just wondering …

Re: [1.0.0] Nuclear Reactor top-east-facing heat ending misalignment

Posted: Sat Nov 14, 2020 1:58 am
by kirazy
The misalignment is with respect to the grid that all heat pipes are aligned to. It's not misaligned to the nuclear reactor specifically. It's a bug, but not a very serious one...

It would be analogous to a pipe cover being 5 pixels down-shifted from the pipe it's trying to cover.

Re: [1.0.0] Nuclear Reactor top-east-facing heat ending misalignment

Posted: Sun Nov 15, 2020 12:20 pm
by Klonan
Gonna call this a 'who cares'

Re: [1.0.0] Nuclear Reactor top-east-facing heat ending misalignment

Posted: Mon Nov 16, 2020 5:28 am
by kirazy
Well, if you change your mind, here's the fix which took 60 seconds:

Re: [1.0.0] Nuclear Reactor top-east-facing heat ending misalignment

Posted: Mon Nov 16, 2020 1:05 pm
by Optera
You could release the fix as mod.
I'd be one to download it.

Re: [1.0.0] Nuclear Reactor top-east-facing heat ending misalignment

Posted: Wed Nov 18, 2020 7:30 am
by MakeItGraphic
Optera wrote: Mon Nov 16, 2020 1:05 pm You could release the fix as mod.
I'd be one to download it.
Nah, I saw this when it was first posted and I agree with Kirazy it is a 60 second fix. No reason it can't be fixed in 1.1 IMO. Pride of ownership and all that, at least acknowledge it as a minor issue.