Page 1 of 1

Bob's Logistics locale

Posted: Fri Feb 16, 2018 12:35 pm
by DRY411S
On your next release, would you mind either moving or duplicating entries for your bob-valve into the entity-name section of your locale please?

My Recycling Machines Mod checks every item prototype for certain properties. Your bob-valve have the 'place_result' property which suggests that there is an entity prototype associated, and that the locale should be in the entity-name section. As a result, my Recycling Machine gives an ugly error display when i hover over your entity in the Recycling Machines menus.
bob-valve.png
bob-valve.png (219.45 KiB) Viewed 3119 times
To put this into context, this is the only example I can find in all of your Mods where this happens. So far I've discovered it in only 3 places across dozens of other Mods.

Re: Bob's Logistics locale

Posted: Fri Feb 16, 2018 1:02 pm
by bobingabout
I'll have to look at what I did.

Re: Bob's Logistics locale

Posted: Fri Feb 16, 2018 5:22 pm
by bobingabout
Alright, I'm adding the following to entity, and item, and apparently already existed for recipe.

Code: Select all

bob-valve=__ITEM__valve__
bob-valve=__ENTITY__valve__
This should fix the issue without boblocale having to be updated, as using this method should map to the active locale.

It will be in the next release.

Re: Bob's Logistics locale

Posted: Fri Feb 16, 2018 6:00 pm
by DRY411S
Thank you

Re: Bob's Logistics locale

Posted: Fri Feb 16, 2018 6:26 pm
by DRY411S
Actually, because you have a localised_name property set for the valve prototype, I don't actually need the change in your locale. My code should test for that and use it where it finds it.

That's not true for any other modders I have contacted though.

Re: Bob's Logistics locale

Posted: Fri Feb 16, 2018 7:55 pm
by bobingabout
DRY411S wrote:Actually, because you have a localised_name property set for the valve prototype, I don't actually need the change in your locale. My code should test for that and use it where it finds it.

That's not true for any other modders I have contacted though.
I was going to say it has that... however... I've deleted it now for the next version.... honestly, it wasn't really needed there when I could have done what I just changed it to in the begining.