Standing in a shadow looks weird

Post all other topics which do not belong to any other category.
leadfeather89
Burner Inserter
Burner Inserter
Posts: 5
Joined: Mon Jun 19, 2017 2:22 am
Contact:

Standing in a shadow looks weird

Post by leadfeather89 »

Title.

I don't know how to post pictures in the forum, but here is an imgur link. https://imgur.com/wVxdrYR

Image[/quote]
Last edited by leadfeather89 on Sun Apr 08, 2018 9:56 pm, edited 1 time in total.

User avatar
Gergely
Filter Inserter
Filter Inserter
Posts: 596
Joined: Sun Apr 10, 2016 8:31 pm
Contact:

Re: Standing in a shadow looks weird

Post by Gergely »

Quoted from here: p233989. Altered to be "on topic".
Image corrected

User avatar
DaveMcW
Smart Inserter
Smart Inserter
Posts: 3700
Joined: Tue May 13, 2014 11:06 am
Contact:

Re: Standing in a shadow looks weird

Post by DaveMcW »

It's even better at night.
lamp.jpg
lamp.jpg (257.54 KiB) Viewed 5412 times

User avatar
Gergely
Filter Inserter
Filter Inserter
Posts: 596
Joined: Sun Apr 10, 2016 8:31 pm
Contact:

Re: Standing in a shadow looks weird

Post by Gergely »

DaveMcW wrote:It's even better at night.
Holly crap... they should definitely remove shadows during night... :shock: :shock:
Last edited by Gergely on Mon Apr 09, 2018 11:06 am, edited 1 time in total.

leadfeather89
Burner Inserter
Burner Inserter
Posts: 5
Joined: Mon Jun 19, 2017 2:22 am
Contact:

Re: Standing in a shadow looks weird

Post by leadfeather89 »

Now I can't unsee it.

gsezz
Long Handed Inserter
Long Handed Inserter
Posts: 60
Joined: Thu Jan 04, 2018 8:23 pm
Contact:

Re: Standing in a shadow looks weird

Post by gsezz »

Fading shadows in and out at sunrise and sunset might have a huge impact on performance. And making them suddenly disappear would look be even worse.

mrvn
Smart Inserter
Smart Inserter
Posts: 5704
Joined: Mon Sep 05, 2016 9:10 am
Contact:

Re: Standing in a shadow looks weird

Post by mrvn »

Really? Isn't that just a black area with alpha value? Changing the alpha value for all shadows sounds relatively easy to do once a second.

User avatar
Deadlock989
Smart Inserter
Smart Inserter
Posts: 2528
Joined: Fri Nov 06, 2015 7:41 pm

Re: Standing in a shadow looks weird

Post by Deadlock989 »

Gergely wrote:
DaveMcW wrote:It's even better at night.
Holly crap... they should definitely remove shadows during night... :shock: :shock:
Not going to happen. Some entities (usually the larger ones) have a separate shadow layer. Some don't, the shadow is part of the sprite. Then there are mods, which might do either or both or neither.

It's not a 3D game, guys.
Image

Jap2.0
Smart Inserter
Smart Inserter
Posts: 2339
Joined: Tue Jun 20, 2017 12:02 am
Contact:

Re: Standing in a shadow looks weird

Post by Jap2.0 »

DaveMcW wrote:It's even better at night.
lamp.jpg
WHAT HAVE YOU DONE!?
There are 10 types of people: those who get this joke and those who don't.

User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 5206
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: Standing in a shadow looks weird

Post by eradicator »

The "lamp" is actually just a targeting marker for an orbital long-range spotlight, it doesn't produce the light itself :P.

leadfeather89
Burner Inserter
Burner Inserter
Posts: 5
Joined: Mon Jun 19, 2017 2:22 am
Contact:

Re: Standing in a shadow looks weird

Post by leadfeather89 »

Deadlock989 wrote:
Gergely wrote:
DaveMcW wrote:It's even better at night.
Holly crap... they should definitely remove shadows during night... :shock: :shock:
It's not a 3D game, guys.
Yeah, but they definitely are kinda pretending it is with the addition of cliffs.

User avatar
Deadlock989
Smart Inserter
Smart Inserter
Posts: 2528
Joined: Fri Nov 06, 2015 7:41 pm

Re: Standing in a shadow looks weird

Post by Deadlock989 »

leadfeather89 wrote:Yeah, but they definitely are kinda pretending it is with the addition of cliffs.
Yeah, well, best game in the world, they're allowed a couple of duff moves.
Image

mrvn
Smart Inserter
Smart Inserter
Posts: 5704
Joined: Mon Sep 05, 2016 9:10 am
Contact:

Re: Standing in a shadow looks weird

Post by mrvn »

Deadlock989 wrote:
Gergely wrote:
DaveMcW wrote:It's even better at night.
Holly crap... they should definitely remove shadows during night... :shock: :shock:
Not going to happen. Some entities (usually the larger ones) have a separate shadow layer. Some don't, the shadow is part of the sprite. Then there are mods, which might do either or both or neither.

It's not a 3D game, guys.
So fix the shadow for things that have a separate shadow layer, Throw all the vanilla entities back into the render queue to generate a separate shadow layer. And then sit back and watch how fast mod authors with do the same because their entities will be the only ones with broken shadows.

User avatar
Deadlock989
Smart Inserter
Smart Inserter
Posts: 2528
Joined: Fri Nov 06, 2015 7:41 pm

Re: Standing in a shadow looks weird

Post by Deadlock989 »

You make it sound so trivial. Knock yourself out.
Image

User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 5206
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: Standing in a shadow looks weird

Post by eradicator »

mrvn wrote:So fix the shadow for things that have a separate shadow layer, Throw all the vanilla entities back into the render queue to generate a separate shadow layer. And then sit back and watch how fast mod authors with do the same because their entities will be the only ones with broken shadows.
Congratulations. You just doubled the VRAM requirement for factorio.

mrvn
Smart Inserter
Smart Inserter
Posts: 5704
Joined: Mon Sep 05, 2016 9:10 am
Contact:

Re: Standing in a shadow looks weird

Post by mrvn »

eradicator wrote:
mrvn wrote:So fix the shadow for things that have a separate shadow layer, Throw all the vanilla entities back into the render queue to generate a separate shadow layer. And then sit back and watch how fast mod authors with do the same because their entities will be the only ones with broken shadows.
Congratulations. You just doubled the VRAM requirement for factorio.
If that is your problem then combine the entity layer with the shadow layer into a single layer at runtime. Just refresh that cached image every so often as light levels change. You don't have to keep both images in VRAM, you only need to know which part of the image needs to be adjusted for light levels. More work to code but surely not impossible.

User avatar
Deadlock989
Smart Inserter
Smart Inserter
Posts: 2528
Joined: Fri Nov 06, 2015 7:41 pm

Re: Standing in a shadow looks weird

Post by Deadlock989 »

To me all that sounds like a buttload of work for something incredibly trivial that is not even guaranteed to be noticed when you zoom in to maximum during the less than 50% of the time that it's night. If just one minute spent on carping like this takes away time and resources from all the other cool new stuff in the pipeline, that is an epic fail. Please just stop it.
Image

bobucles
Smart Inserter
Smart Inserter
Posts: 1669
Joined: Wed Jun 10, 2015 10:37 pm
Contact:

Re: Standing in a shadow looks weird

Post by bobucles »

There's a reason overhead tile based games don't do shadows.

dood
Filter Inserter
Filter Inserter
Posts: 360
Joined: Wed Mar 21, 2018 8:36 am
Contact:

Re: Standing in a shadow looks weird

Post by dood »

mrvn wrote:
eradicator wrote:
mrvn wrote:So fix the shadow for things that have a separate shadow layer, Throw all the vanilla entities back into the render queue to generate a separate shadow layer. And then sit back and watch how fast mod authors with do the same because their entities will be the only ones with broken shadows.
Congratulations. You just doubled the VRAM requirement for factorio.
If that is your problem then combine the entity layer with the shadow layer into a single layer at runtime. Just refresh that cached image every so often as light levels change. You don't have to keep both images in VRAM, you only need to know which part of the image needs to be adjusted for light levels. More work to code but surely not impossible.
And now you have the entity parts, shadow parts and a combined surface.
3 times the VRAM.

Sir3n
Inserter
Inserter
Posts: 32
Joined: Tue Apr 03, 2018 11:35 pm
Contact:

Re: Standing in a shadow looks weird

Post by Sir3n »

DaveMcW wrote:It's even better at night.
lamp.jpg
I always felt there was something wrong with night time in factorio. Now that you point it out, it's actually obvious why.

Honestly, i think removing shadows altogether or making it an option to do so probably won't lose much out of the game. I play league on no shadows and i don't have an issue with it.

At the very least, having no shadows would be much better than shadows on a lit lamp.

Post Reply

Return to “General discussion”