Page 1 of 1

[0.17.79] libpng warning

Posted: Mon Jan 27, 2020 10:46 am
by Pi-C
Just noticed this in my logfile:

Code: Select all

  60.962 Initial atlas bitmap size is 16384
  60.980 Created atlas bitmap 16384x16380 [none]
  61.006 Created atlas bitmap 16384x16376 [none]
  61.006 Created atlas bitmap 16384x808 [none]
  61.006 Created atlas bitmap 16384x4796 [decal]
  61.007 Created atlas bitmap 16384x5760 [low-object]
  61.008 Created atlas bitmap 16384x3744 [mipmap, linear-minification, linear-magnification, linear-mip-level]
  61.040 Created atlas bitmap 16384x16368 [terrain, mipmap, linear-minification, linear-mip-level]
  61.040 Created atlas bitmap 16384x7200 [terrain, mipmap, linear-minification, linear-mip-level]
  61.040 Created atlas bitmap 8192x2736 [smoke, mipmap, linear-minification, linear-magnification]
  61.040 Created atlas bitmap 480x160 [low-object, mipmap, linear-minification, linear-magnification, linear-mip-level]
  61.041 Created atlas bitmap 8192x2992 [icon, not-compressed, mipmap, linear-minification, linear-magnification, linear-mip-level]
  61.041 Created atlas bitmap 2048x752 [icon-background, not-compressed, mipmap, linear-minification, linear-magnification, linear-mip-level, ]
  61.041 Created atlas bitmap 8192x1708 [alpha-mask]
  61.043 Created atlas bitmap 16384x15360 [shadow, linear-magnification, alpha-mask]
  61.043 Created atlas bitmap 16384x4032 [shadow, mipmap, linear-magnification, alpha-mask]
  61.098 Created virtual atlas pages 4096x4096x8
  61.133 Texture processor created (2048). GPU accelerated compression Supported: yes, Enabled: yes/yes. Test passed. YCoCgDXT PSNR: 35.83, BC3 PSNR: 33.82
  84.883 Parallel Sprite Loader initialized (threads: 3)
libpng warning: iCCP: CRC error
 111.499 Sprites loaded
Just a warning, it doesn't seem to break anything -- but it's irritating. Any idea what I can do about it?

By the way, I'm on Debian/sid, and the packages related to libpng are on the latest version:

Code: Select all

# dpkg -l | grep libpng
ii  libpng-dev:amd64                             1.6.37-1                           amd64        PNG library - development (version 1.6)
ii  libpng16-16:amd64                            1.6.37-1                           amd64        PNG library - runtime (version 1.6)
ii  libpng16-16:i386                             1.6.37-1                           i386         PNG library - runtime (version 1.6)
root@debian:~# 

Re: [0.17.79] libpng warning

Posted: Mon Jan 27, 2020 4:20 pm
by BlueTemplar
libpng seems to have issues, and Wube tried to work around them the best that they could ?
(At least it doesn't randomly crash Factorio on startup any more ?)
71058
slippycheeze wrote: Mon Jul 22, 2019 5:11 pm [...]
Both libpng, and zlib used by it, should be totally thread safe as long as you don't share any of their data structures, and you restrict touching them to a single thread forever. So, uh, for limited values of thread safe that I'd call more "thread compatible".
[...]
Also this one ?
77344

Re: [0.17.79] libpng warning

Posted: Mon Jan 27, 2020 4:56 pm
by Pi-C
BlueTemplar wrote: Mon Jan 27, 2020 4:20 pm libpng seems to have issues, and Wube tried to work around them the best that they could ?
(At least it doesn't randomly crash Factorio on startup any more ?)
Ah, thanks for the info! And no: It doesn't crash the game, but I noticed the same message the last couple of times I loaded up stable Factorio 0.17. Just checked with 0.18 and it doesn't appear there. May be that's because the issue has been resolved, may be because it's loading only part of the mods for now. :-)
That's something else I've been wondering about: Where do you find the bug numbers? I've seen them in links many times, but do you really check all the release announcements by Factoriobot each time you set a link? Or have I been just too stupid to find the central list mapping bug numbers to bug reports? Even in the Bug Reports subforum, the best I can find is who of the devs has been assigned a bug to work on, but no actual bug number.

Re: [0.17.79] libpng warning

Posted: Mon Jan 27, 2020 5:05 pm
by Loewchen
Pi-C wrote: Mon Jan 27, 2020 4:56 pm
That's something else I've been wondering about: Where do you find the bug numbers? I've seen them in links many times, but do you really check all the release announcements by Factoriobot each time you set a link? Or have I been just too stupid to find the central list mapping bug numbers to bug reports? Even in the Bug Reports subforum, the best I can find is who of the devs has been assigned a bug to work on, but no actual bug number.
There are no bug numbers, those are just forum topics.

Re: [0.17.79] libpng warning

Posted: Mon Jan 27, 2020 5:09 pm
by Pi-C
I see. Thanks for clearing that up! :-)

Re: [0.17.79] libpng warning

Posted: Mon Jan 27, 2020 9:33 pm
by Honktown
Other sites say the error is due to bad color profiles on images. One "fix" is to load and save images without a color profile in Gimp.

Re: [0.17.79] libpng warning

Posted: Mon Jan 27, 2020 9:42 pm
by Pi-C
Honktown wrote: Mon Jan 27, 2020 9:33 pm Other sites say the error is due to bad color profiles on images. One "fix" is to load and save images without a color profile in Gimp.
Thanks, but the warning doesn't tell which image (or even which mod) is at fault. And looking for all images in >100 mods? Yes, I guess the answer is No. :-D

Re: [0.17.79] libpng warning

Posted: Mon Jan 27, 2020 10:28 pm
by BlueTemplar
Ok, so it seems like that PNG actually *does* support color profiles/spaces other than sRGB - (even your own, custom ones !),
W3C 2003 wrote:The RGB colour space in which colour samples are situated may be specified in one of three ways:

- by an ICC profile;
- by specifying explicitly that the colour space is sRGB when the samples conform to this colour space;
- by specifying the value of gamma and the 1931 CIE x,y chromaticities of the red, green, and blue primaries used in the image and the reference white point.
and so *is* future-proof,
it's just that not a lot of software *actually* supports the full specification, even today, with "HDR" starting to show up even on Windows ?
P.S.: Not that it made sense for most software to support other profiles than sRGB until recently, with properly calibrated, wide-gamut color screens being mostly confined to professional artists ?