Page 1 of 1

[1.1.1]Electric Miners show wrong status lamp color

Posted: Wed Nov 25, 2020 5:44 pm
by Livedeath
Hey. I see that the status lamp color on electric miners shows mostly the wrong color.
And/or the status itself uses the wrong color.
See for yourself.
Best Regars, Livedeath

Re: [1.1.1]Electric Miners show wrong status lamp color

Posted: Wed Nov 25, 2020 5:56 pm
by posila
Thanks for the report.
I am gonna move this to minor issues as it might get resolved in a way that most people would not like.
Here is the thing ... status colors in GUI are chosen by kovarex, and I was told he's pretty determined about those colors being the way they are, so those are the correct ones.
But, status lights were added to miners in in 0.18, and we picked the colors in attemp to make them somewhat useful.
- green - miner is mining
- yellow - miner is idle at the moment, but there is still ore to be mined
- red - there is no ore to be mined anymore
and I think no light is for no power.

Re: [1.1.1]Electric Miners show wrong status lamp color

Posted: Wed Nov 25, 2020 5:57 pm
by valneq
posila wrote:
Wed Nov 25, 2020 5:56 pm
Thanks for the report.
I am gonna move this to minor issues.
Here is the thing ... status colors in GUI are determined by kovarex, and I was told he's pretty determined about those colors being the way they are, so those are the correct ones.
But, status lights were added to miners in in 0.18, and we picked the colors in attemp to make them somewhat useful.
- green - miner is mining
- yellow - miner is idle at the moment, but there is still ore to be mined
- red - there is no ore to be mined anymore
and I think no light is for no power.
Well … maybe kovarex would be willing to reconsider colors given this obvious inconsistency :|

Re: [1.1.1]Electric Miners show wrong status lamp color

Posted: Wed Nov 25, 2020 6:03 pm
by Deadlock989
The corollary of this is that (a) status colours can be set to any colour, for miners and any crafting machine, by mods and (b) the tooltip LED colours do not reflect those changed colours either.

Personally it doesn't actually bother me, I don't really look at the tooltip, I look at the machine.

Re: [1.1.1]Electric Miners show wrong status lamp color

Posted: Wed Nov 25, 2020 6:07 pm
by valneq
Deadlock989 wrote:
Wed Nov 25, 2020 6:03 pm
Personally it doesn't actually bother me, I don't really look at the tooltip, I look at the machine.
Side note: when you open the machine GUI, you see the same status indication as in the tooltip.

Re: [1.1.1]Electric Miners show wrong status lamp color

Posted: Wed Nov 25, 2020 6:13 pm
by kovarex
I'm not completely denying changing full output status to be generally yellow rather than red, if it would be applied everywhere and also, if we had something different for low power.

Re: [1.1.1]Electric Miners show wrong status lamp color

Posted: Wed Nov 25, 2020 6:18 pm
by valneq
kovarex wrote:
Wed Nov 25, 2020 6:13 pm
[…] if we had something different for low power.
flickering yellow light? :roll:

Re: [1.1.1]Electric Miners show wrong status lamp color

Posted: Wed Nov 25, 2020 6:35 pm
by Deadlock989
valneq wrote:
Wed Nov 25, 2020 6:07 pm
Side note: when you open the machine GUI, you see the same status indication as in the tooltip.
*shrug*

The physical battery indicator LED on my phone isn't the same colour as the status bar icon for low power either. It's a niggle, not a bug.

As long as nothing happens to mods' ability to set status_color() per entity prototype in graphics definitions I'm not bothered.

Re: [1.1.1]Electric Miners show wrong status lamp color

Posted: Wed Nov 25, 2020 8:36 pm
by Livedeath
I know that traffic lights in my country are blinking yellow if they are out of order.
So maybe "slow" blinking or fading yellow lights on electric miners would signaling low power?
What do you think?