Changelog parser bug?

We are aware of them, but they have low priority. We have more important things to do. They go here in order not to take space in the main bug thread list.
Post Reply
Pi-C
Smart Inserter
Smart Inserter
Posts: 1645
Joined: Sun Oct 14, 2018 8:13 am
Contact:

Changelog parser bug?

Post by Pi-C »

Consider this changelog:

Code: Select all

1	---------------------------------------------------------------------------------------------------
2	Version: 0.0.2
3	Date: 2020-02-18
4	
5	
6	
7	   Changes:
8	    - Fixed issue 1
9	      (https://LINK-1)
10	
11	    - Implemented X
12	      (https://LINK-2)
13	
14	    - Implemented Y
15	      (https://LINK-1)
The in-game parser doesn't like it:

Code: Select all

invalid changelog file, line 15 is a duplicate of line 9.
It's correct that these are duplicate lines, but they are inconsequential because they are mere continuations of the item lines preceding them -- they do not open a new category and do not begin with " - ". It is quite possible that such lines may legitimately contain duplicate content, e.g. links as in the example above, items in a custom list …

I think it is a bug that the in-game parser doesn't accept duplicate continuation lines. Could you exempt such lines from the duplicate-lines test, please?
A good mod deserves a good changelog. Here's a tutorial (WIP) about Factorio's way too strict changelog syntax!

User avatar
Klonan
Factorio Staff
Factorio Staff
Posts: 5150
Joined: Sun Jan 11, 2015 2:09 pm
Contact:

Re: Changelog parser bug?

Post by Klonan »

At best, this is a minor issue

We have our rules, and you need to follow them

(If another dev comes and fixes it, I won't cry...)

Post Reply

Return to “Minor issues”