Hello. I was spending some time with parsing recipe prototypes and faced to a problem. Two files have same recipe for "engine-unit" item.
Is it normal? My expectations was something like this:
1) demo-* files have minimal set of items/recipes
2) other files have remaining items/recipes
Multiple recipe for item
- Dron-elektron
- Manual Inserter
- Posts: 4
- Joined: Thu Jan 02, 2020 4:25 pm
- Contact:
- Dron-elektron
- Manual Inserter
- Posts: 4
- Joined: Thu Jan 02, 2020 4:25 pm
- Contact:
Re: Multiple recipe for item
Looks like this is a bug and somebody from devs forgot to remove recipe from... recipe.lua?
P.S. Moderators, please move this topic to "Bug Reports" section.
P.S. Moderators, please move this topic to "Bug Reports" section.
Re: Multiple recipe for item
[Koub] Right, moving this to bug reports then.
Koub - Please consider English is not my native language.
- TruePikachu
- Filter Inserter
- Posts: 978
- Joined: Sat Apr 09, 2016 8:39 pm
- Contact:
Re: Multiple recipe for item
It shouldn't affect anything within the game, however; since the recipies have the same name, the one that's read later is the one that will be used (and that one is the non-demo-file version).
- Dron-elektron
- Manual Inserter
- Posts: 4
- Joined: Thu Jan 02, 2020 4:25 pm
- Contact:
Re: Multiple recipe for item
Yes, I know that, but this is a potential problem if something suddenly changes in the data reading algorithm. It’s just ideologically wrong...
- Deadlock989
- Smart Inserter
- Posts: 2528
- Joined: Fri Nov 06, 2015 7:41 pm
Re: Multiple recipe for item
If it doesn't have any effect whatsoever, how is it a "bug"?Dron-elektron wrote: ↑Sat Jan 04, 2020 9:37 pmYes, I know that, but this is a potential problem if something suddenly changes in the data reading algorithm. It’s just ideologically wrong...
- Dron-elektron
- Manual Inserter
- Posts: 4
- Joined: Thu Jan 02, 2020 4:25 pm
- Contact:
Re: Multiple recipe for item
Full and demo files shouldn't intersect and overriding is not a solution, it's just ignoring of a potential problem.
Let's developers to decide for themselves, is it a bug or not. I want developers to just know about this "little problem"
Let's developers to decide for themselves, is it a bug or not. I want developers to just know about this "little problem"
Re: Multiple recipe for item
Because clean code matters.Deadlock989 wrote: ↑Sat Jan 04, 2020 10:06 pmIf it doesn't have any effect whatsoever, how is it a "bug"?Dron-elektron wrote: ↑Sat Jan 04, 2020 9:37 pmYes, I know that, but this is a potential problem if something suddenly changes in the data reading algorithm. It’s just ideologically wrong...
Re: Multiple recipe for item
This will be fixed when we remove the NPE and cleanup what is in the demo