Page 1 of 1

[0.17.48] Possible to put offshore pump on the edge of shallow/deep water

Posted: Mon Jun 10, 2019 11:15 am
by Dev-iL
As I understand, the shallow (walkable) water terrain should not allow any buildings on top of it, however, it is currently possible to place an offshore pump on the interface between it and water (but not connect any pipes to it).

Image

Re: [0.17.48] Possible to put offshore pump on the edge of shallow/deep water

Posted: Thu Jun 20, 2019 10:15 am
by posila
Thanks for the report.

As Twinsen would say ... I fucked myself. Offshore pump is built on water (not on ground), but it has check that tile adjacent to it's pipe output has ground collision layer.

I really, really want to avoid adding new collision layers, as it would mean I would have to remove one of the few unused layers exposed to mods (layer-11 to layer-15), I absolutely didn't want to do full pipe buildability check and it made sense to me at that time to do it as "collision test" - test if tile has collision layer(s), as opposed to using regular "collision mask" which would test the tile doesn't collide with given layers. So solution would be to change the fluid_box_tile_collision_test to fluid_box_tile_collision_mask, but I don't want to bring more wrath of modders onto us, just because of this minor issue, so I'll do it after 0.17 is stable for future releases.

Re: [0.17.48] Possible to put offshore pump on the edge of shallow/deep water

Posted: Thu Jun 20, 2019 10:42 am
by eradicator
posila wrote:
Thu Jun 20, 2019 10:15 am
but I don't want to bring more wrath of modders onto us
The amount of wrath is linearly dependant on the usefulness of the "fix" to modders. If the fix happens to solve the sandpit only on sand problem you could easily generate negative wrath :mrgreen: . (I couldn't resist to make that joke...)