[0.18.14] on_gui_closed and player.opened = gui issue

Things that has been reported already before.
Post Reply
User avatar
bobingabout
Smart Inserter
Smart Inserter
Posts: 7351
Joined: Fri May 09, 2014 1:01 pm
Contact:

[0.18.14] on_gui_closed and player.opened = gui issue

Post by bobingabout »

It seems that the recent update to 0.18.14 has broken the way assigning a custom GUI to player.opened works.
Even though I have specific conditions on on_gui_closed to look for my GUI and only close it if it's an appropriate time to do so, it's instantly closing anyway when I assign it to player.opened, causing my inserters mod to crash.
Definitely works fine in 0.18.12, 0.18.13 unconfirmed, but since people are reporting specifically that my mod broke in 0.18.14, I suspect it works in 0.18.13.

To cause these issues, use my inserters mod: https://mods.factorio.com/mod/bobinserters
Point to an inserter, press SHIFT+E, or CTRL+E to open the "Screen" GUI. (It also opens on the left when you click an inserter to open the inserter GUI, but that one isn't crashing because it's not using player.opened = gui)
Last edited by bobingabout on Thu Mar 19, 2020 1:59 am, edited 1 time in total.
Creator of Bob's mods. Expanding your gameplay since version 0.9.8.
I also have a Patreon.

User avatar
bobingabout
Smart Inserter
Smart Inserter
Posts: 7351
Joined: Fri May 09, 2014 1:01 pm
Contact:

Re: [0.18.14] on_gui_closed and player.opened = gui issue

Post by bobingabout »

After looking at other bugs, it may be an issue with defines.gui_type.custom, which I initially didn't see because it's in the "resolved for next release" section.

Please could you confirm my mod works with the fix before marking it as duplicate.
Creator of Bob's mods. Expanding your gameplay since version 0.9.8.
I also have a Patreon.

Rseding91
Factorio Staff
Factorio Staff
Posts: 13171
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: [0.18.14] on_gui_closed and player.opened = gui issue

Post by Rseding91 »

Confirmed it works correctly in the next release.
If you want to get ahold of me I'm almost always on Discord.

User avatar
bobingabout
Smart Inserter
Smart Inserter
Posts: 7351
Joined: Fri May 09, 2014 1:01 pm
Contact:

Re: [0.18.14] on_gui_closed and player.opened = gui issue

Post by bobingabout »

Thank you.
Creator of Bob's mods. Expanding your gameplay since version 0.9.8.
I also have a Patreon.

Post Reply

Return to “Duplicates”