Factorio Forums

Rseding91 wrote: ↑Mon Nov 04, 2019 3:24 pm The benefits:

* Mods would never need to worry that other mods pass garbage data in events.

* We (Wube) can add event filtering for the script-raised-X events.


What I want to know is: what does the modding community think about this?

Bilka wrote: ↑Wed Nov 06, 2019 10:33 am A system that allows this behavior is complete garbage from the perspective of a mod author that wants to just use an event the way the documentation says it works.

eradicator wrote: ↑Wed Nov 06, 2019 6:53 pm The main problem here is: If i fail at convincing you that my edge case is worth implementing an extra "raise_x" then my only option would be to not raise anything at all.

we have no way to verify anything given to us from script.raise_event

justarandomgeek wrote: ↑Thu Nov 07, 2019 12:17 am

eradicator wrote: ↑Wed Nov 06, 2019 6:53 pm The main problem here is: If i fail at convincing you that my edge case is worth implementing an extra "raise_x" then my only option would be to not raise anything at all.

No, your option is to raise your own event.

quyxkh wrote: ↑Thu Nov 07, 2019 3:28 am I don't understand

we have no way to verify anything given to us from script.raise_event

at all. It can't mean "we have no access to the arguments", it can't mean "we can't read or check the contents of lua tables". What can you do with burst parameters that you can't do with table entries?

Optera wrote: ↑Fri Nov 08, 2019 11:05 am -1

If I had to convince you (Wube) each time I needed an event for LTNs API developing it would've taken months instead of days.
With the current free system when Eduran needed more data or a completely new event all we had to do is start a discord conversation and we had the api changes worked out in hours.
With the proposed system we'd have to figure out the changes pass them to Wube and hope they get implemented at all.

Rseding91 wrote: ↑Fri Nov 08, 2019 12:22 am The more I think about it the more I think it just doesn't make sense to me for mods to really ever raise game events.

Klonan wrote: ↑Fri Nov 08, 2019 11:15 am

Rseding91 wrote: ↑Fri Nov 08, 2019 12:22 am The more I think about it the more I think it just doesn't make sense to me for mods to really ever raise game events.

Since we added the function call raising to the create_entity, revive_entity, and destroy_entity things, I haven't needed to raise any base game events manually

Mylon wrote: ↑Sat Nov 09, 2019 5:59 pm I don't like the create_entity, revive_entity, or destroy_entity because these events aren't fired by anything in the base game. The context of these events is nearly identical to on_entity_built and on_entity_died, but the likelihood of mods supporting these events is reduced and thus the chance of compatibility bugs is far higher than if there were a solution to shape these as vanilla events.

Mylon wrote: ↑Sat Nov 09, 2019 5:59 pm I don't like the create_entity, revive_entity, or destroy_entity because these events aren't fired by anything in the base game. The context of these events is nearly identical to on_entity_built and on_entity_died, but the likelihood of mods supporting these events is reduced and thus the chance of compatibility bugs is far higher than if there were a solution to shape these as vanilla events.

Bilka wrote: ↑Sat Nov 09, 2019 6:14 pm

Mylon wrote: ↑Sat Nov 09, 2019 5:59 pm I don't like the create_entity, revive_entity, or destroy_entity because these events aren't fired by anything in the base game. The context of these events is nearly identical to on_entity_built and on_entity_died, but the likelihood of mods supporting these events is reduced and thus the chance of compatibility bugs is far higher than if there were a solution to shape these as vanilla events.

So you raise on_built_entity with missing parameters and break mods subscribing to it normally. I really prefer subscribing to "script_raised_built" over having my mods broken by mod authors raising bad events.

function()
create_entity{raise_build=false}
--dostuff
script.raise_event(defines.events.on_built,...)
end

eradicator wrote: ↑Sat Nov 09, 2019 7:52 pm Btw, here's another usecase for manually raising on_build: If i use create_entity{raise_build=true} then another mod could destroy the created entity before i even ever see it. Therefor

Code: Select all

function()
create_entity{raise_build=false}
--dostuff
script.raise_event(defines.events.on_built,...)
end

means i have to care about less shit that other mods might do to my entities.