[0.15.5] Crash with compressed coal (mod item) in boiler

[factoriomayo]

Reproduction

1. Install mod "OreCompress" from mod portal (https://mods.factorio.com/mods/Zaflis/OreCompress)
2. Start new game.
2. Put "compressed coal" (item from mod) into boiler.
3. Game crashes.

Error.jpg (72.63 KiB) Viewed 2379 times

Maybe a bug from the mod itself or the item prototype:

Code: Select all

{
    type = "item",
    name = "compressed-coal",
    icon = "__OreCompress__/graphics/compressed-coal.png",
    flags = {"goes-to-main-inventory"},
    fuel_value = "160MJ",
    subgroup = "raw-material",
    order = "[compressed-coal]",
    stack_size = 100,
}

"fuel_value" is set, nevertheless the game should not crash from putting it into the boiler.

[Loewchen]

Code: Select all

   0.009 2017-04-30 14:44:34; Factorio 0.15.5 (build 29304, win64, alpha)
   0.009 Operating system: Windows 10 (version 1607) 
   0.009 Program arguments: "C:\Spiele\Factorio\bin\x64\factorio.exe" 
   0.009 Read data path: C:/Spiele/Factorio/data
   0.009 Write data path: C:/Spiele/Factorio
   0.009 Binaries path: C:/Spiele/Factorio/bin
   0.027 System info: [CPU: Intel(R) Core(TM) i5-4590 CPU @ 3.30GHz, 4 cores, RAM: 8142MB]
   0.028 Display options: [FullScreen: 0] [VSync: 0] [UIScale: 100%] [MultiSampling: OFF] [Screen: 255]
   0.028 Available display adapters: 1
   0.028  [0]: \\.\DISPLAY1 - NVIDIA GeForce GTX 770 {0x05, [0,0], 1680x1050, 32bit, 60Hz}
   0.029 Create display on adapter 0. Size 1280x720 at position [190, 147].
   0.093 Initialised Direct3D:[0] NVIDIA GeForce GTX 770; driver: nvd3dumx.dll 21.21.13.7653
   0.095     Video memory size (dedicated video/dedicated system/shared system/available): 2017/0/4071/4092 MB
   0.120 DSound: Starting _dsound_update thread
   0.120 DSound: Enter _dsound_update; tid=1876
   0.121 Device reset internal.
   0.123 Desktop composition is active.
   0.123 Graphics settings preset: very-high
   0.123 Graphics options: [Graphics quality: normal] [Video memory usage: high] [Light scale: 100%] [DXT: false]
   0.199 Loading mod core 0.0.0 (data.lua)
   0.224 Loading mod base 0.15.5 (data.lua)
   0.544 Loading mod OreCompress 0.15.0 (data.lua)
   0.603 Loading mod base 0.15.5 (data-updates.lua)
   0.664 Checksum for core: 2926038370
   0.664 Checksum of base: 2698305660
   0.664 Checksum of OreCompress: 179549645
   0.815 Info PlayerData.cpp:55: Local player-data.json available, timestamp 1493555909
   0.815 Info PlayerData.cpp:62: Cloud player-data.json unavailable
   0.926 Loaded shader file C:/Spiele/Factorio/data/core/graphics/shaders/game.cso
   0.928 Loaded shader file C:/Spiele/Factorio/data/core/graphics/shaders/zoom-to-world.cso
   0.939 Initial atlas bitmap size is 16384
   0.941 Created atlas bitmap 16384x7695
   1.398 Created atlas bitmap 4096x1860
   1.415 Created atlas bitmap 4096x3652
  10.501 Sprites loaded
  10.501 Convert atlas 4096x1860 to: trilinear-filtering 
  10.602 Convert atlas 4096x3652 to: mipmap 
  11.281 Loading sounds...
  14.737 Custom inputs active: 0
  14.742 Info Updater.cpp:753: Downloading https://updater.factorio.com/get-available-versions?username=xxx&token=<private>&apiVersion=2
  15.413 0 packages available to download (experimental updates enabled).
  15.450 Device reset internal.
  16.042 Factorio initialised
  22.427 Info HttpSharedState.cpp:44: Downloading https://mods.factorio.com/api/mods?page_size=max&namelist=OreCompress
  23.044 Info HttpSharedState.cpp:111: Status code: 200
  32.278 Loading Level.dat: 988783 bytes.
  32.278 Info Scenario.cpp:133: Map version 0.15.5-1
  32.327 Checksum for script C:/Spiele/Factorio/temp/currently-playing/control.lua: 76911248
  52.688 Loading Level.dat: 915213 bytes.
  52.688 Info Scenario.cpp:133: Map version 0.15.5-1
  52.730 Checksum for script C:/Spiele/Factorio/temp/currently-playing/control.lua: 3177558831
  74.911 Error CrashHandler.cpp:141: Exception Code: c0000005, Address: 0x00007ff79c671de5
ModuleBase: 0x00007ff79c000000, ImageSize: 0119d000, RelativeAddress: 00671de5
  74.911 Error CrashHandler.cpp:151: Exception Context:
rax=00000013ff65f0a0, rbx=00000013ff65f0a0, rcx=00000013ff65f0a0,
rdx=0000000000000028, rsi=000001668e5ec038, rdi=0000000000000028,
rip=00007ff79c671de5, rsp=00000013ff65ee70, rbp=0000000000000000,
 r8=0000000000000000,  r9=ffffffffffffffff, r10=00007ff79cc6ac50,
r11=00000166d3e02ef0, r12=00000013ff65f1c0, r13=0004960cd8fbacec,
r14=00000013ff65f3b0, r15=00000013ff65f1a0
  74.911 Crashed in C:\Spiele\Factorio\bin\x64\factorio.exe (0x00007ff79c000000 - 0x00007ff79d19d000)
Factorio crashed. Generating symbolized stacktrace, please wait ...
c:\cygwin64\tmp\factorio-pnul0i\libraries\stackwalker\stackwalker.cpp (923): StackWalker::ShowCallstack
c:\cygwin64\tmp\factorio-pnul0i\src\util\logger.cpp (354): Logger::writeStacktrace
c:\cygwin64\tmp\factorio-pnul0i\src\util\logger.cpp (408): Logger::logStacktrace
c:\cygwin64\tmp\factorio-pnul0i\src\util\crashhandler.cpp (105): CrashHandler::writeStackTrace
c:\cygwin64\tmp\factorio-pnul0i\src\util\crashhandler.cpp (177): CrashHandler::SehHandler
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFB6F6A4F77)
00007FFB6F6A4F77 (KERNELBASE): (filename not available): UnhandledExceptionFilter
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFB730DED1B)
00007FFB730DED1B (ntdll): (filename not available): memset
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFB730C6BD6)
00007FFB730C6BD6 (ntdll): (filename not available): _C_specific_handler
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFB730DAB9D)
00007FFB730DAB9D (ntdll): (filename not available): _chkstk
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFB73079913)
00007FFB73079913 (ntdll): (filename not available): RtlImageNtHeaderEx
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFB730D9CBA)
00007FFB730D9CBA (ntdll): (filename not available): KiUserExceptionDispatcher
c:\program files (x86)\microsoft visual studio 14.0\vc\include\xstring (1150): std::basic_string<char,std::char_traits<char>,std::allocator<char> >::assign
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FF79C01B201)
00007FF79C01B201 (factorio): (filename not available): LocalisedString::LocalisedString
c:\cygwin64\tmp\factorio-pnul0i\src\util\localisedstring.cpp (170): LocalisedString::LocalisedString
c:\cygwin64\tmp\factorio-pnul0i\src\energy\burner.cpp (247): Burner::canInsertAt
c:\cygwin64\tmp\factorio-pnul0i\src\entity\boiler.cpp (219): Boiler::canInsertAt
c:\cygwin64\tmp\factorio-pnul0i\src\controller\controller.cpp (180): Controller::checkInsertability
c:\cygwin64\tmp\factorio-pnul0i\src\gameactionhandler.cpp (1528): GameActionHandler::cursorTransfer
c:\cygwin64\tmp\factorio-pnul0i\src\gameactionhandler.cpp (263): GameActionHandler::actionPerformed
c:\cygwin64\tmp\factorio-pnul0i\src\input\inputhandler.cpp (55): InputHandler::flushToListeners
c:\cygwin64\tmp\factorio-pnul0i\src\input\inputhandler.cpp (47): InputHandler::flushActions
c:\cygwin64\tmp\factorio-pnul0i\src\gameactionhandler.cpp (305): GameActionHandler::update
c:\cygwin64\tmp\factorio-pnul0i\src\mainloop.cpp (819): MainLoop::gameUpdateStep
c:\cygwin64\tmp\factorio-pnul0i\src\mainloop.cpp (695): MainLoop::gameUpdateLoop
c:\cygwin64\tmp\factorio-pnul0i\src\util\workerthread.cpp (35): WorkerThread::loop
c:\program files (x86)\microsoft visual studio 14.0\vc\include\thr\xthread (247): std::_LaunchPad<std::unique_ptr<std::tuple<void (__cdecl*)(ParallelScenarioSaver * __ptr64),ParallelScenarioSaver * __ptr64>,std::default_delete<std::tuple<void (__cdecl*)(ParallelScenarioSaver * __ptr64),ParallelScenarioSaver * __ptr64> > > >::_Run
c:\program files (x86)\microsoft visual studio 14.0\vc\include\thr\xthread (210): std::_Pad::_Call_func
d:\th\minkernel\crts\ucrt\src\appcrt\startup\thread.cpp (115): thread_start<unsigned int (__cdecl*)(void * __ptr64)>
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFB71F88364)
00007FFB71F88364 (KERNEL32): (filename not available): BaseThreadInitThunk
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFB730970D1)
00007FFB730970D1 (ntdll): (filename not available): RtlUserThreadStart
  76.041 Error CrashHandler.cpp:106: Map tick at moment of crash: 1269
  76.041 Error Util.cpp:76: Unexpected error occurred. If you're running the latest version of the game you can help us solve the problem by posting the contents of the log file on the Factorio forums.
Please also include the save file(s), any mods you may be using, and any steps you know of to reproduce the crash.

[posila]

Hi, thanks for the report.
The item needs to have also fuel_category specified, when fuel_value is set.
I'll add check for 0.15.6 to prevent crash.

[Zaflis]

API says it can be nil (not specified?)
http://lua-api.factorio.com/0.15.5/LuaI ... l_category

[posila]

It can be nil on items that are not fuel