[Rseding] [0.17.x] Join server after [mod] sync caches server?

[jokerwing]

1. Try to join public game with password (that has different mods) ['server 1']
["active mods don't match ...] (server 1 mod list)
2. Check "join server after sync"
3. Confirm
[game restarts]
[game asks for password]
4. Back
5. Join new public game without password ['server 2']
["active mods don't match ...] (server 2 mod list)
6. Synchronize
7. Confirm
[game restarts]
["your active mods don't match the server's"] (asks to sync mod list from server 1)
8. Synchronize [again]
[game restarts]
[game asks for password of first server]

[Rseding91]

Thanks for the report however I can't reproduce what you describe. When I test, I can watch the command line arguments being passed from one instance of the game to the next and the old server it was trying to connect to is always removed from the arguments.

My only guess is: between trying to sync and restarting someone shut down the server and started a different one with the same IP.

[jokerwing]

I experienced something similar again today on 0.18.26
It happens consistently so I saved a video capture and uploaded to https://youtu.be/jc22VVzhzss

As the video starts I'm in a Krastorio Server (what a great mod)
I quit Krastorio
:14 I attempt to join a vanilla comfy
:18 I'm prompted to synchronize mods @:18 ("join server after sync" is selected)
(My expectation is that I should do click "synchronize" and load into comfy)
:37 Client reloads and menu popups that mods are synchronized (they match COMFY vanilla mods but Factorio thinks I want to join Krastorio server)
:46 I click synchronize again
1:06 Client reloads and joins Krastorio Server (you can skip to 2:20 to see it's Krastorio and not comfy)

[Rseding91]

I experienced something similar again today on 0.18.26
It happens consistently so I saved a video capture and uploaded to https://youtu.be/jc22VVzhzss

As the video starts I'm in a Krastorio Server (what a great mod)
I quit Krastorio
:14 I attempt to join a vanilla comfy
:18 I'm prompted to synchronize mods @:18 ("join server after sync" is selected)
(My expectation is that I should do click "synchronize" and load into comfy)
:37 Client reloads and menu popups that mods are synchronized (they match COMFY vanilla mods but Factorio thinks I want to join Krastorio server)
:46 I click synchronize again
1:06 Client reloads and joins Krastorio Server (you can skip to 2:20 to see it's Krastorio and not comfy)

Still, I can't reproduce anything when I try to do that exact series of steps.

[jokerwing]

Thanks for taking a look again.
Is there any extra information I could provide that might assist in reproducing?

[Rseding91]

Thanks for taking a look again.
Is there any extra information I could provide that might assist in reproducing?

My current theory is Steam is some how messing with the arguments the game tries to use and re-uses the old ones. If someone was able to reproduce the issue every time outside of steam that would eliminate that as a potential error source.

Just getting it reproducible every time is the main issue.

[jokerwing]

More info. It's possible this requires a more complicated repro that moves through several mods states.

I run `ps aux | grep factorio` and have seen

factorio --mp-connect X.X.X.67:34197
factorio X.X.X.67:34197 --mp-connect X.X.X.67:34197`
factorio X.X.X.163:34197 --join-game-by-steam-id 76561198853801670 --mp-connect Y.Y.Y.Y:34197

---

It seems that on relaunch via steam it keeps some of the old args.

1. Enable any mod
2. Connect to a vanilla server (mod synch, join on sync)
launched as: factorio --mp-connect X.X.X.X:34203
3. Quit map, enable some more mods
launched as: factorio X.X.X.X:34203 but doesn't attempt to join server
4. Try to connect to another vanilla server
launched as: factorio X.X.X.X:34203 --mp-connect Y.Y.Y.Y:46103
(connects to Y correct)
5. Quit map, enable more mods
launched as: factorio X.X.X.X:34203 Y.Y.Y.Y:34203

This doesn't reproduce my issue but confirms your suspicion