Page 1 of 1

Remove result and count from MinableProperties

Posted: Sun Jul 21, 2024 9:30 am
by KiwiHawk
Request: Remove result and count from MinableProperties
MinablePropertes can have results OR result and count. Having multiple ways of defining minable properties causes confusion and mod compatibility issues. Removing result and count would be almost exactly the same change that was already made (for 2.0) to RecipePrototype: removing result and result_count.

MinableProperties.png
MinableProperties.png (60.47 KiB) Viewed 460 times
Secondary Request: Remove short syntax for ItemIngredientPrototype
ItemIngredientPrototype can be specified as a table with named or numbered keys. Short syntax ({"item-name", 39}) has been removed for 2.0 for ItemProductPrototype. Please apply this change to ingredients as well! It will make our life as modders much simpler when updating recipes.

ResultResultCount.png
ResultResultCount.png (38.79 KiB) Viewed 460 times

Screenshot posted on Discord by boskid.

Re: Remove result and count from MinableProperties

Posted: Sun Jul 21, 2024 9:36 am
by boskid
I am not touching item ingredients because it creates insane amount of diffs around cost in technology prototype. If you have good arguments maybe other dev would do it.

Re: Remove result and count from MinableProperties

Posted: Sun Jul 21, 2024 2:55 pm
by curiosity
boskid wrote:
Sun Jul 21, 2024 9:36 am
I am not touching item ingredients because it creates insane amount of diffs around cost in technology prototype.
Why is this a problem, exactly?

Alternatively, if you are so opposed to changing technology prototype definition, split it off. Technology costs can only be tool prototypes anyway.

Re: Remove result and count from MinableProperties

Posted: Sun Jul 28, 2024 5:27 pm
by boskid
Bilka made an executive decision, IngredientPrototype will no longer support short syntax. IngredientPrototype's type will be mandatory. Those changes will be released with 2.0.

To not mess up with technologies, since technologies only support items they wont be using IngredientPrototype but instead will be using ResearchIngredient that only supports short syntax (at prototype stage).

However MinableProperties result/count... it an extremally controversial change