Modding a Mod (fluidbox and recipie)

[Baruk]

Hi, just started to look into things behind.

I wanted to to change a small chain in Angels Petrochem. To get sodium hydroxide you have to use the electrolyser.

I changed the recipe to get chlorine, hydrogen and sodium hydroxide solution. With FNEI and Helmod all things seems to be fine.
BUT in the recipie list of the electrolyser the water saline separation is not available, most probably because there are 3 fluid products.
So next step was to modify the electrolysers fluid box to 3 outputs (added one in the middle output side). But still no effect.
The already placed electrolysers have still 2 outputs. If I craft a new one still 2 outputs and no chance to activate the recipie.
I change he water saline separation recipie to 2 fluid output (chlorine and sodium hydroxide solution) and it worked missing the hydrogen.

The continued "chain" is the crystallisation of sodium hydroxide solution to solid form. It worked so far.

My first question is: why does the electrolyser not work with 3 outputs (where do I find the working script [is there one])?
Secondly, is there a possibillity to adjust the fluid box outputs depending on the chosen recipie like assembling machines with optional fluidbox (different topic I guess, because its more on/off rather than switching in between)?
Third, is there a list to show the variables like in the assembling machine script "off_when_no_fluid_recipe = true"? I guess, its hidden in the control script section.

Hope someone can clarify some things to me.

Thanks.

Baruk

[darkfrei]

So next step was to modify the electrolysers fluid box to 3 outputs (added one in the middle output side). But still no effect.
The already placed electrolysers have still 2 outputs. If I craft a new one still 2 outputs and no chance to activate the recipie.
I change he water saline separation recipie to 2 fluid output (chlorine and sodium hydroxide solution) and it worked missing the hydrogen.

Please attach your code / your mod and we can find the error much faster.

[Baruk]

This is the modified part of electrolyser.lua of angels petrochem. I just added a third output.
But the electolyser does not indicate a 3rd output (Alt-key output-triangel)

electrolyser.lua

Code: Select all

   
  {   
    type = "assembling-machine",
    name = "angels-electrolyser",
    icons = {
		{
			icon = "__angelspetrochem__/graphics/icons/electrolyser.png",
		},
		{
			icon = "__angelspetrochem__/graphics/icons/num_1.png",
			tint = {r = 0.8, g = 0.8, b = 0.8, a = 0.5},
			scale = 0.32,
			shift = {-12, -12},
		}
	},
	icon_size = 32,	
	flags = {"placeable-neutral","player-creation"},
    minable = {mining_time = 1, result = "angels-electrolyser"},
	fast_replaceable_group = "angels-electrolyser",
    max_health = 300,
	corpse = "big-remnants",
    dying_explosion = "medium-explosion",
    collision_box = {{-2.4, -2.4}, {2.4, 2.4}},
    selection_box = {{-2.5, -2.5}, {2.5, 2.5}},
    module_specification =
    {
      module_slots = 2
    },
    allowed_effects = {"consumption", "speed", "productivity", "pollution"},
    crafting_categories = {"petrochem-electrolyser"},
    crafting_speed = 1,
    energy_source =
    {
      type = "electric",
      usage_priority = "secondary-input",
      emissions = 0.02 / 2
    },
    energy_usage = "300kW",
    ingredient_count = 3,
	animation =
    {
      north =
      {
        filename = "__angelspetrochem__/graphics/entity/electrolyser/electrolyser-north.png",
        width = 224,
        height = 224,
        frame_count = 36,
		line_length = 6,
        shift = {0, 0},
		animation_speed = 0.5
      },
      east =
      {
        filename = "__angelspetrochem__/graphics/entity/electrolyser/electrolyser-east.png",
        width = 224,
        height = 224,
        frame_count = 36,
		line_length = 6,
        shift = {0, 0},
		animation_speed = 0.5
      },
      south =
      {
        filename = "__angelspetrochem__/graphics/entity/electrolyser/electrolyser-north.png",
        width = 224,
        height = 224,
        frame_count = 36,
		line_length = 6,
        shift = {0, 0},
		animation_speed = 0.5
      },
      west =
      {
        filename = "__angelspetrochem__/graphics/entity/electrolyser/electrolyser-east.png",
        width = 224,
        height = 224,
        frame_count = 36,
		line_length = 6,
        shift = {0, 0},
		animation_speed = 0.5
      }
    },
    vehicle_impact_sound =  { filename = "__base__/sound/car-metal-impact.ogg", volume = 0.65 },
    working_sound =
    {
      sound = { filename = "__angelspetrochem__/sound/electrolyser.ogg" },
	  idle_sound = { filename = "__base__/sound/idle1.ogg", volume = 0.6 },
      apparent_volume = 2.5,
    },
	fluid_boxes =
    {
      {
        production_type = "input",
		pipe_picture = electrolyserpictures(),
        pipe_covers = pipecoverspictures(),
        base_area = 10,
        base_level = -1,
        pipe_connections = {{ type="input", position = {-2, -3} }}
      },
      {
        production_type = "input",
		pipe_picture = electrolyserpictures(),
        pipe_covers = pipecoverspictures(),
        base_area = 10,
        base_level = -1,
        pipe_connections = {{ type="input", position = {2, -3} }}
      },
	  {
        production_type = "output",
		pipe_picture = electrolyserpictures(),
        pipe_covers = pipecoverspictures(),
        base_level = 1,
        pipe_connections = {{ position = {-2, 3} }}
      },
      -- part added
      {
        production_type = "output",
        pipe_picture = electrolyserpictures(),
		pipe_covers = pipecoverspictures(),
        base_level = 1,
        pipe_connections = {{ position = {0, 3} }}
      },
     --
       {
        production_type = "output",
		pipe_picture = electrolyserpictures(),
        pipe_covers = pipecoverspictures(),
        base_level = 1,
        pipe_connections = {{ position = {2, 3} }}
      }
    },
    pipe_covers = pipecoverspictures()
    },

And that is the part in recipies petrochem-chlorine.lua
I added the solution and commented out the solid-sodium-hydroxide. I changed the sequence to check whether my extra fluid works or not.
2-fluid output is working, 3 not.

recipies petrochem-chlorine.lua

Code: Select all

	--CHLORINE
	{
		type = "recipe",
		name = "water-saline-separation",
		category = "petrochem-electrolyser",
		subgroup = "petrochem-chlorine",
		energy_required = 2,
		enabled = "false",
		ingredients ={
			{type="fluid", name="water-saline", amount=100}
		},
		results=
		{
			{type="fluid", name="gas-chlorine", amount=20}, -- 40
			-- {type="fluid", name="gas-hydrogen", amount=30}, -- 60
			-- part added
                        {type="fluid", name="liquid-sodium-hydroxide-solution", amount=50},[/b]
                        --
			{type="fluid", name="gas-hydrogen", amount=30}, -- 60
			-- {type="item", name="solid-sodium-hydroxide", amount=1},
		},
		icon = "__angelspetrochem__/graphics/icons/raw-separation-5.png",
		icon_size = 32,
		order = "a[water-saline-separation]",
	},

That is the part in recipies petrochem-sodium.lua
The addition is the first recipie. I renames the second to solid-sodium-hydroxide-1. I don't know by now if it's neccessary.
But the good thing, it's working.

recipies petrochem-sodium.lua

Code: Select all

	{
		type = "recipe",
		name = "solid-sodium-hydroxide",
		category = "chemistry",
		subgroup = "petrochem-sodium",
		energy_required = 2,
		enabled = "false",
		ingredients ={
			{type="fluid", name="liquid-sodium-hydroxide-solution", amount=60},
		},
		results=
		{
			{type="item", name="solid-sodium-hydroxide", amount=5},
			{type="fluid", name="water-purified", amount=50},
		},
		main_product= "solid-sodium-hydroxide",
		icon = "__angelspetrochem__/graphics/icons/solid-sodium-hydroxide.png",
		icon_size = 32,
		order = "c[solid-sodium-hydroxide]",
	},
	{
		type = "recipe",
		name = "solid-sodium-hydroxide-1", -- original
		category = "liquifying",
		subgroup = "petrochem-sodium",
		energy_required = 2,
		enabled = "false",
		ingredients ={
			{type="item", name="solid-sodium", amount=5},
			{type="fluid", name="water-purified", amount=50},
		},
		results=
		{
			{type="item", name="solid-sodium-hydroxide", amount=5},
		},
		icon = "__angelspetrochem__/graphics/icons/solid-sodium-hydroxide.png",
		icon_size = 32,
		order = "c[solid-sodium-hydroxide-1]",
	},

Change in Items petrochem-sodium.lua to define the fluid. It's fine used as intended, but not with the recipie in mind.

Items petrochem-sodium.lua

Code: Select all

{
    type = "fluid",
    name = "liquid-sodium-hydroxide-solution",
    icon = "__angelspetrochem__/graphics/icons/liquid-sodium-hydroxide-solution.png",
	icon_size = 32,
	subgroup = "fluids-petro",
	default_temperature = 25,
    heat_capacity = "0.1KJ",
    base_color = {r = 0.9, g = 0.9, b = 0.9},
    flow_color = {r = 0.9, g = 0.9, b = 0.9},
    max_temperature = 100,
	pressure_to_speed_ratio = 0.4,
    flow_to_energy_ratio = 0.59,
},

If you need more, I don't know what to post else than the whole mod created by Angel with the tiny changes I made (for me).

If it's working in future I would try to include it into a own mod, where these parts overwriting Angels mod to let his mod untouched.

Baruk

[darkfrei]

'angels-electrolyser' already has 4 fluid boxes:

Code: Select all

data.raw["assembling-machine"]["angels-electrolyser"].fluid_boxes[1].pipe_connections[1].type = "input" 
data.raw["assembling-machine"]["angels-electrolyser"].fluid_boxes[1].pipe_connections[1].position[1] = -2 
data.raw["assembling-machine"]["angels-electrolyser"].fluid_boxes[1].pipe_connections[1].position[2] = -3

data.raw["assembling-machine"]["angels-electrolyser"].fluid_boxes[2].pipe_connections[1].type = "input" 
data.raw["assembling-machine"]["angels-electrolyser"].fluid_boxes[2].pipe_connections[1].position[1] = 2 
data.raw["assembling-machine"]["angels-electrolyser"].fluid_boxes[2].pipe_connections[1].position[2] = -3 

data.raw["assembling-machine"]["angels-electrolyser"].fluid_boxes[3].pipe_connections[1].position[1] = -2 
data.raw["assembling-machine"]["angels-electrolyser"].fluid_boxes[3].pipe_connections[1].position[2] = 3 

data.raw["assembling-machine"]["angels-electrolyser"].fluid_boxes[4].pipe_connections[1].position[1] = 2 
data.raw["assembling-machine"]["angels-electrolyser"].fluid_boxes[4].pipe_connections[1].position[2] = 3

So, if you want to add the new input, it must be something like:

Code: Select all

if data.raw["assembling-machine"]["angels-electrolyser"] and data.raw["assembling-machine"]["angels-electrolyser"].fluid_boxes then
  local new_fluid_box = table.deepcopy(data.raw["assembling-machine"]["angels-electrolyser"].fluid_boxes[1])
  new_fluid_box.pipe_connections = {type = "input", position = {0, -3}}
  table.insert (table.deepcopy(data.raw["assembling-machine"]["angels-electrolyser"].fluid_boxes, new_fluid_box)
end

With this code you don't create the same entity, but correct the old one if it exists.

Output is the same, but here must be copied third fluid box:

Code: Select all

if data.raw["assembling-machine"]["angels-electrolyser"] and data.raw["assembling-machine"]["angels-electrolyser"].fluid_boxes then
  local new_fluid_box = table.deepcopy(data.raw["assembling-machine"]["angels-electrolyser"].fluid_boxes[3])
  new_fluid_box.pipe_connections = {position = {0, 3}}
  table.insert (table.deepcopy(data.raw["assembling-machine"]["angels-electrolyser"].fluid_boxes, new_fluid_box)
end

[Baruk]

Thanks for the reply. It makes fully sense. The only thing I wonder is; where did you find this code parts?

I searched them, thinking something has to exist, but was not lucky to find it.

I am at the stage to modify the original code writen by Angel by implementing already the 3rd output in the buildings definition part, or miss I something?

Baruk

[darkfrei]

Thanks for the reply. It makes fully sense. The only thing I wonder is; where did you find this code parts?

My mod info-mod: viewtopic.php?f=135&t=45107
You can find whole data.raw into .log file. You are also need something like Notepad++ for 10-100 MB files opening.

[Baruk]

Again many thanks.

Just to prove my understanding.

The building prototypes are only read at first use or even the beginning of the game/ adding the mod. Thereafter it is stored in the game database and will be used regardless of changes in the prototype. Because entities already created, either placed or in inventory, changes are only possible by manipulating the tables.

So my further goal to write an own mod is by nature the only practicle way to introduce such things in running games.

I started a new game and there it works as intended by shortcutting in creative.

Baruk

[eradicator]

The building prototypes are only read at first use or even the beginning of the game/ adding the mod. Thereafter it is stored in the game database and will be used regardless of changes in the prototype. Because entities already created, either placed or in inventory, changes are only possible by manipulating the tables.

No. Just no. There's no "database" that stores how stuff looked when it was "built". Before the game starts (i.e. before you get to the main menu) all data/-updates/-final-fixes are evaluated to build the prototypes. This is done every time the game starts, there is no cache. A savegame only stores the name of a building. So if you build a "my-building-1", save the game, quit, change the definition of "my-building-1" then the thing in your savegame will be whatever the new definition says it is. If you're experiencing any sort of behavior that looks like "this change only works on newly built buildings" then you're doing something wrong. In your example probably something involving names. Maybe you're defining the same prototype twice and thus the first one is overwritten by the second one? Hard to tell via the code snippets. Making a new mod that modifies another mod is much cleaner and easier to debug than editing someone elses huge mod that you know almost nothing about ;).