Preventing a player from bearing arms

[DRY411S]

How could I stop a player from arming themselves? I've noted the events for when a player has changed their gun or ammo inventories, but the events seem to occur after the changes, I.e. After they have added a gun or ammo.

[DRY411S]

Hmm, I'm guessing I can get the player's gun/ammo inventory when this event occurs and return it to their main inventory. I'll try that.

[Supercheese]

Here's an old approach of mine I used a while back: https://github.com/Suprcheese/Satellite ... #L102-L108

[DRY411S]

Here's an old approach of mine I used a while back: https://github.com/Suprcheese/Satellite ... #L102-L108

Thanks. I have something that works now. This code returns any gun that a player tries to arm themselves with back to their main inventory

code

Code: Select all

script.on_event(defines.events.on_player_gun_inventory_changed,function(event)
  local player = game.players[event.player_index]
  local inventory = player.get_inventory(defines.inventory.player_guns)
  if (inventory) then
    if not inventory.is_empty() then
      local guns = inventory.get_contents()
      local gun = {}
      local main_inventory = player.get_inventory(defines.inventory.player_main)
      -- Move gun back into main inventory
      for k,v in pairs(guns) do
        gun.name = k
        gun.count = v
        main_inventory.insert(gun)
      end
      -- Clear gun inventory
      inventory.clear()
    end
  end
end)

Do you have any idea what event goes off when ammo is placed in a tank or car or artillery turret please?

[eradicator]

All factorio events fire after something happens.

A quick look at your code looks like it'll delete any guns that are still in the gun inventory if the player inventory is full. I.e. if a player with an already full inventory takes a gun out of a chest.

Do you have any idea what event goes off when ammo is placed in a tank or car or artillery turret please?

No events are ever fired for changes to inventories other than the player inventory. You're only chance would be cursor_stack_changed i guess. But then again one can just build an inserter next to the tank and put the item on the ground for it to be grabbed :P

[orzelek]

Wouldn't it be easier to simply mod out weapons and guns out of vehicles?

[DRY411S]

<snip>

A quick look at your code looks like it'll delete any guns that are still in the gun inventory if the player inventory is full. I.e. if a player with an already full inventory takes a gun out of a chest.

Thanks. I'll check that edge case. I was expecting the gun to be tossed on the ground, like when players mine things when their inventory is full, or change armor to one where there are less inventory slots.

No events are ever fired for changes to inventories other than the player inventory. You're only chance would be cursor_stack_changed i guess. But then again one can just build an inserter next to the tank and put the item on the ground for it to be grabbed

OK. I'm thinking I'll try emptying the ammo from a vehicle's guns when the player enters it, (if they are the only occupant, or the passenger), or maybe see what affects removing the permission to change shooting stance has.

The emptying when they enter idea doesn't take care of what may happen if they then add ammo after they've entered the vehicle.

If none of those ideas work I may may need to redefine the 'bear arms' concept to be personal firearms only.

[DRY411S]

Wouldn't it be easier to simply mod out weapons and guns out of vehicles?

Fair point, but this is for a role-based scenario concept, where only certain roles can fire weapons.

[DRY411S]

Edge case failed. Gun disappears into the ether as you suspected.

Now looking at at setting the player's shooting state to 'not shooting' and removing the permission to change it, as a workaround.

[Melfish]

You could make a blank not working gun and set that as equipped.

You would still have to test if someone were to remove/replace it, but then that edge case shouldn't happen.
As an added bonus, shiftclicking will not equip a gun.

I would also check if gun inventory amount is part of the player prototype, if it is you could add a player entity without any gun slots.

[DRY411S]

A quick look at your code looks like it'll delete any guns that are still in the gun inventory if the player inventory is full. I.e. if a player with an already full inventory takes a gun out of a chest.

Been away from this for a while but now have a fix for that. The items get spilled on the ground.

New code

Code: Select all

script.on_event(defines.events.on_player_gun_inventory_changed,function(event)
  local player = game.players[event.player_index]
  local inventory = player.get_inventory(defines.inventory.player_guns)
  if (inventory) then
    if not inventory.is_empty() then
      local surface = player.surface
      local guns = inventory.get_contents()
      local gun = {}
      local main_inventory = player.get_inventory(defines.inventory.player_main)
      -- Move gun back into main inventory or spill on ground
      for k,v in pairs(guns) do
        gun.name = k
        gun.count = v
        if main_inventory.insert(gun) == 0 then
          surface.spill_item_stack(player.position,gun,false)
        end
      end
      -- Clear gun inventory
      inventory.clear()
    end
  end

end)