[1.0.0] No log output when running incompatible mods on linux headless

[ct402]

What did I do:
- While trying to automate server configuration and startup (I'll post about it when it's done ^^) I probably messed up and ended up with incompatible mods/game version.

What happened:
- Running a command to build a new map with a specific mod directory containing incompatible mod silently fails to load the mod without returning any kind of warning or error in the logs.

What did I expect to happen instead:
- I expected the game to either fail to build with a proper exit code or at least to print a warning in the output that describes the error encountered, probably something like:

Code: Select all

Warning: Could not load mod XXXXX (version YYYYY of the mod is not compatible with version ZZZZZ of the base game)

The factorio logs:

Code: Select all

   0.000 2021-01-17 12:07:10; Factorio 1.0.0 (build 54889, linux64, headless)
   0.000 Operating system: Linux
   0.000 Program arguments: "/mnt/bin/1.0.0/factorio/bin/x64/factorio" "--create" "/mnt/profiles/ct/map.zip" "--mod-directory" "/mnt/profiles/kras/mods" 
   0.000 Read data path: /mnt/bin/1.0.0/factorio/data
   0.000 Write data path: /mnt/bin/1.0.0/factorio [227945/468427MB]
   0.000 Binaries path: /mnt/bin/1.0.0/factorio/bin
   0.005 System info: [CPU: Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz, 8 cores, RAM: 32083 MB]
   0.005 Environment: DISPLAY=<unset> WAYLAND_DISPLAY=<unset> DESKTOP_SESSION=<unset> XDG_SESSION_DESKTOP=<unset> XDG_CURRENT_DESKTOP=<unset> __GL_FSAA_MODE=<unset> __GL_LOG_MAX_ANISO=<unset> __GL_SYNC_TO_VBLANK=<unset> __GL_SORT_FBCONFIGS=<unset> __GL_YIELD=<unset>
   0.005 Running in headless mode
   0.068 Loading mod core 0.0.0 (data.lua)
   0.112 Loading mod base 1.0.0 (data.lua)
   0.355 Loading mod base 1.0.0 (data-updates.lua)
   0.477 Checksum for core: 2630831588
   0.477 Checksum of base: 3509992273
   0.678 Prototype list checksum: 3301461508
   0.714 Info PlayerData.cpp:68: Local player-data.json available, timestamp 1610885168
   0.714 Info PlayerData.cpp:75: Cloud player-data.json unavailable
   0.715 Factorio initialised
   0.715 Info Main.cpp:724: Creating new map /mnt/profiles/ct/map.zip
   1.212 Loading level.dat: 1153895 bytes.
   1.213 Info Scenario.cpp:187: Map version 1.0.0-0
   1.233 Checksum for script /mnt/bin/1.0.0/factorio/temp/currently-playing/control.lua: 3931528263
   1.325 Goodbye

The mod directory contains Krastorio2_1.0.23.zip (which is incompatible with 1.0.0 as stated on the Mod Portal) and mod-list.json:

Code: Select all

{
  "mods": 
  [
    
    {
      "name": "base",
      "enabled": true
    },
    
    {
      "name": "Krastorio2",
      "enabled": true
    }
  ]
}

Thanks again for the amazing work you are doing, I know this is probably a (very) low priority improvement to make.

[Rseding91]

Thanks for the report however that's working correctly and as intended. A mod not being enabled because it is incompatible with another mod is not an error state; it's the correct behavior for the mod dependency system.