Page 1 of 1
[0.17.60] The collision rectangle of the boiler should be a little larger
Posted: Sat Aug 03, 2019 1:00 am
by qegr
- 1.png (565.95 KiB) Viewed 2264 times
"Boilers have 2 water connectors, allowing them to pass water through to other adjacent equipment" ---from wiki
player can go through the boiler ,this is unreasonable
Re: [0.17.60] The collision rectangle of the boiler should be a little larger
Posted: Sat Aug 03, 2019 5:56 am
by Rseding91
Thanks for the report however we aren't going to be changing the bounding box sizes of the boilers as it breaks other things.
Re: [0.17.60] The collision rectangle of the boiler should be a little larger
Posted: Sat Aug 03, 2019 6:58 am
by Oktokolo
Rseding91 wrote: ↑Sat Aug 03, 2019 5:56 am
Thanks for the report however we aren't going to be changing the bounding box sizes of the boilers as it breaks other things.
I really don't want the boiler bounding box to get larger. But i am curious about how the bounding box of a boiler could break things as long as it would not exceed the actual tile footprint of the entity.
Re: [0.17.60] The collision rectangle of the boiler should be a little larger
Posted: Sat Aug 03, 2019 11:38 am
by BlueTemplar
Then maybe make the collision box of turbine smaller, for consistency ?
Re: [0.17.60] The collision rectangle of the boiler should be a little larger
Posted: Sat Aug 03, 2019 5:51 pm
by Rseding91
BlueTemplar wrote: ↑Sat Aug 03, 2019 11:38 am
Then maybe make the collision box of turbine smaller, for consistency ?
Consistency is not a concern. Gameplay and not breaking stuff is the concern.
Re: [0.17.60] The collision rectangle of the boiler should be a little larger
Posted: Sat Aug 03, 2019 6:02 pm
by darkfrei
Rseding91 wrote: ↑Sat Aug 03, 2019 5:51 pm
BlueTemplar wrote: ↑Sat Aug 03, 2019 11:38 am
Then maybe make the collision box of turbine smaller, for consistency ?
Consistency is not a concern. Gameplay and not breaking stuff is the concern.
1. The Game is not done;
2. The Game is in experimental stage.
Now devs can change recipes, also add, remove or rename items, entities and technologies, but cannot change collision box
a little bit?
It's literally the same what was with curved rails done.
Re: [0.17.60] The collision rectangle of the boiler should be a little larger
Posted: Mon Aug 05, 2019 4:42 pm
by Rseding91
darkfrei wrote: ↑Sat Aug 03, 2019 6:02 pm
Rseding91 wrote: ↑Sat Aug 03, 2019 5:51 pm
BlueTemplar wrote: ↑Sat Aug 03, 2019 11:38 am
Then maybe make the collision box of turbine smaller, for consistency ?
Consistency is not a concern. Gameplay and not breaking stuff is the concern.
1. The Game is not done;
2. The Game is in experimental stage.
Now devs can change recipes, also add, remove or rename items, entities and technologies, but cannot change collision box
a little bit?
It's literally the same what was with curved rails done.
Look at the giant mess that changing rail collision boxes caused. That is exactly why I said no to this.
Re: [0.17.60] The collision rectangle of the boiler should be a little larger
Posted: Tue Aug 06, 2019 3:22 am
by Oktokolo
Rseding91 wrote: ↑Mon Aug 05, 2019 4:42 pm
Look at the giant mess that changing rail collision boxes caused. That is exactly why I said no to this.
What is going on with the collision boxes and why does it look like the devs fear touching any of them so much?
Is there really a giant lingering bug in the engine that might randomly and nondeterministically explode over any collision box change? And is the selected strategy really to never ever touch any collision box again instead of hunting down that bug?
Does that imply, that modding in new entities with collision boxes might lead to random crashes or desyncs?
Re: [0.17.60] The collision rectangle of the boiler should be a little larger
Posted: Tue Aug 06, 2019 6:23 am
by Rseding91
Changing collision boxes of pipes, the player, walls, and rails leads to things being not buildable where they should be or making things buildable where they shouldn't. We have many bug reports in the past every time we've changed any of them because of how many different cases depend on the exact size of them as they are now.
Re: [0.17.60] The collision rectangle of the boiler should be a little larger
Posted: Tue Aug 06, 2019 6:25 am
by darkfrei
It looks like all vanilla prototypes (with fluid boxes) must have hardcoded collision boxes that no mod can make a crash.
What if the boiler will be for example 3x3 and have collision box radius exactly 1.5?
Re: [0.17.60] The collision rectangle of the boiler should be a little larger
Posted: Tue Aug 06, 2019 6:29 am
by Rseding91
Last time we changed wall collision boxes:
28226 ->
28477
Re: [0.17.60] The collision rectangle of the boiler should be a little larger
Posted: Tue Aug 06, 2019 7:39 am
by Oktokolo
Rseding91 wrote: ↑Tue Aug 06, 2019 6:23 am
Changing collision boxes of pipes, the player, walls, and rails leads to things being not buildable where they should be or making things buildable where they shouldn't. We have many bug reports in the past every time we've changed any of them because of how many different cases depend on the exact size of them as they are now.
Good to know, that it is merely about building restrictions and a rare instance of player trapping.
I am surprised, that entity building is not grid based. So a mod with non-grid-aligned buildings is actually possible?
And would modding the pipes entirely walkable like the belts also allow building other stuff on top of them?
Rseding91 wrote: ↑Tue Aug 06, 2019 6:29 am
Last time we changed wall collision boxes:
28226 ->
28477
Wow. Are there rules, how colision boxes may not look like because they could trap players?