Page 1 of 1

[0.17.23] Undo doesn't work for changes done by upgrade planner

Posted: Mon Apr 01, 2019 8:09 am
by jarcionek
TL;DR
I have described that scenario below first, but then noticed that in simple cases it also doesn't work. Simply, using the upgrade planner cannot be undone using the "undo" shortcut.
Scenario
Setup:
1. Place an electric mining drill and fill it with 3 modules
2. Copy it (don't build it)
3. Use the upgrade planner to change the modules on both

Screenshot.png
Screenshot.png (2.34 MiB) Viewed 993 times
Now try to undo it.

Expected:
1. After first undo, there should be a ghost and built drill, both with green modules
2. After second undo, ghost should disappear
3. After third undo, built drill should be marked for deconstruction

Actual:
1. After first undo, the ghost disappears, the built miner is still expecting modules replacement
2. After second undo, the built drill is marked for deconstruction

Re: [0.17.23] Undo doesn't work for changes done by upgrade planner

Posted: Mon Apr 01, 2019 9:26 am
by Rseding91
Thanks for the report. This is outside of the scope of what undo was designed to handle and we currently have no plans to change that.

Re: [0.17.23] Undo doesn't work for changes done by upgrade planner

Posted: Mon Apr 01, 2019 6:08 pm
by jarcionek
Don't you think that it would better fit in "minor issues" rather than "not a bug"? Or should I raise as an "idea"?

Re: [0.17.23] Undo doesn't work for changes done by upgrade planner

Posted: Mon Jul 15, 2019 9:04 am
by thuejk
I would definitely expect undo to work like this. So to me it would be more appropriate to at least call it a "minor bug".

Re: [0.17.23] Undo doesn't work for changes done by upgrade planner

Posted: Mon Jul 15, 2019 9:38 am
by Rseding91
thuejk wrote:
Mon Jul 15, 2019 9:04 am
I would definitely expect undo to work like this. So to me it would be more appropriate to at least call it a "minor bug".
Sorry, but user expectations don't dictate what is or isn't a bug on our side.