Page 1 of 1

[0.15.1] locomotive missing renaming

Posted: Mon Apr 24, 2017 9:42 pm
by keyboardhack
Not sure if this is the place to post it.
In 0.15 the name of the diesel locomotive was changed to locomotive. Seems like that change only happened in the type and name in the prototype and not in the graphics folders and files associated with the locomotive.

An example:
Currently the icons path is "__base__/graphics/icons/diesel-locomotive.png" and to stay consistent with the naming it should be "__base__/graphics/icons/locomotive.png".
Seems like the icon and all the textures associated with the locomotive has this problem.

Re: [0.15.1] locomotive missing renaming

Posted: Mon Apr 24, 2017 9:44 pm
by Klonan
Thanks for the report,

However this doesn't really matter, and i wouldn't consider it a bug

Re: [0.15.1] locomotive missing renaming

Posted: Mon Apr 24, 2017 9:46 pm
by Zeblote
Klonan wrote:However this doesn't really matter, and i wouldn't consider it a bug
It does matter, when other items were renamed in the past their files were renamed aswell.

Re: [0.15.1] locomotive missing renaming

Posted: Mon Apr 24, 2017 9:50 pm
by matjojo
Zeblote wrote:
Klonan wrote:However this doesn't really matter, and i wouldn't consider it a bug
It does matter, when other items were renamed in the past their files were renamed aswell.

shudders

Underground belt - pipe to ground

shudders

Re: [0.15.1] locomotive missing renaming

Posted: Mon Apr 24, 2017 9:55 pm
by Klonan
Zeblote wrote:
Klonan wrote:However this doesn't really matter, and i wouldn't consider it a bug
It does matter, when other items were renamed in the past their files were renamed aswell.
It makes no difference in the game, the filenames are only used in the entity definitions

Re: [0.15.1] locomotive missing renaming

Posted: Mon Apr 24, 2017 9:58 pm
by Zeblote
Klonan wrote:
Zeblote wrote:
Klonan wrote:However this doesn't really matter, and i wouldn't consider it a bug
It does matter, when other items were renamed in the past their files were renamed aswell.
It makes no difference in the game, the filenames are only used in the entity definitions
Well by that logic you might aswell replace all file names with random letters.

Consistency matters, especially with mods being made.

Re: [0.15.1] locomotive missing renaming

Posted: Tue Apr 25, 2017 4:09 am
by keyboardhack
Klonan wrote:
Zeblote wrote:
Klonan wrote:However this doesn't really matter, and i wouldn't consider it a bug
It does matter, when other items were renamed in the past their files were renamed aswell.
It makes no difference in the game, the filenames are only used in the entity definitions
One of the changes stated in the 0.15 release is this:
  • Unified internal name of the 'flame-thrower' to 'flamethrower'.
Consistentcy is very important. Although it isn't technically an bug by the definition it's clearly an unintended oversight which should be reported and eventually fixed.

Re: [0.15.1] locomotive missing renaming

Posted: Mon May 01, 2017 12:45 pm
by mophydeen
please fix.

my workflow for looking for a name is just a search in the global steam folder.
I found diesel-locomotive and thought my script was doing something wrong.
had to go to the item definitions etc. to figure out it was renamed.


You can program with wrong spellings (I dont care)
but be Consistent in the naming of things