[1.1.76] Checking for mod updates makes multiple redundant portal requests

Bugs that are actually features.
Post Reply
User avatar
raiguard
Factorio Staff
Factorio Staff
Posts: 450
Joined: Wed Dec 13, 2017 8:29 pm
Contact:

[1.1.76] Checking for mod updates makes multiple redundant portal requests

Post by raiguard »

When the game checks for mod updates, it downloads the full mod list multiple times. The number of times it downloads it is proportional to the number of mods - with 5000 mods, it made 100 requests. You can see the URL that it is fetching in the log file:

Code: Select all

  85.659 Info HttpSharedState.cpp:54: Downloading https://mods.factorio.com/api/mods?page_size=max&full=True&version=1.1.76&lang=en
  87.316 Info HttpSharedState.cpp:54: Downloading https://mods.factorio.com/api/mods?page_size=max&full=True&version=1.1.76&lang=en
As you can see, it is not paginating, but is downloading the entire thing every time. That is a ton of redundant data!
Don't forget, you're here forever.

User avatar
vinzenz
Factorio Staff
Factorio Staff
Posts: 173
Joined: Mon Aug 02, 2021 6:45 pm
Contact:

Re: [1.1.76] Checking for mod updates makes multiple redundant portal requests

Post by vinzenz »

It's not logging the namelist parameter because it's in the http body. It makes 100 requests for 50 mods each.
bringing the oops to devops

Post Reply

Return to “Not a bug”