Deadlocks Stacking for Pyanodons mods

pyanodon's mods are here

Moderator: pyanodon

chrisdec
Fast Inserter
Fast Inserter
Posts: 232
Joined: Fri May 27, 2016 7:50 pm
Contact:

Re: Deadlocks Stacking for Pyanodons mods

Post by chrisdec »

version 0.3.3 up now

with
aluminium and nickel plate

chrisdec
Fast Inserter
Fast Inserter
Posts: 232
Joined: Fri May 27, 2016 7:50 pm
Contact:

Re: Deadlocks Stacking for Pyanodons mods

Post by chrisdec »

new version aviable:

changelog: 0.3.4

added to stacking
for
py coal processing:
nexelit plate, chromium

for
py raw ores:
tin plate,lead plate, titanium plate,
zinc plate, duralumin, silver plate, super steel,
stainless steel, tinned cable and solder

i will cross my fingers and hope it is stable now

User avatar
SuperSandro2000
Filter Inserter
Filter Inserter
Posts: 741
Joined: Sun Jan 12, 2014 3:54 am
Contact:

Re: Deadlocks Stacking for Pyanodons mods

Post by SuperSandro2000 »

chrisdec wrote:
Sat Dec 29, 2018 3:13 pm
new version aviable:

changelog: 0.3.4

added to stacking
for
py coal processing:
nexelit plate, chromium

for
py raw ores:
tin plate,lead plate, titanium plate,
zinc plate, duralumin, silver plate, super steel,
stainless steel, tinned cable and solder

i will cross my fingers and hope it is stable now
Could you add a changelog.txt to your mod like I did here https://mods.factorio.com/mod/Sandros-fixes/changelog ?

chrisdec
Fast Inserter
Fast Inserter
Posts: 232
Joined: Fri May 27, 2016 7:50 pm
Contact:

Re: Deadlocks Stacking for Pyanodons mods

Post by chrisdec »

SuperSandro2000 wrote:
Thu Jan 03, 2019 12:55 pm
chrisdec wrote:
Sat Dec 29, 2018 3:13 pm
new version aviable:

changelog: 0.3.4

added to stacking
for
py coal processing:
nexelit plate, chromium

for
py raw ores:
tin plate,lead plate, titanium plate,
zinc plate, duralumin, silver plate, super steel,
stainless steel, tinned cable and solder

i will cross my fingers and hope it is stable now
Could you add a changelog.txt to your mod like I did here https://mods.factorio.com/mod/Sandros-fixes/changelog ?
found it thanks added in from now on

chrisdec
Fast Inserter
Fast Inserter
Posts: 232
Joined: Fri May 27, 2016 7:50 pm
Contact:

Re: Deadlocks Stacking for Pyanodons mods

Post by chrisdec »

new version out:
changelog in mod portal from now on

chrisdec
Fast Inserter
Fast Inserter
Posts: 232
Joined: Fri May 27, 2016 7:50 pm
Contact:

Re: Deadlocks Stacking for Pyanodons mods

Post by chrisdec »

more items added to stacking

chrisdec
Fast Inserter
Fast Inserter
Posts: 232
Joined: Fri May 27, 2016 7:50 pm
Contact:

Re: Deadlocks Stacking for Pyanodons mods

Post by chrisdec »

hello everyone,
i can't convert this mod to 0.17 untill all the desired mods (from pyanodon and deadlock) are changed
untill then i will keep this mod updated with stuff to stack on the 0.16 branch

chrisdec
Fast Inserter
Fast Inserter
Posts: 232
Joined: Fri May 27, 2016 7:50 pm
Contact:

Re: Deadlocks Stacking for Pyanodons mods

Post by chrisdec »

hey everyone,
mod converted to 0.17 have fun

chrisdec
Fast Inserter
Fast Inserter
Posts: 232
Joined: Fri May 27, 2016 7:50 pm
Contact:

Re: Deadlocks Stacking for Pyanodons mods

Post by chrisdec »

hello everyone,
i just want to let you know that for the moment deadlock crating machine is causing issues with my mod (you have to deactivate it)
also im asking to anyone who has experiance with mods iff they can help me on this issue

here is the problem

Image


help is really appriciated

reapersms
Long Handed Inserter
Long Handed Inserter
Posts: 69
Joined: Sun Jun 17, 2018 4:55 am
Contact:

Re: Deadlocks Stacking for Pyanodons mods

Post by reapersms »

the entry for molybdenite-dust in migrations/shared.lua is wrong, it is
{ item = "molybdenite-dust", item = nil, stage = 1 },
and should be
{ item = "molybdenite-dust", icon = nil, stage = 1 },

it's setting the item slot to nil, and then passing that nil in to deadlock_crating.create(), which explodes when it tries logging the item name for debug purposes

chrisdec
Fast Inserter
Fast Inserter
Posts: 232
Joined: Fri May 27, 2016 7:50 pm
Contact:

Re: Deadlocks Stacking for Pyanodons mods

Post by chrisdec »

och i see now
how on earth could i miss that thanks reapersms
normal i triple check my stuff before i upload it

thanks for checking it for me you will be added to my changelog for helping

The_Ghost
Burner Inserter
Burner Inserter
Posts: 18
Joined: Mon May 07, 2018 10:32 am
Contact:

Re: Deadlocks Stacking for Pyanodons mods

Post by The_Ghost »

Hey again,

i know its been a while but im back playing factorio and updated my original mod to factorio version 0.17. Especially i included the items chrisdec added to his fork, reorganised some code to make further modifications easier and adopt it to the new stacking mod by shanemadden (in a way such that stacks of coke and ash still have a fuel value).

I hope you enjoy it and am still interested in feedback which items to include into the mod.

chrisdec
Fast Inserter
Fast Inserter
Posts: 232
Joined: Fri May 27, 2016 7:50 pm
Contact:

Re: Deadlocks Stacking for Pyanodons mods

Post by chrisdec »

The_Ghost wrote:
Tue May 14, 2019 1:53 pm
Hey again,

i know its been a while but im back playing factorio and updated my original mod to factorio version 0.17. Especially i included the items chrisdec added to his fork, reorganised some code to make further modifications easier and adopt it to the new stacking mod by shanemadden (in a way such that stacks of coke and ash still have a fuel value).

I hope you enjoy it and am still interested in feedback which items to include into the mod.
hey the ghost, welcome back
i see you have added all the items ive been using in my mod
so what should i do now?
my mod has been very succesfull so far and i want to continue updating the mod
also a very humble request can you pretty please add me as mod collaborator?

The_Ghost
Burner Inserter
Burner Inserter
Posts: 18
Joined: Mon May 07, 2018 10:32 am
Contact:

Re: Deadlocks Stacking for Pyanodons mods

Post by The_Ghost »

You have a PM to discuss the future development.

chrisdec
Fast Inserter
Fast Inserter
Posts: 232
Joined: Fri May 27, 2016 7:50 pm
Contact:

Re: Deadlocks Stacking for Pyanodons mods

Post by chrisdec »

to everyone,
i would like to say that im depreciating my deadlock4pyanodon mod
its been fun keeping this mod alive when he was gone
but this means im not gone, from now on im working with The_Ghost on his mod and i will frequently add stuff to the stacking for pyanodon mod

YunoAloe
Long Handed Inserter
Long Handed Inserter
Posts: 96
Joined: Tue Mar 12, 2019 9:22 pm
Contact:

Re: Deadlocks Stacking for Pyanodons mods

Post by YunoAloe »

Could somebody confirm or disconfirm please that https://mods.factorio.com/mod/Deadlocks ... 000bc6fe0f can be fixed on this mod's side? I'm playing an ABPy+ game and I cannot migrate. Deadlock has introduced new functions to combat this in the latest update.

chrisdec
Fast Inserter
Fast Inserter
Posts: 232
Joined: Fri May 27, 2016 7:50 pm
Contact:

Re: Deadlocks Stacking for Pyanodons mods

Post by chrisdec »

YunoAloe wrote:
Tue Jun 18, 2019 4:16 pm
Could somebody confirm or disconfirm please that https://mods.factorio.com/mod/Deadlocks ... 000bc6fe0f can be fixed on this mod's side? I'm playing an ABPy+ game and I cannot migrate. Deadlock has introduced new functions to combat this in the latest update.
hello,
did you remove deadlockstacking4pyanodon mod? this mod is depreciated
you have to use deadlockstackingforpyanodon mod now
also i dont have any issues on my end and im using the recent updates
as i see your message on the mod portal this mod is not listed in the error page
and we are very sorry for the late message

YunoAloe
Long Handed Inserter
Long Handed Inserter
Posts: 96
Joined: Tue Mar 12, 2019 9:22 pm
Contact:

Re: Deadlocks Stacking for Pyanodons mods

Post by YunoAloe »

chrisdec wrote:
Tue Jun 18, 2019 6:27 pm
YunoAloe wrote:
Tue Jun 18, 2019 4:16 pm
Could somebody confirm or disconfirm please that https://mods.factorio.com/mod/Deadlocks ... 000bc6fe0f can be fixed on this mod's side? I'm playing an ABPy+ game and I cannot migrate. Deadlock has introduced new functions to combat this in the latest update.
hello,
did you remove deadlockstacking4pyanodon mod? this mod is depreciated
you have to use deadlockstackingforpyanodon mod now
also i dont have any issues on my end and im using the recent updates
as i see your message on the mod portal this mod is not listed in the error page
and we are very sorry for the late message
Yes, I replaced 1 mod by the other. Do you use Bob's & Angel's along with https://mods.factorio.com/mod/PyCoalTBaA ?

User avatar
Deadlock989
Smart Inserter
Smart Inserter
Posts: 2528
Joined: Fri Nov 06, 2015 7:41 pm

Re: Deadlocks Stacking for Pyanodons mods

Post by Deadlock989 »

YunoAloe wrote:
Tue Jun 18, 2019 6:33 pm
Yes, I replaced 1 mod by the other. Do you use Bob's & Angel's along with https://mods.factorio.com/mod/PyCoalTBaA ?
Similar issues with a similar message were reported recently where Py and another mod were in conflict. If two overhaul mods give an item the same name - in this case solid-coke - and a third mod tries to stack that item, the icon size has to be the same in both overhaul mods or there's a chance you'll get this kind of error, depending on mod load order. The order of gradual carnage goes something like this:

- Mod A creates an item with an icon size of 64
- Mod B overwrites that item with an icon size of 32
- The third party stacking mod sends a call to DSB to stack what it thinks is Mod A's item, size 64, but it's Mod B's item now, size 32
- Boom.

Or the other way around.

Possible solutions are:

- The overhaul mods could all update their icons to 64, which is going to be the Factorio default by the time it leaves early access.
- The third party stacking mod could check to see if the items still have the expected icon size before trying to stack them.
- Third party stacking mods could use their own customised icons like they've been advised and stop eating up everyone's FPS.
Image

YunoAloe
Long Handed Inserter
Long Handed Inserter
Posts: 96
Joined: Tue Mar 12, 2019 9:22 pm
Contact:

Re: Deadlocks Stacking for Pyanodons mods

Post by YunoAloe »

Deadlock989 wrote:
Tue Jun 18, 2019 7:18 pm
- Third party stacking mods could use their own customised icons like they've been advised and stop eating up everyone's FPS.
Btw since Py released new graphics for ores just last week, their stacked icons are messed now.

Post Reply

Return to “PyMods”