[0.15.35] Achievement localisation is partially broken.

This subforum contains all the issues which we already resolved.
Post Reply
User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 5206
Joined: Tue Jul 12, 2016 9:03 am
Contact:

[0.15.35] Achievement localisation is partially broken.

Post by eradicator »

Several parts of achivement name and description localisation are broken:
  • .localised_name attribute on prototypes does not work at all
  • .localised_description attribute works only on some achivement types
  • [achievement-description] in locale.cfg does not work for custom achivements (not sure of exact condition)(rsed said somewhere he already fixed this)
The demo mod demonstrates all three. Just open a new game and look at the achivement menu.
data.lua
locale.cfg
Attachments
er-ocd-fix_1.0.0.zip
(3.12 KiB) Downloaded 38 times
Author of: Belt Planner, Hand Crank Generator, Screenshot Maker, /sudo and more.
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.

posila
Factorio Staff
Factorio Staff
Posts: 5201
Joined: Thu Jun 11, 2015 1:35 pm
Contact:

Re: [0.15.35] Achievement localisation is partially broken.

Post by posila »

Thanks for the report. I tried the mod in 0.16 and all of it seems to be fixed.

User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 5206
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: [0.15.35] Achievement localisation is partially broken.

Post by eradicator »

Hm. I just noticed that rsed actually said he fixed the prototype part (issue 1+2) and not the local.cfg part (issue 3). And i also noticed that the mod doesn't actually demonstrate issue 3 because it's overshadowed by 2.

This should be able to demonstrate 3 if i didn't make any typos. If "Relax & Enjoy" still has a description it's also fixed.
Attachments
er-ocd-fix_1.0.1.zip
(3.13 KiB) Downloaded 35 times
Author of: Belt Planner, Hand Crank Generator, Screenshot Maker, /sudo and more.
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.

posila
Factorio Staff
Factorio Staff
Posts: 5201
Joined: Thu Jun 11, 2015 1:35 pm
Contact:

Re: [0.15.35] Achievement localisation is partially broken.

Post by posila »

Yeah, that works too.

User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 5206
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: [0.15.35] Achievement localisation is partially broken.

Post by eradicator »

Thanks.
I shall then sit down and relax. While waiting for 0.16 :ugeek:
Author of: Belt Planner, Hand Crank Generator, Screenshot Maker, /sudo and more.
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.

Post Reply

Return to “Resolved Problems and Bugs”