Factorio Forums

• Converts a 2 x 2 tile area to land
• Can't be placed next to existing buildings
• 2 tiles is wide enough for a single railway track

Example

And place a few more:

• Player should no longer get stuck
• Mod correctly initialises on loading saved game
• Now only replaces water tiles and refunds landfill item if no tiles are replaced

rubixx wrote:The landfill function no longer works after reloading a saved game.

game.onload(function()
  Initialise()
end)

GotLag wrote:So am I right to assume that oninit() fires when you load a game with the mod for the first time, and subsequently fires onload()?

require "defines"

game.onevent(defines.events.onbuiltentity, function(event)
  if event.createdentity.name == "landfill" then
    landfill(event.createdentity.position)
    game.createentity
    {
      name = "landfill-fade",
      position = event.createdentity.position,
      force = game.forces.player
    }
    event.createdentity.destroy()
  end
end)

function landfill(position)
  xpos = position.x - 1
  ypos = position.y - 1
  for i = 0,1,1 do --y
    for j = 0,1,1 do --x
      game.settiles{{name="grass", position={xpos + j, ypos + i}}}
      --game.player.print(xpos + j .. ", " .. ypos + i)
    end
  end
end

require "defines"

game.onevent(defines.events.onbuiltentity, function(event)
  if event.createdentity.name == "landfill" then
    game.settiles{{name="grass", position={event.createdentity.position.x - 1, event.createdentity.position.y - 1}}}
    game.settiles{{name="grass", position={event.createdentity.position.x - 1, event.createdentity.position.y}}}
    game.settiles{{name="grass", position={event.createdentity.position.x, event.createdentity.position.y - 1}}}
    game.settiles{{name="grass", position={event.createdentity.position.x, event.createdentity.position.y}}}
    game.createentity
    {
      name = "landfill-fade",
      position = event.createdentity.position,
      force = game.forces.player
    }
    event.createdentity.destroy()
  end
end)

GotLag wrote:Thanks, I wish I'd kept a copy of my earlier code so I could look back and see why just setting the event handler straight off didn't work when I tried it.

GotLag wrote:The reason it uses grass is that as far as I can tell no other tile is allowed to directly border water.

results_complaining...

hm...water-green seems to only be placeable near other water-green (so placing it in regular water/deepwater creates a ring of grass around it)...jeez this feels clunky when changing one tile at a time...you know, I just looked at why settiles takes a table of tables and it looks like it's meant to be used by passing all of the tiles to be changed in at one time...that may help remove some of the derpyness of using it (when changing more than one tile)
like so (note I've made all variables local because nothing uses them outside of this function):

Code: Select all

function landfill(position)
  local xpos = position.x - 1
  local ypos = position.y - 1
  local tiles = {};
  for i = 0,1,1 do --y
    for j = 0,1,1 do --x
      table.insert(tiles, {name="grass", position={xpos + j, ypos + i}})
      --game.player.print(xpos + j .. ", " .. ypos + i)
    end
  end
  game.settiles(tiles)
end

It's a shame you can't just pass this a bounding box and the tile that you want...I suppose that would prevent you from making different positions be different tiles though...would be a nice alternative though for changing large patches of ground (think large scale terraforming) rather than using a large for loop to set up the tables...

getpos = function() {return game.player.screen2realposition(game.player.cursorposition)}
-- note/question why the [insert exclamation/expletive of choice here] does gettile not take a position table!
gettiles=function() game.player.print(serpent.block(game.gettile(getpos().x, getpos().y).name)) end
settiles = function(name) game.settiles{{name=name, position=getpos()}} end

FreeER wrote:That is where the magic of version control comes in handy! (check out git if you haven't already)

FreeER wrote:from testing: out-of-map (useless for this...) and sand can as well...though from looking at the prototype (and testing results) the sand being allowed might, probably, be a bug...the rest get surrounded by grass automatically (so changing one tile in a large body of water actually changes a 3x3 with the center being what you specified) of course I also see that giving settiles an invalid tile name crashes Factorio to the desktop

GotLag wrote:I actually tried sand again after reading this, and it was automatically surrounded with grass.

GotLag wrote:This of course requires that you committed the code in question

GotLag wrote:I doubt I'd have bothered for some console-printing test code that apparently didn't work.

GotLag wrote:Thanks for your help!

FreeER wrote:really? Did you check with gettile or just see that it looked like grass? I found that placing one does look like grass (and the edges I think looked like grass as well...but I think that's masking) but placing multiple sand tiles does make it appear as sand and gettile shows only sand (no grass around it).

FreeER wrote:edit: btw, if you want the mod to be loadable without unzipping it the zip's file name must be exactly the same as the name provided in the info.json (no -1.1 in the zip name for example).

GotLag wrote:I turn off transitions for testing, and can confirm those tiles are what they look like. This was attempting to only place sand.

I_dislike_really_long_posts_in_mod_threads_cause_they_make_quick_reading_a_pain

FreeER wrote:]you can turn off transitions?? I didn't realize that...how?

GotLag wrote:F4, near the bottom of the list. Maximise your window, there's no scrollbar.

GotLag wrote:It's the one immediately below that. Oh well. I can't remember if F5 shows transitions by default or not, but F6 or F7 should.