[MOD 0.13] Black Market (sell and buy on the market)

Topics and discussion about specific mods
smeagol001
Burner Inserter
Burner Inserter
Posts: 16
Joined: Thu Oct 06, 2016 10:44 am
Contact:

Re: [MOD 0.13] Black Market (sell and buy on the market)

Post by smeagol001 »

hipc1211 wrote:crash with control.lua:2448 string.sub funtiong, not have name prop.
that has top do with the fixes that were done in version 16.40

MTFT-Games
Manual Inserter
Manual Inserter
Posts: 4
Joined: Sat Dec 16, 2017 6:13 pm
Contact:

When will the error on armor grid be fixed?

Post by MTFT-Games »

The title.

User avatar
CakeDog
Inserter
Inserter
Posts: 22
Joined: Sun Jun 25, 2017 12:48 am
Contact:

Re: [MOD 0.13] Black Market (sell and buy on the market)

Post by CakeDog »

Pretty much untested here, but this should get you going for now - find this block

Code: Select all

		-- manage opened traders
		for _, player in pairs(game.players) do
			if player.connected then
				local player_mem = global.player_mem[player.index]
				local opened = player.opened
				
				if opened then
Change the last line from

Code: Select all

if opened then
to

Code: Select all

if opened and player.opened_gui_type ~= 5 then

nets
Burner Inserter
Burner Inserter
Posts: 9
Joined: Sat Apr 01, 2017 4:36 pm
Contact:

Re: [MOD 0.13] Black Market (sell and buy on the market)

Post by nets »

Changing:

{code]if opened then[/code]

Into:

Code: Select all

if opened and player.opened_gui_type ~= 5 then
Fixed the issue for me. Thank you for the support.

User avatar
binbinhfr
Smart Inserter
Smart Inserter
Posts: 1524
Joined: Sat Feb 27, 2016 7:37 pm
Contact:

Re: [MOD 0.13] Black Market (sell and buy on the market)

Post by binbinhfr »

hi guys,

if one of you wants to post a working version here, i'll be glad to update it on the portal, so that it profits to other persons.
My mods on the Factorio Mod Portal :geek:

jokru
Burner Inserter
Burner Inserter
Posts: 13
Joined: Sun May 13, 2018 10:34 pm
Contact:

Re: [MOD 0.13] Black Market (sell and buy on the market)

Post by jokru »

binbinhfr wrote:hi guys,

if one of you wants to post a working version here, i'll be glad to update it on the portal, so that it profits to other persons.
Here's a download link to a (seemingly) working file. Can't test it right now, all credit for the fix goes to CakeDog; this is just his fix in a (seemingly) working .zip file. Please test and upload to the portal to ease the lives of others!

Edit:
Oh, I also didn't touch any of the version numbers so you should update them when/if uploading the file to the portal.

User avatar
binbinhfr
Smart Inserter
Smart Inserter
Posts: 1524
Joined: Sat Feb 27, 2016 7:37 pm
Contact:

Re: [MOD 0.13] Black Market (sell and buy on the market)

Post by binbinhfr »

hi, thanks for the zip.
If you don't bother, I will wait that someone test the file and validate it before uploading it to the portal, where hundreth of person could download it... ;-)
I cannot test it myself, because I do not play anymore.
My mods on the Factorio Mod Portal :geek:

jokru
Burner Inserter
Burner Inserter
Posts: 13
Joined: Sun May 13, 2018 10:34 pm
Contact:

Re: [MOD 0.13] Black Market (sell and buy on the market)

Post by jokru »

I have now tested it for about 10+ hours (with mod installed and enabled) and it works just fine. Buying and selling things works fine, manually and automatically.

User avatar
binbinhfr
Smart Inserter
Smart Inserter
Posts: 1524
Joined: Sat Feb 27, 2016 7:37 pm
Contact:

Re: [MOD 0.13] Black Market (sell and buy on the market)

Post by binbinhfr »

I uploaded a 1.0.37 on the portal.
Thx to CakeDog.
My mods on the Factorio Mod Portal :geek:

ReasonX
Burner Inserter
Burner Inserter
Posts: 18
Joined: Thu Dec 21, 2017 7:52 pm
Contact:

Re: [MOD 0.13] Black Market (sell and buy on the market)

Post by ReasonX »

Hello. Does this mod is right balanced?

User avatar
binbinhfr
Smart Inserter
Smart Inserter
Posts: 1524
Joined: Sat Feb 27, 2016 7:37 pm
Contact:

Re: [MOD 0.13] Black Market (sell and buy on the market)

Post by binbinhfr »

ReasonX wrote:Hello. Does this mod is right balanced?
strange question.... As the creator of it, I would say yes ;-)
But just try it once, and you will see...

PS : The prices are automaticcaly calcultated and depends on the recipes of your installed mods...
My mods on the Factorio Mod Portal :geek:

ReasonX
Burner Inserter
Burner Inserter
Posts: 18
Joined: Thu Dec 21, 2017 7:52 pm
Contact:

Re: [MOD 0.13] Black Market (sell and buy on the market)

Post by ReasonX »

binbinhfr wrote: I would say yes ;-)
PS : The prices are automaticcaly calcultated and depends on the recipes of your installed mods...
Eh... with angelbob its not.
Sillicon nugget - 8ku, copper nugget - 30u.

User avatar
binbinhfr
Smart Inserter
Smart Inserter
Posts: 1524
Joined: Sat Feb 27, 2016 7:37 pm
Contact:

Re: [MOD 0.13] Black Market (sell and buy on the market)

Post by binbinhfr »

ReasonX wrote:
binbinhfr wrote: I would say yes ;-)
PS : The prices are automaticcaly calcultated and depends on the recipes of your installed mods...
Eh... with angelbob its not.
Sillicon nugget - 8ku, copper nugget - 30u.
with such complex mods, the problem is that you have often multiple recipes to obtain the same item. My mod does not explore all the ways.
It has also problems to determine the prices of "raw" items, i.e. items that are at the beginning of the crafting chain.
But you can customize some prices, using the config.lua file.
My mods on the Factorio Mod Portal :geek:

gunmaker
Burner Inserter
Burner Inserter
Posts: 19
Joined: Sun Aug 27, 2017 10:28 pm
Contact:

Re: [MOD 0.13] Black Market (sell and buy on the market)

Post by gunmaker »

download/file.php?mode=view&id=37733

BlackMarket_1.0.37 widescreen patch.zip

works just fine for me in stable 16 :)


can u update controls.lua search and replace left with top. tada :)
Attachments
BlackMarket_1.0.37 widescreen patch.zip
(1.3 MiB) Downloaded 246 times

User avatar
binbinhfr
Smart Inserter
Smart Inserter
Posts: 1524
Joined: Sat Feb 27, 2016 7:37 pm
Contact:

Re: [MOD 0.13] Black Market (sell and buy on the market)

Post by binbinhfr »

gunmaker wrote:download/file.php?mode=view&id=37733

BlackMarket_1.0.37 widescreen patch.zip

works just fine for me in stable 16 :)
can u update controls.lua search and replace left with top. tada :)
Hi,

I tested your patch on a "classic" HD screen 1920x1080 and it is not satisfactory.
The blackmarket selection menu appears in the top middle on the screen, under the inventory...

The problem is that you switch the BM interface from gui.left to gui.top

For people that have numerous mods using the top bar for "main button", it mess up this top bar.
The top bar is not used for temporary windows opening.

I'm afraid I cannot publish this patch which is not working under all circumstances... :-(

Could you make a screencopy of the problem that your are trying to solve ? (using the official BM mod)
My mods on the Factorio Mod Portal :geek:

dodfunk
Manual Inserter
Manual Inserter
Posts: 1
Joined: Sun Jul 22, 2018 12:50 am
Contact:

Re: [MOD 0.13] Black Market (sell and buy on the market)

Post by dodfunk »

I love this mod, and I also love Bob's/Angels. I know it would be a great pain, but could you possibly look into doing a black market for bob's/Angels?

aragnir
Manual Inserter
Manual Inserter
Posts: 2
Joined: Fri Aug 17, 2018 8:18 am
Contact:

Re: [MOD 0.13] Black Market (sell and buy on the market)

Post by aragnir »

hi, i have "Error MainLoop.cpp:1035: Exception at tick 597008: Error while running event BlackMarket::on_tick (ID 0)
__BlackMarket__/control.lua:2522: attempt to perform arithmetic on field 'period' (a nil value)" when just put a sell chest on floor.

When i play with seablock pack + darkstar + blackmarket there was no errors.
Now i play default with alien loot + darkstar + BM. I change only config, add seafloor pumping price and increase default time to 24 hours.

Gaist
Burner Inserter
Burner Inserter
Posts: 15
Joined: Mon Aug 13, 2018 8:38 pm
Contact:

Re: [MOD 0.13] Black Market (sell and buy on the market)

Post by Gaist »

Would be thrilled if anyone has made any headway on making adjustments for Black Market's pricing to play nicely with AngelBob; out of the box, the prices are just wildly disparate unfortunately, allowing very easy trivializing of some of the most complex recipes.

foodfactorio
Filter Inserter
Filter Inserter
Posts: 454
Joined: Tue Jun 20, 2017 1:56 am
Contact:

Re: [MOD 0.13] Black Market (sell and buy on the market)

Post by foodfactorio »

hi, i used to play with this market mod on older saves, and it was cool.
but i added it to another newer game, but i think the new version of the game (or the mod) does not let me see all the items anymore.

im sure the item selection screen used to appear in the middle of the screen before, and we could move the main inventory around (saying "Character" and "Trading Chest Buy", but now the item list just sticks in the bottom left of the screen, and i cant move it up to see all the items inside.

here is a screenshot to show the issue:
how can we make the item selector screen movable again (so we can drag it around?), i tried but its not working.
buy_chest-not_movable-cant_see_items_anymore.png
buy_chest-not_movable-cant_see_items_anymore.png (1.61 MiB) Viewed 7192 times
can the top left window called "Trader (Buy)", be changed to appear somewhere else, or moveable? maybe that can let the main "items/fluids" window be seen fully?
(also me from the mod portal - im not dustine lol) = https://mods.factorio.com/mods/Dustine/ ... ssion/9108
my 1st Mod Idea :) viewtopic.php?f=33&t=50256

foodfactorio
Filter Inserter
Filter Inserter
Posts: 454
Joined: Tue Jun 20, 2017 1:56 am
Contact:

Re: [MOD 0.13] Black Market (sell and buy on the market)

Post by foodfactorio »

actually, can the Tradebuy window (in the top left), have a small button that can minimise it to make it really small, and maybe that will fix it?
this way, we can minimise it, and the when we finish selecting the item from the big list of items, we can expand the top left window again and use it to set the quantity settings.
(also me from the mod portal - im not dustine lol) = https://mods.factorio.com/mods/Dustine/ ... ssion/9108
my 1st Mod Idea :) viewtopic.php?f=33&t=50256

Post Reply

Return to “Mods”