Factorio Forums

• This mod adds chemical spills and pollution from destroyed entities.

• Name: Wreckage Pollution
• Category: SimpleExtension
• MOD Version: 0.15.0
• Factorio Version: 0.15
• Latest Released: 2 May 2017
• Dependencies: None
• Website: https://github.com/sparr/factorio-mod-w ... -pollution
• Author: Sparr
• Contact: sparr0@gmail.com
• Tags: pollution, realism
• License: MIT License
  

bNarFProfCrazy wrote: I will try this mod once it has per liquid colors. At least for the main liquids.

bNarFProfCrazy wrote:Another suggestion: liquified-air/gas has or fuel has the tendency to explode if incinerated (Flamethrower).

One minor note:
Please reference this link in your download url:
https://github.com/sparr/factorio-mod-w ... ses/latest
or this one:
https://github.com/sparr/factorio-mod-w ... n/releases

That way we can see which changes have happened and you don't have to update the link every time you release an update.

sparr wrote:

bNarFProfCrazy wrote:Another suggestion: liquified-air/gas has or fuel has the tendency to explode if incinerated (Flamethrower).

Adding explosions will probably happen after I figure out how to get/deduce more info about the fluids.

bNarFProfCrazy wrote:However your download file is broken since it does not contain the required wrapping folder.

bNarFProfCrazy wrote:Maybe it would be nice if you can add different variations for each splash. (Just rotate/flip them in the raw graphics, similar to the trees/concrete)

bNarFProfCrazy wrote:Another wish of mine: Please make small slashes last longer. Because I barely destroyed my pipes with my flamethrower and the splash was already gone by the time the smoke was gone. (Being visible only one second is not enough, maybe add a minimum time a spill is visible.)

sparr wrote:

bNarFProfCrazy wrote:However your download file is broken since it does not contain the required wrapping folder.

Thanks, fixed this. I need to make a script for packaging mods to avoid mistakes like this.

bNarFProfCrazy wrote:Game crashes with wreckage-pollution_0.0.2 when I die/kill a rock with missiles.

Factorio-wrack.png

EDIT: Any entity that dies causes this, if it has no corpses defined in its prototypes.

thereaverofdarkness wrote:It would be neat if a water tank would create a non-polluting spill just for looks: a highly transparent dark spill that makes the ground look wet.

 if game.entity_prototypes and game.entity_prototypes[entity_name].corpses then

 if game.entity_prototypes[entity_name] and game.entity_prototypes[entity_name].corpses then

sparr wrote:

thereaverofdarkness wrote:It would be neat if a water tank would create a non-polluting spill just for looks: a highly transparent dark spill that makes the ground look wet.

I think that will happen after I come up with a way to do more per-fluid things, like making other fluids safe, making gas clouds instead of liquid spills, making explosions, etc.

FLUID_PROPERTIES = {
  "water": {
    type: "liquid",
    pollution: 0,
    volatility: 80
  },
  "petroleum-gas": {
    type: "explosive",
    pollution: 8,
    volatility: 100
  },
  "liquified-air": {
    type: "air",
    pollution: 0,
    volatility: 100
  },
  "heavy-oil": {
    type: "liquid",
    pollution: 8,
    volatility: 20
  }
}

sparr wrote:making gas clouds instead of liquid spills, making explosions, etc.

bNarFProfCrazy wrote:Hi again, its me

bNarFProfCrazy wrote:EDIT: AFAICT, you can simply change:

Code: Select all

 if game.entity_prototypes and game.entity_prototypes[entity_name].corpses then

to

Code: Select all

 if game.entity_prototypes[entity_name] and game.entity_prototypes[entity_name].corpses then

to fix that issue.

bNarFProfCrazy wrote:Another request:
Please add a link to your README file on github targetting this thread. Because it took me quite a while to find this thread again in the forums.

bNarFProfCrazy wrote:I also had a quick peek at your License file. It looks like you are using the MIT license, but it does not state it explicitly in the file.
Because of that I recommend you to copy paste the content of this page https://mit-license.org/ including the heading and the line-breaks to simplify things for everyone.

bNarFProfCrazy wrote:Quick hint: The default name for license files on github is "LICENSE".

bNarFProfCrazy wrote:Well you could do it like this:

sparr wrote:

bNarFProfCrazy wrote:I also had a quick peek at your License file. It looks like you are using the MIT license, but it does not state it explicitly in the file.
Because of that I recommend you to copy paste the content of this page https://mit-license.org/ including the heading and the line-breaks to simplify things for everyone.

The license itself doesn't require that those lines be kept. I feel that it makes more sense to only put content in the license file that the license applies to itself.

sparr wrote:

bNarFProfCrazy wrote:Well you could do it like this:

...

If you use this or a similar approach, then you can even add support for mod provided liquids without actually depend on them.
If you need more explanation/help, just ask.

I don't want to hard-code details of so many fluids, especially for other mods. I might hard code the default fluids and publish a remote for other mods to provide info through. I might instead try to figure out some of the relevant stats algorithmically.

bNarFProfCrazy wrote:

sparr wrote:I don't want to hard-code details of so many fluids, especially for other mods. I might hard code the default fluids and publish a remote for other mods to provide info through. I might instead try to figure out some of the relevant stats algorithmically.

I think that will be very hard. Since some things are cobbled together out of thin air.
Do you habe a rough outline for your algorithm?

sparr wrote:

bNarFProfCrazy wrote:

sparr wrote:I don't want to hard-code details of so many fluids, especially for other mods. I might hard code the default fluids and publish a remote for other mods to provide info through. I might instead try to figure out some of the relevant stats algorithmically.

I think that will be very hard. Since some things are cobbled together out of thin air.
Do you habe a rough outline for your algorithm?

One idea I had was to walk up the recipe tree and see what's used to make a fluid. Things made from nothing or water would have no pollution value. Things made from stone would have low pollution value. Things made from iron or copper would have medium pollution value. Things made from oil would have high pollution value. Things made from oil plus another resource would have very high pollution value.