Factorio Forums

Qon wrote:Qonsider

Shrooblord wrote:

Qon wrote:Qonsider

Lol

Thanks for your updates to another's mod, Qon!

TrojanEnder wrote:Found a mod I'd like compatibility with. Orbital Ion Cannon has a recent feature with auto-targeting. It uses a radar type device kind of like the launch mod. As soon as I place it it get's replaced by your radar. Would love it if you could make this an exception. Thanks!

Qon wrote:

TrojanEnder wrote:Found a mod I'd like compatibility with. Orbital Ion Cannon has a recent feature with auto-targeting. It uses a radar type device kind of like the launch mod. As soon as I place it it get's replaced by your radar. Would love it if you could make this an exception. Thanks!

I have made unofficial updates to both mods. Read last post on page 2 in this thread for the sat radar update.
Satellite radar: compatability with ALL mods (past, present, future)

Wakaba-chan wrote:Hello,
Thank you for cool mod!
But tried it with Ion Cannon mod and your mod replaced all auto-tracking radars from that mod :c I wish I could have both of them in game. I corrected your control.lua like this

Code: Select all

function BuiltEntity(event)
  if event.created_entity.[b]name=="radar" [/b]and event.created_entity.name~="launch-control-center" and event.created_entity.name~="train-tracker" then  
    local e = event.created_entity
    local s = e.surface
    local p = e.position
    local f = e.force
    local d = e.direction
    level=CalculateLevel(0)
    if level>0 then
      e.destroy()
      s.create_entity{name = "radar"..level, position = p, force = f, direction = d}
    end
  end
end

script.on_event(defines.events.on_entity_died, function(event)
  local e = event.entity
  local X = e.position.x
  local Y = e.position.y
  local s = e.surface
  if [b]e.name=="radar" [/b]and e.name~="launch-control-center" and e.name~="train-tracker" then
    local ghost = s.find_entities_filtered({area={{X-0.5,Y-0.5},{X+0.5,Y+0.5}}, type = "entity-ghost"})
    if ghost[1]~= nil then
      ghost[1].destroy()
    end
    s.create_entity{name = "entity-ghost", position = {X,Y}, inner_name = "radar", force = e.force}
  end
end)

I.e. I changed "e.type = "radar" to "e.name = "radar" so that only vanilla radar would be replaced.
Is this correct? Or there are some more deep changes need to be done?

[b][/b]

Qon wrote:And no, that won't work. There are other places that needs fixes and you can't check for name = "radar" on some of them, like you do on on_entity_died, because the mod replaces all "radar" with satellite radars when built. So no vanilla radar entities will ever be placed down. It also has a script for replacing all satellite radars when you send up satellites that you did not update. Your changes will not be sufficient. Your radars will not be upgraded automatically by launching satellites. If your radars get destroyed they will not have a radar ghost placed, so your qonstruction bots will not rebuild it.

Use my unofficial update version or diff my changes. Good luck

Wakaba-chan wrote:

Qon wrote:And no, that won't work. There are other places that needs fixes and you can't check for name = "radar" on some of them, like you do on on_entity_died, because the mod replaces all "radar" with satellite radars when built. So no vanilla radar entities will ever be placed down. It also has a script for replacing all satellite radars when you send up satellites that you did not update. Your changes will not be sufficient. Your radars will not be upgraded automatically by launching satellites. If your radars get destroyed they will not have a radar ghost placed, so your qonstruction bots will not rebuild it.

Use my unofficial update version or diff my changes. Good luck

Uh, sorry, my english is not very good, so I didn't understand the main point: is it possible that your mod will work with Ion Cannon mod or not? Thank you in advance for explanations.

-------
UPD: I mean, how to make them work together in correct way

Qon wrote:

Wakaba-chan wrote:

Qon wrote:And no, that won't work. There are other places that needs fixes and you can't check for name = "radar" on some of them, like you do on on_entity_died, because the mod replaces all "radar" with satellite radars when built. So no vanilla radar entities will ever be placed down. It also has a script for replacing all satellite radars when you send up satellites that you did not update. Your changes will not be sufficient. Your radars will not be upgraded automatically by launching satellites. If your radars get destroyed they will not have a radar ghost placed, so your qonstruction bots will not rebuild it.

Use my unofficial update version or diff my changes. Good luck

Uh, sorry, my english is not very good, so I didn't understand the main point: is it possible that your mod will work with Ion Cannon mod or not? Thank you in advance for explanations.

-------
UPD: I mean, how to make them work together in correct way

Yes, my mod update should work with all radar mods! I have tested it with Orbital Ion Cannon and it works.

Wakaba-chan wrote:
"Your update" - you mean 0.2.2 version, or something you mentioned above? (sorry, I didn't read all the thread :c)

Qon wrote:Try to make it compatible with all mods ever made or will be made in the future by at least checking if the item you are replacing is a regular radar or satellite radar.

You name the radars things like "radar2" which could potentially collide with someone elses mod though. Qonsider naming it "satellite-radar-2" or similar instead in case someone makes a Mk2 radar and calls it "radar2"

Qon wrote:Isn't it possible to modify the radars instead of making new ones?

Qon wrote:I haven't tested balance yet but from the numbers it sounds like these are a very expensive way to get very underwhelming results. All other radar mods I've tried are more powerful than this without sending a single rocket.

Qon wrote:Please read http://freedomdefined.org/Licenses/NC
NC is not gaining you anything.

• Added compatibility with all mods. This mod will now never affect any entities created by other mods. Thanks to Qon for making the initial changes for this while I was away.
• Added blueprint support. I'm surprised no one had reported this wasn't working.
• Changed license from CC BY-NC-SA 4.0 to CC BY-SA 4.0 based on input from Qon.
• Updated info.json with factorio-version=0.12 in preparation for 0.13 requirement.

• Updated for 0.13.0

Qon wrote:I would like to request some screenshots

catalyst518 wrote:Now that I have visualized what level 17 looks like, I may adjust the default (or at least my own private settings for now) scanning range parameters in the next update to keep the scanning range in the same ratio as the vanilla parameters.

catalyst518 wrote:

Qon wrote:I would like to request some screenshots

A picture has been added to the main post with some ranges drawn.

Qon wrote: What are your map settings?

>>>AAAMACMAAAADAwYAAAAEAAAAY29hbAMDAgoAAABjb3BwZXItb3Jl
AwMCCQAAAGNydWRlLW9pbAMDAgoAAABlbmVteS1iYXNlAwMCCAAAAGl
yb24tb3JlAwMCBQAAAHN0b25lAwMCbvc1eOcmAAB5LgAAAAAAAAAAAA
ADAL+2clo=<<<

TrojanEnder wrote:

catalyst518 wrote:Now that I have visualized what level 17 looks like, I may adjust the default (or at least my own private settings for now) scanning range parameters in the next update to keep the scanning range in the same ratio as the vanilla parameters.

Yes! This please! This is what I always expected this mod to be. It would also match better with RSO-Radar. Also maybe detect if RSO-Radar is present don't replace it until level 3 or whatever.