Page 1 of 2

[mod 0.12.30] {BB} - Belt Brush

Posted: Sat Mar 19, 2016 1:28 pm
by matjojo
Mod-Info
  • Name: Belt Brush
  • Version: 0.0.5
  • Factorio-Version: 0.12.30 (which Factorio version this was tested with)
  • Description: A brush to place belts with like concrete.
  • License: MIT
  • Release: 2016-03-19
  • Website: BeltBrush on the forum (this page)
  • Category: Helper mods
  • Tags: Utilities, Transport belts, Gameplay, Multiplayer compatible.
License
Long description
To Do
Change log
Older Versions

Re: [mod 0.12.27] {BB} - Belt Brush

Posted: Sat Mar 19, 2016 1:29 pm
by matjojo
Reserved for future use.

Re: [mod 0.12.27] {BB} - Belt Brush

Posted: Sun Mar 20, 2016 12:39 am
by Murlocking
Could you possibly add a feature like this mod does viewtopic.php?f=92&t=14093&start=10 to your mod please?

The other guy doesn't upload very often, and having to use 1 mod instead of 2 would be great + it would be up-to-date.

Thank you!

Re: [mod 0.12.27] {BB} - Belt Brush

Posted: Sun Mar 20, 2016 12:56 pm
by Murlocking
In multiplayer, game crashed with an error for my friend (He's not the Host).

He was placing belts with the "first" mode of your mod (regular) and he got kicked out of the game after an error message appeared.
He didn't screenshot it unfortunately....

Had to remove the mod from my server for now.
Hope you can find the issue!
Sorry about no error message, my friend is not really technical with PC...

Re: [mod 0.12.27] {BB} - Belt Brush

Posted: Sun Mar 20, 2016 2:27 pm
by matjojo
Murlocking wrote:In multiplayer, game crashed with an error for my friend (He's not the Host).

He was placing belts with the "first" mode of your mod (regular) and he got kicked out of the game after an error message appeared.
He didn't screenshot it unfortunately....

Had to remove the mod from my server for now.
Hope you can find the issue!
Sorry about no error message, my friend is not really technical with PC...
I'm sorry! as for the message: maybe the log file can help, could you please ask him to send me (or you) the log-old and log-current files, I might learn what happened from that.
Also the server logs, if it crashed too.

Re: [mod 0.12.27] {BB} - Belt Brush

Posted: Sun Mar 20, 2016 2:40 pm
by sillyfly
I think your `on_gui_click` function should get a player index variable. This way you could also apply the logic to the player who clicked it, not always the first player.

http://lua-api.factorio.com/0.12.27/eve ... _gui_click

Re: [mod 0.12.27] {BB} - Belt Brush

Posted: Sun Mar 20, 2016 2:42 pm
by matjojo
Murlocking wrote:Could you possibly add a feature like this mod does viewtopic.php?f=92&t=14093&start=10 to your mod please?

The other guy doesn't upload very often, and having to use 1 mod instead of 2 would be great + it would be up-to-date.

Thank you!
I don't know if I can do that, I sent the creator of the other mod to ask him for permission, as he might not like it. He was active on the forum yesterday, so he probably will respond quickly.

Re: [mod 0.12.27] {BB} - Belt Brush

Posted: Sun Mar 20, 2016 2:43 pm
by matjojo
sillyfly wrote:I think your `on_gui_click` function should get a player index variable. This way you could also apply the logic to the player who clicked it, not always the first player.

http://lua-api.factorio.com/0.12.27/eve ... _gui_click
that should be it, I was thinking about what might cause this. Thanks for the heads up! I'll work a bit on it today, and might have an update ready tomorrow.

Re: [mod 0.12.27] {BB} - Belt Brush

Posted: Sun Mar 20, 2016 5:37 pm
by Murlocking
matjojo wrote:
Murlocking wrote:In multiplayer, game crashed with an error for my friend (He's not the Host).

He was placing belts with the "first" mode of your mod (regular) and he got kicked out of the game after an error message appeared.
He didn't screenshot it unfortunately....

Had to remove the mod from my server for now.
Hope you can find the issue!
Sorry about no error message, my friend is not really technical with PC...
I'm sorry! as for the message: maybe the log file can help, could you please ask him to send me (or you) the log-old and log-current files, I might learn what happened from that.
Also the server logs, if it crashed too.
Sure. (My friend logs)

Old
https://drive.google.com/file/d/0B4JjnW ... sp=sharing

Current
https://drive.google.com/file/d/0B4JjnW ... sp=sharing

Also replied on the other mod with Desync archive folder.

Hope this can help!

The error message did state 'Belt Brush' but he doesn't recall anything other than that.

Re: [mod 0.12.27] {BB} - Belt Brush

Posted: Thu Mar 24, 2016 4:31 pm
by matjojo
Murlocking wrote:Could you possibly add a feature like this mod does viewtopic.php?f=92&t=14093&start=10 to your mod please?

The other guy doesn't upload very often, and having to use 1 mod instead of 2 would be great + it would be up-to-date.

Thank you!

Twice good news, I just finished the creating and some testing of the new and improved (now multiplayer compatible) version of BB, also got green light from the mod author of that mod to integrate it's capabilities into BB implementation will wait till the next version.

Re: [mod 0.12.27] {BB} - Belt Brush

Posted: Thu Mar 24, 2016 4:36 pm
by matjojo
Just uploaded version 0.0.2, it should now work in multiplayer.

Version 0.0.2 (2016-03-24): Fixed multiplayer problem.
Download in original post.

Re: [mod 0.12.27] {BB} - Belt Brush

Posted: Thu Mar 24, 2016 11:25 pm
by Murlocking
matjojo wrote:Just uploaded version 0.0.2, it should now work in multiplayer.

Version 0.0.2 (2016-03-24): Fixed multiplayer problem.
Download in original post.
Sweet :) Will give it a try tonight!
Also great new about the other thing!

Can't wait for the merge!

Re: [mod 0.12.27] {BB} - Belt Brush

Posted: Fri Mar 25, 2016 3:21 am
by Jierdan
Got this error running version 0.0.2

Re: [mod 0.12.27] {BB} - Belt Brush

Posted: Fri Mar 25, 2016 7:04 am
by matjojo
Jierdan wrote:Got this error running version 0.0.2

Hmmmm, that's weird, what share you doing when you got the crash?

Re: [mod 0.12.27] {BB} - Belt Brush

Posted: Fri Mar 25, 2016 7:36 am
by Jierdan
I think it was related to one of the other mods I have installed, but I just tried to place a belt when it gave that error.

Added the mod list I was using during the crash(Factorio 12.29).

Re: [mod 0.12.27] {BB} - Belt Brush

Posted: Fri Mar 25, 2016 12:19 pm
by Geisel
hey matjojo,

first of all i like your addon so much! I allways did mainlines the "Armuba" way (or Steejo who know's ;) and you make my life easier :)

But i looked at your code, and i think you can improve it and make it more clean, if you want i can show you some codingthings.
... and use github :D it's much easier for code handling ;)

best regards

Re: [mod 0.12.27] {BB} - Belt Brush

Posted: Fri Mar 25, 2016 8:15 pm
by matjojo
Geisel wrote:hey matjojo,

first of all i like your addon so much! I allways did mainlines the "Armuba" way (or Steejo who know's ;) and you make my life easier :)

But i looked at your code, and i think you can improve it and make it more clean, if you want i can show you some codingthings.
... and use github :D it's much easier for code handling ;)

best regards
Thanks, I really like it when people tell me they like what I make.

I'd be really interested in learning some things to make the code a bit cleaner, I actually am doing this modding thing to learn code, I did some small things before, but nothing like this. Send me a PM and we'll figure something out.

I actually used Github before, (or any git system) but I really disliked the way the github program worked on windows, (I come from Xubuntu) and I really dislike the windows "powershell" and "cmd". I'll set it up right now actually, as I really should.

Re: [mod 0.12.27] {BB} - Belt Brush

Posted: Fri Mar 25, 2016 8:18 pm
by matjojo
Jierdan wrote:I think it was related to one of the other mods I have installed, but I just tried to place a belt when it gave that error.

Added the mod list I was using during the crash(Factorio 12.29).
Two more questions:
Where you playing multiplayer?

Did you ever get this problem again?

Re: [mod 0.12.29] {BB} - Belt Brush

Posted: Fri Mar 25, 2016 9:10 pm
by matjojo
Just uploaded version 0.0.3:

Version 0.0.3 (2016-03-25): Fixed some more multi-player problems and a single-player bug

please leave any feedback you want to.

Re: [mod 0.12.29] {BB} - Belt Brush

Posted: Sat Mar 26, 2016 12:04 am
by Jierdan
So, got this from testing just version 0.0.3 in SP: Error while running the event handler: __BeltBrush__/control.lua:156: attempt to index global 'BB_glob_amount' (a nil value)
Also, the folder path wasn't correct(Zip needs the files inside a BeltBrush_0.0.3 folder).