Factorio Forums

StormReaper wrote:Just came to say i found a pretty nasty bug, my factorio kept taking almost a minute to load a save lately so today I decided to find the cause of the issue and it appears to be this mod, in particular it save a lot of data into the script.dat file I think its the locations of all the modules i've placed? under the "removeTicks" in the table. The script file has grown over 2mb in size and it attempts to load it all from the save each time. I think its missing a removal somewhere or maybe its just the way it works not sure my lua isnt that great. Anyway hope you can help, and thanks for the mods, really appreciated.

Choumiko wrote:

StormReaper wrote:Just came to say i found a pretty nasty bug, my factorio kept taking almost a minute to load a save lately so today I decided to find the cause of the issue and it appears to be this mod, in particular it save a lot of data into the script.dat file I think its the locations of all the modules i've placed? under the "removeTicks" in the table. The script file has grown over 2mb in size and it attempts to load it all from the save each time. I think its missing a removal somewhere or maybe its just the way it works not sure my lua isnt that great. Anyway hope you can help, and thanks for the mods, really appreciated.

Good catch.. and yes that is one nasty bug Working on a temporary fix right now (tbh i don't fully understand what i was doing with the data i save ), will make a proper fix after i got some sleep. For the giggles you can do /c remote.call("mi","saveVar") in the console. This creates a file in script-output named module.lua which contains all the stored data

Edit: Temporary fix: replace control.lua in the zip with https://raw.githubusercontent.com/Choum ... ontrol.lua and run /c remote.call("mi", "cleanup") in the console.

Cannot execute command. Error: [string "remote call("mi", cleanup")"]:1: Error when running interface function micleanup: _ _ ModuleInserter _ _ /control.lua 329: attempt to index local ' proxyData' (a nil value)

Cannot insert Unkwon key: "entity-name.module-inserter-proxy". Player's inventory full

• fix error with full inventory
• fix data not being cleaned up
• store data by player.index instead name
• unregister on_tick if not needed

StormReaper wrote: Also I forgot to mention another bug that I came across which is when the inventory is full, you get an error like this

Code: Select all

Cannot insert Unkwon key: "entity-name.module-inserter-proxy". Player's inventory full

Choumiko wrote:Updated to 0.1.34

• fix error with full inventory
• fix data not being cleaned up
• store data by player.index instead name
• unregister on_tick if not needed

When upgrading it will remove all unneeded data that might be there. /c remote.call("mi", "cleanup") should now work (again)

StormReaper wrote: Also I forgot to mention another bug that I came across which is when the inventory is full, you get an error like this

Code: Select all

Cannot insert Unkwon key: "entity-name.module-inserter-proxy". Player's inventory full

Not (completely) my fault: viewtopic.php?f=7&t=23901
It should now only create ghosts if you have at least one free slot in the main inventory or quickbar, or already one of the proxy items in the inventory

StormReaper wrote:

Choumiko wrote:Updated to 0.1.34

• fix error with full inventory
• fix data not being cleaned up
• store data by player.index instead name
• unregister on_tick if not needed

When upgrading it will remove all unneeded data that might be there. /c remote.call("mi", "cleanup") should now work (again)

StormReaper wrote: Also I forgot to mention another bug that I came across which is when the inventory is full, you get an error like this

Code: Select all

Cannot insert Unkwon key: "entity-name.module-inserter-proxy". Player's inventory full

Not (completely) my fault: viewtopic.php?f=7&t=23901
It should now only create ghosts if you have at least one free slot in the main inventory or quickbar, or already one of the proxy items in the inventory

The config is clean now, but the game crashes if you try to use the inserter with full inventory, which is not ideal

here's a log if needed
http://pastebin.com/sjXgjVVh

StormReaper wrote:

Choumiko wrote:Updated to 0.1.34

• fix error with full inventory
• fix data not being cleaned up
• store data by player.index instead name
• unregister on_tick if not needed

When upgrading it will remove all unneeded data that might be there. /c remote.call("mi", "cleanup") should now work (again)

StormReaper wrote: Also I forgot to mention another bug that I came across which is when the inventory is full, you get an error like this

Code: Select all

Cannot insert Unkwon key: "entity-name.module-inserter-proxy". Player's inventory full

Not (completely) my fault: viewtopic.php?f=7&t=23901
It should now only create ghosts if you have at least one free slot in the main inventory or quickbar, or already one of the proxy items in the inventory

The config is clean now, but the game crashes if you try to use the inserter with full inventory, which is not ideal

here's a log if needed
http://pastebin.com/sjXgjVVh

FactorioBot wrote:

• Bugfixes
  • Fixed crash when using can_insert on the quickbar from the Lua APi.

KorGgenT wrote:It will not insert productivity modules into machines for recipes that bob's has overridden.

Qon wrote: But would be even better if it used the logistics network bots when out of range from your personal roboport (or if you don't have one). Right now I have to run to every machine to get in range which is tedious. When deploying small blueprints it's very good, but once you start deploying blueprints that are huge then module insertion is loads of manual work again. I've downloaded other mods which gives me better armor (more slots), and better personal roboports (and I use many of them) and better fusion cores to get long range personal roboports. But it's still not enough when deploying things that are like 200x200 tiles or bigger.

It could have a few more config slots also so I don't have to remove settings for assembly machines to fit in the chemical plants and so on.

The awaited blueprints with modules in 0.13 will be even better than this mod in most of my cases, but that will take quite a while and this mod will still have some uses even then.

mooklepticon wrote:I think I am going crazy, but I think it's generating the modules. I have assembler 3's set to recieve 3xEfficiency level 2's and 1x speed level 2. I don't have any speed 2's on me. It inserts them anyway. I can do this repeatedly. I checked several times.

Here's a video: http://sendvid.com/3h8lelq4

Choumiko wrote:

mooklepticon wrote:I think I am going crazy, but I think it's generating the modules. I have assembler 3's set to recieve 3xEfficiency level 2's and 1x speed level 2. I don't have any speed 2's on me. It inserts them anyway. I can do this repeatedly. I checked several times.

Here's a video: http://sendvid.com/3h8lelq4

Is the assembler in a logistics network? If so, ModuleInserter will take modules out of it if the player doesn't have them (see Notes in first post)