Factorio Forums

BrkDmrkn wrote:Game doesn't detect the mod. Sounds awesome though!

SigmatroN wrote:

BrkDmrkn wrote:Game doesn't detect the mod. Sounds awesome though!

W-what? Are you sure, you put it in the right folder, and run game of version 11.22? Does something similar happen with any other mod?

SigmatroN wrote:What do you mean by "detect"? Not showing it on the mod list?

Lonewolf wrote:I'm guessing he placed the rar file in the mods directory but the game reads only zip? So unpacking it will most likely solved it

daniel34 wrote:

Lonewolf wrote:I'm guessing he placed the rar file in the mods directory but the game reads only zip? So unpacking it will most likely solved it

Just wanted to post that. The download is a .rar-Archive, and on systems that have an extractor that can read rar (like WinRAR) the symbol is the same as for zip. I didn't even notice it was a rar, until I extracted it and then the mod was detected.
@SigmatroN: please pack your mod into a .zip-File instead of .rar, so you don't need to install WinRAR or other tools to extract it, also the .zip is automatically detected by Factorio.

EDIT: Just tried the mod on an existing save that has several mods already, and the GUI doesn't pop up when opening the CyberChest, so I can't click the Start/Pause button.
I do have the upgrade planner mod installed and it adds a GUI, maybe that's why your GUI doesn't show.

daniel34 wrote:

Lonewolf wrote:I'm guessing he placed the rar file in the mods directory but the game reads only zip? So unpacking it will most likely solved it

Just wanted to post that. The download is a .rar-Archive, and on systems that have an extractor that can read rar (like WinRAR) the symbol is the same as for zip. I didn't even notice it was a rar, until I extracted it and then the mod was detected.
@SigmatroN: please pack your mod into a .zip-File instead of .rar, so you don't need to install WinRAR or other tools to extract it, also the .zip is automatically detected by Factorio.

EDIT: Just tried the mod on an existing save that has several mods already, and the GUI doesn't pop up when opening the CyberChest, so I can't click the Start/Pause button.
I do have the upgrade planner mod installed and it adds a GUI, maybe that's why your GUI doesn't show.

darkshadow1809 wrote:awh man. This is AWESOME :d ! Can I put it in the modpack ? Credits will be ofcourse added!

scitor wrote:This mod is so awesome, it just reduced my assembly lines to a fraction of the space needed before.

I've got a few questions though and a bug to report.

The bug is kind of annoying as it happend to me a few times already and it just closes the current game, without saving anything!

How to reproduce

1. Place chest and assembler
2. Select a (raw?) material in the Logistics menu (e.g. wood)
3. Press "Start/Pause"
4. Remove the wood recipe
5. Boom:

- After clicking OK you're in the Main menu, without save or anything
- Also it's a bit confusing that it states the recipe doesn't exist, although it's true. At first I though that wouldn't work but as the robots fill the chest the status bar goes up and it starts production as soon as it has enough, really nice. EDIT: I It appears that it doesn't start the production after the "recipe doesn't exist" status, I have to reset it to restart production. So maybe I should provide the items manually, but then the Requester Chest functionality becomes obsolete to me?

Factorio v0.11.22, Mod Version is 0.6.0, I'm using the ShadowsMegaModpack V-7.0.2 (with a bunch of it disabled), on windows x64 (don't think thats important)

The questions:
a) I've noticed that the Cyberchests act like Requester Chests to the Logistics network. That's really cool as I can let it request even the base materials. But I tried to produce some items that I already had in my logistics network and the robots kept filling the chest with the (intermediate) products. Is there a way I can prevent this? The problem is in a few cases that produced a loop without crafting anything. I tried it by moving the chest out of the logistics range, but that means I can't use it as Requester Chest for the base materials. It would be nice to be able to disable the Logistics functionality (entirely or maybe per slot?), so that I can insert any base material manually. Or maybe multiple tiers which you'd have to research,w ith a basic version and an advanced requester version, just an idea

b) When I use inserters to fetch out the end product, it doesn't honor the "Reserved Slot" setting. As I understand it the Cyberchest will always leave one of a kind in itself but that doesn't seem to affect other machines accessing its inventory. Maybe the chest could "report" just one item less than it's actually holding, to prevent inserters from removing all of the products. (On the other hand, to remove specific items I need a smart inserter anyway, so the only thing that would save would be the red/green wire to detect the contents).

Thanks for this small but powerful mod, already using it where I can

Nathan1852 wrote:Sadly it seems like the script used by the cyberchests is not very optimised. Could you look at it again?

2015-06-02_00003.jpg

Nathan1852 wrote:I have four chests.

EDIT: The fix isn't working atm, I'm working on it

I experimented a little bit and it seems like I found a fix by changing the start of cyberchest.initialize_assembler to this:

Code: Select all

function cyberchest.initialize_assembler(self)
	local recipe_name = self:getorder().name
	self._actnumber = 1
	self.all_in_place = true
...

Changing the cyberchest.wait_for_ingredients function to this:

Code: Select all

function cyberchest.wait_for_ingredients(self)
	if not self.assembler.recipe then self:set_state_ready() end
	
	if not self.asm_out then
		self.asm_out = self.assembler.getinventory(defines.inventory.assemblingmachineoutput)
		self.asm_in = self.assembler.getinventory(defines.inventory.assemblingmachineinput)
		self.inv = self.entity.getinventory(defines.inventory.chest)	
		self.ing = ingredients_to_simplestack(self.assembler.recipe.name)
	end
	
	if not self.asm_out.isempty() then --already contains results
		self.state = self.wait_for_output
		self.message = "Waiting for results.."
		--self:state()
	end
	
	local asm_in_count, needed_stack = {};
	local inv_count;
	
	
	self._itemnumber = #self.ing
	if self._actnumber == 1 then
		self:reset_bar()
	end
	--for _,item_stack in pairs(self.ing) do
	local num = self._itemnumber - self._actnumber > 2 and 2 or 1
	
	for i = self._actnumber, num do
		local item_stack = self.ing[i]
		asm_in_count = self.asm_in.getitemcount(item_stack.name)
		inv_count = self.inv.getitemcount(item_stack.name)
		if self.reserve_slots then
			inv_count = inv_count - 1 --reserve 1 item
		end
		
		if inv_count + asm_in_count < item_stack.count then
			needed_stack = {name = item_stack.name, count = item_stack.count - asm_in_count - inv_count} --only needed count
			if self.collect_from_ground and self.inv.caninsert(needed_stack) then --option, tech, space
				if self:collected_from_ground(needed_stack) then
					self.inv.insert(needed_stack)
					inv_count = inv_count + needed_stack.count
				else
					self.all_in_place = false
				end
			else
				self:restore_bar()
				return
			end
		end
	end
	self._actnumber = self._actnumber + num
	if self._actnumber >= self._itemnumber then
		self:restore_bar()
	
		if not self.all_in_place then
			if self.autoreset then --resets after 5 seconds
				self:autoreset_countdown()
			end
			return --not enough of something
		end
		self.autoreset_count = 30 --reset countdown
	
		--all in place
		for _,item_stack in pairs(self.ing) do
		--insert only needed count
			if item_stack.count > 0 then
				if not stack_transfer(self.inv, item_stack, self.assembler) then
					self.message = "Unknown error while trying to insert ingredients"
					return
				end
			end
		end
	end
	
	self.state = self.wait_for_output
	self.message = "Waiting for results.."
	--self:state()
end

And deleting every self:state() call exept in cyberchest.state_execute

This brings it down from 7.170 to about 0.5 and puts the FPS drops from 10 to a maximum of 1 every few seconds.