✅ Mod uploade: Status Invalid

A place to talk about the official Factorio mod portal (https://mods.factorio.com)
Post Reply
User avatar
Optera
Smart Inserter
Smart Inserter
Posts: 2916
Joined: Sat Jun 11, 2016 6:41 am
Contact:

✅ Mod uploade: Status Invalid

Post by Optera »

2019-03-17-20-38-36-0413530.png
2019-03-17-20-38-36-0413530.png (5.25 KiB) Viewed 1257 times
I get this very unhelpful error message trying to upload this mod.
Attachments
VoidChestPlus_2.2.1.zip
(42.88 KiB) Downloaded 67 times

User avatar
Optera
Smart Inserter
Smart Inserter
Posts: 2916
Joined: Sat Jun 11, 2016 6:41 am
Contact:

Re: Mod uploade: Status Invalid

Post by Optera »

Update:
After a lot of trial and error I found out what the portal disliked about the archive.

The archive was created with

Code: Select all

git archive --prefix 'VoidChestPlus_2.2.1\' -o 'VoidChestPlus_2.2.1.zip' -9 HEAD
Notice the backslash at the end of the prefix for making the subfolder inside the archive.
The portal however insists on this being a nix type forward slash even though either is valid for zip standard.

User avatar
Sanqui
Factorio Staff
Factorio Staff
Posts: 266
Joined: Mon May 07, 2018 7:22 pm
Contact:

Re: Mod uploade: Status Invalid

Post by Sanqui »

Sorry you had to resort to trial and error, I didn't have time to look into it yet.

This is what the .zip looks like if I open it:
VoidChestPlus_2.2.1.zip _257.png
VoidChestPlus_2.2.1.zip _257.png (65.48 KiB) Viewed 1231 times

I also just tested the mod you uploaded here and at least on Linux, my game fails to recognize your mod.
So this is definitely an error, what I'll do is add a specific error message to the mod portal. Thanks!
ovo

User avatar
Optera
Smart Inserter
Smart Inserter
Posts: 2916
Joined: Sat Jun 11, 2016 6:41 am
Contact:

Re: ✅ Mod uploade: Status Invalid

Post by Optera »

Therax helped figure out why Linux fails to read this archive. This is how his Linux read it:

Code: Select all

$ unzip -l VoidChestPlus_2.2.1.zip
Archive:  VoidChestPlus_2.2.1.zip
  Length     Date   Time    Name
 --------    ----   ----    ----
     1783  03-17-19 13:35   VoidChestPlus_2.2.1/Changelog.txt
     1055  03-17-19 13:35   VoidChestPlus_2.2.1/License.md
     1157  03-17-19 13:35   VoidChestPlus_2.2.1/control.lua
     1429  03-17-19 13:35   VoidChestPlus_2.2.1/data.lua
        0  03-17-19 13:35   VoidChestPlus_2.2.1\graphics/
    13518  03-17-19 13:35   VoidChestPlus_2.2.1\graphics/hr-voidchest.png
        0  03-17-19 13:35   VoidChestPlus_2.2.1\graphics/icon/
     6917  03-17-19 13:35   VoidChestPlus_2.2.1\graphics/icon/voidchest.png
     7970  03-17-19 13:35   VoidChestPlus_2.2.1\graphics/voidchest.png
      431  03-17-19 13:35   VoidChestPlus_2.2.1/info.json
        0  03-17-19 13:35   VoidChestPlus_2.2.1\locale/
        0  03-17-19 13:35   VoidChestPlus_2.2.1\locale/en/
      326  03-17-19 13:35   VoidChestPlus_2.2.1\locale/en/en.cfg
      196  03-17-19 13:35   VoidChestPlus_2.2.1/settings.lua
    13518  03-17-19 13:35   VoidChestPlus_2.2.1/thumbnail.png
Linux seems to strictly follow zip standard only allowing forward slashes in paths.
Windows and all package programs I tried on it seem to allow either forward or backward slashes, even mixed into an unholy mess.


I don't think there's a point in allowing these archives.
What I would like though is for the portal to detect this and offer a helpful error message telling other mod creators to not use backslashes in archive paths.

Post Reply

Return to “Mod portal Discussion”