Page 1 of 1

Portal fails parsing valid changelog.txt

Posted: Thu Feb 14, 2019 12:06 pm
by Optera
Please fix the portal's changelog parser to work exactly like the in game parser.
This mod has a working changelog in game, but the portal refuses to display it.

Re: Portal fails parsing valid changelog.txt

Posted: Thu Feb 14, 2019 1:18 pm
by Sanqui
The problem was that the Mod Portal expects the file to be named changelog.txt (i.e. case sensitive). I'll be fixing this soon.

Re: Portal fails parsing valid changelog.txt

Posted: Fri Jun 14, 2019 2:14 pm
by Pi-C
Same issue here: The contents of changelog.txt is shown in the game, but not on the mod portal page. I've uploaded three days ago, so I guess something is wrong. :-)

[Edit: wrong information removed]

Update: Turns out nothing was wrong! It seems to be intended that the mod portal hides the changelog for the first release of a mod. After you release an update, the changelog will be shown. I just updated the changelog tutorial accordingly. :-)

Re: Portal fails parsing valid changelog.txt

Posted: Wed Jun 19, 2019 8:23 am
by Sanqui
Pi-C wrote: Fri Jun 14, 2019 2:14 pm Update: Turns out nothing was wrong! It seems to be intended that the mod portal hides the changelog for the first release of a mod. After you release an update, the changelog will be shown. I just updated the changelog tutorial accordingly. :-)
That's not intended at all, that's a bug! Thanks for finding it, I'll fix it soon :)

Re: Portal fails parsing valid changelog.txt

Posted: Wed Jun 19, 2019 8:56 am
by posila
Sanqui wrote: Thu Feb 14, 2019 1:18 pm The problem was that the Mod Portal expects the file to be named changelog.txt (i.e. case sensitive). I'll be fixing this soon.
Game expects it to be all lower case too, though. But it is not enforced on Windows when the file is loaded from directory (instead of zip file), because Window's filesystem functions are case insensitive.

Re: Portal fails parsing valid changelog.txt

Posted: Wed Jun 19, 2019 11:27 am
by Sanqui
posila wrote: Wed Jun 19, 2019 8:56 am
Sanqui wrote: Thu Feb 14, 2019 1:18 pm The problem was that the Mod Portal expects the file to be named changelog.txt (i.e. case sensitive). I'll be fixing this soon.
Game expects it to be all lower case too, though. But it is not enforced on Windows when the file is loaded from directory (instead of zip file), because Window's filesystem functions are case insensitive.
Oh, that makes sense. So this changelog would load in Factorio on Windows, but not Linux. I've already got some checks for similar problems in place, so I'll make the Mod Portal throw an error on this too.