BUG: Have updated my mod, found several issues/portal bugs
Posted: Wed Jun 29, 2016 9:31 pm
This is the mod. It's not very popular, so I'm leaving it in its current state so you can investigate. https://mods.factorio.com/mods/DRY411S/ ... lBatteries
The first time I uploaded it, I gave it version 0.13.00. It was uploaded as RemoveChemicalBatteries_0.13.00.zip and the portal renamed it as RemoveChemicalBatteries_0.13.0.zip.
The game doesn't think that the zip file having a different name to the version number in info.json is an issue, and the game loads it.
Then I found a bug in info.json. I had accidentally coded it like this:
There are two dependency lines. If I look at the portal version of info.json, it has ignored the first line, so on the portal, it shows info.json as
In other words, the portal has ignored the first 'dependencies' line.
The game however has not, it has ignored the second line. You can see too that it has ignored the version number in the info.json file (0.13.01) and is displaying the version number in the zip file name (0.13.0)
So the portal has interpreted the info.json a different way to the game, and the game is picking up the version number from the zip, not the info.json.
Anyway, there is definitely a bug in my mod, because the game isn't recognising the dependency. I therefore edit info.json. I uplift the version to v0.13.01, and remove the rogue line. info.json now looks like this.
I produce a new zip RemoveChemicalBatteries_0.13.01.zip and upload it to the portal. This time the portal renames to zip as RemoveChemicalBatteries_0.13.1.zip.
So now the zip file is at 0.13.1 the game menu displays 0.13.1 but the folder in the zip and the info.json is at 0.13.01. On my GitHub the version is v0.13.01. This is very confusing for the user and the developer.
The first time I uploaded it, I gave it version 0.13.00. It was uploaded as RemoveChemicalBatteries_0.13.00.zip and the portal renamed it as RemoveChemicalBatteries_0.13.0.zip.
The game doesn't think that the zip file having a different name to the version number in info.json is an issue, and the game loads it.
Then I found a bug in info.json. I had accidentally coded it like this:
Code: Select all
{
"name": "RemoveChemicalBatteries",
"version": "0.13.00",
"title": "Remove Chemical Batteries",
"author": "DRY411S",
"homepage": "https://github.com/DRY411S/Remove-Chemical-Batteries",
"contact": "https://forums.factorio.com/memberlist.php?mode=viewprofile&u=15698",
"description": "Prevents batteries from being made in chemical plants. But only if you have also enabled the AddAssemblerBatteries Mod, so you always have a way of making batteries.",
"factorio_version":"0.13",
"dependencies": ["base >= 0.13.00"],
"dependencies": ["base >= 0.13.00" ,"AddAssemblerBatteries >= 0.13.00"]
}
Code: Select all
{
"contact": "https://forums.factorio.com/memberlist.php?mode=viewprofile&u=15698",
"factorio_version": "0.13",
"title": "Remove Chemical Batteries",
"version": "0.13.00",
"dependencies": [
"base >= 0.13.00",
"AddAssemblerBatteries >= 0.13.00"
],
"homepage": "https://github.com/DRY411S/Remove-Chemical-Batteries",
"author": "DRY411S",
"name": "RemoveChemicalBatteries",
"description": "Prevents batteries from being made in chemical plants. But only if you have also enabled the AddAssemblerBatteries Mod, so you always have a way of making batteries."
}
The game however has not, it has ignored the second line. You can see too that it has ignored the version number in the info.json file (0.13.01) and is displaying the version number in the zip file name (0.13.0)
So the portal has interpreted the info.json a different way to the game, and the game is picking up the version number from the zip, not the info.json.
Anyway, there is definitely a bug in my mod, because the game isn't recognising the dependency. I therefore edit info.json. I uplift the version to v0.13.01, and remove the rogue line. info.json now looks like this.
Code: Select all
{
"name": "RemoveChemicalBatteries",
"version": "0.13.01",
"title": "Remove Chemical Batteries",
"author": "DRY411S",
"homepage": "https://github.com/DRY411S/Remove-Chemical-Batteries",
"contact": "https://forums.factorio.com/memberlist.php?mode=viewprofile&u=15698",
"description": "Prevents batteries from being made in chemical plants. But only if you have also enabled the AddAssemblerBatteries Mod, so you always have a way of making batteries.",
"factorio_version":"0.13",
"dependencies": ["base >= 0.13.00" ,"AddAssemblerBatteries >= 0.13.00"]
}
So now the zip file is at 0.13.1 the game menu displays 0.13.1 but the folder in the zip and the info.json is at 0.13.01. On my GitHub the version is v0.13.01. This is very confusing for the user and the developer.