Page 1 of 1

Failed to upload zip to Mod Portal: Error: certificate has expired

Posted: Sat Oct 02, 2021 10:30 am
by ixu
When I upload my mod via website all is ok.
When I try to use the "Upload to Portal" function of factoriomod-debug (1.1.11) it fails with "Failed to upload zip to Mod Portal: Error: certificate has expired"

Re: Failed to upload zip to Mod Portal: Error: certificate has expired

Posted: Sat Oct 02, 2021 1:52 pm
by SoShootMe
ixu wrote:
Sat Oct 02, 2021 10:30 am
When I try to use the "Upload to Portal" function of factoriomod-debug (1.1.11) it fails with "Failed to upload zip to Mod Portal: Error: certificate has expired"
Assuming you are talking about https://github.com/justarandomgeek/vsco ... omod-debug, the only obvious reason I can see is https://github.com/justarandomgeek/vsco ... er.ts#L584 failing due to the DST Root CA X3 expiry on 30 September. See https://letsencrypt.org/2021/10/01/cert ... -help.html.

The Factorio end looks fine to me, and suggests either the self-signed ISRG Root X1 certificate is not in the trust store used by Code, or there is an issue with the path validation logic (such as https://www.openssl.org/blog/blog/2021/ ... ertExpire/). Both these problems should only affect older software/operating systems - what are you using?

Re: Failed to upload zip to Mod Portal: Error: certificate has expired

Posted: Sat Oct 02, 2021 3:11 pm
by ixu
Betriebsystemname Microsoft Windows 10 Pro
Version 10.0.19043 Build 19043

Re: Failed to upload zip to Mod Portal: Error: certificate has expired

Posted: Sat Oct 02, 2021 3:28 pm
by SoShootMe
I should have dug harder. It looks like Code has its own TLS code and/or trust store built in: https://github.com/microsoft/vscode/issues/134244.
https://github.com/microsoft/vscode/issues/134244#issuecomment-932282722 wrote: The current fix is targeted for the September release which is due sometime next week and nightly insiders. I will see if we can also make a recovery release for the current stable.