[posila] [0.18.46] Crash when having big image in a mod for normal size

This subforum contains all the issues which we already resolved.
Post Reply
timboo07up
Inserter
Inserter
Posts: 23
Joined: Wed Nov 07, 2018 8:23 pm
Contact:

[posila] [0.18.46] Crash when having big image in a mod for normal size

Post by timboo07up »

To reproduce.

- have sprite settings set to normal
- have the max memory set at 2048 for the atlas.

Use the following mod (might need to install the dependencies).

Full factorio crash is in the logs as well.

It probably crashes on the sprite size.
Attachments
factorio-current.log
(7.86 KiB) Downloaded 136 times
nilaus_s40_0.1.3.zip
(131.28 KiB) Downloaded 124 times

posila
Factorio Staff
Factorio Staff
Posts: 5201
Joined: Thu Jun 11, 2015 1:35 pm
Contact:

Re: [posila] [0.18.46] Crash when having big image in a mod for normal size

Post by posila »

Hmm ... it is actually "not-compressed" flag on the sprite that's causing it (I think), or the combination of the flag and the size. But I'll need to look into what's happening there. Until it is fixed, I suggest removing the flag. But the images are mostly transparent with thick lines of single color, so that should compress nearly losslessly, so I would not disable compression on them even after it is fixed.

timboo07up
Inserter
Inserter
Posts: 23
Joined: Wed Nov 07, 2018 8:23 pm
Contact:

Re: [posila] [0.18.46] Crash when having big image in a mod for normal size

Post by timboo07up »

The problem with the compression was: it would compress them all down to 1 image in the atlas if i allowed compression.
Which would only give me a single image that has a red border on all sides, not all the different combinations that are possible.

For now i'm not looking for a fix, but was asked by bilka to report this here so it can be looked into.
As i would not expect a hardcrash from this, but maybe a: mod x crashed because of an image that was too big (or something more descriptive).

To give a small explanation of the mod's functions:
It generates an image on every chunk that can be "bought". When its bought the surrounding borders should be green (to give a better indication its buildable).
When i allow the compression they stay red, so it wasn't an option.

Anyhow, just wanted to help to make it even more crash proof :)
Also: if there is no solution for it, its fine as well for me. I can always work around it.

posila
Factorio Staff
Factorio Staff
Posts: 5201
Joined: Thu Jun 11, 2015 1:35 pm
Contact:

Re: [posila] [0.18.46] Crash when having big image in a mod for normal size

Post by posila »

Thanks for the report.
Fixed for 1.1

I am still little bit confused about what you said about the compression. There is no sprite deduplication logic, so the game never "compresses" different images into one image if they are similar or for any other reason, so you should be able to use compression. If you can reproduce that issue and send me a save and the mod, I'd like to look into that.

Post Reply

Return to “Resolved Problems and Bugs”