Page 1 of 1

[Klonan] Train GUI formatted incorrectly for one type of locomotive?

Posted: Fri Jan 06, 2023 6:42 am
by robot256
With Factorio 1.1.74 and Cargo Ships 0.1.18 or 0.1.19, the Ship Engine train schedule entries and conditions are horizontally misaligned. The weird thing is that it looks normal for the Boat Engine and every other locomotive. See: https://imgur.com/a/Saq7rCv

I also tried Factorio 1.1.41 and Cargo Ships 0.1.2, and different GUI scalings, with the same result. Does anyone have any idea what could cause this, or should I report it as a bug? I don't see anything different in the prototypes or localisations.

Reference report: https://mods.factorio.com/mod/cargo-shi ... 432af4128e

Re: Train GUI formatted incorrectly for one type of locomotive?

Posted: Fri Jan 06, 2023 8:10 am
by Klonan
What does the fuel tab look like?

Re: Train GUI formatted incorrectly for one type of locomotive?

Posted: Fri Jan 06, 2023 12:44 pm
by Xorimuth
I think the strange-looking width is caused by the fuel tab (lots of fuel slots, maybe a pollution efficiency multiplier as well), and is expected behaviour. The strangeness around the bottom is a base game bug happening because of the Train Groups relative GUI at the top: 98151.

Re: Train GUI formatted incorrectly for one type of locomotive?

Posted: Fri Jan 06, 2023 3:49 pm
by robot256
Klonan wrote: Fri Jan 06, 2023 8:10 am What does the fuel tab look like?
The fuel tab has 10 slots on a line along with a severely shrunken burning fuel bar.
Cargo ship fuel tab.jpg
Cargo ship fuel tab.jpg (71.08 KiB) Viewed 3105 times
That appears to be why the schedule tab horizontal alignment is off.
Cargo ship schedule tab.jpg
Cargo ship schedule tab.jpg (34.1 KiB) Viewed 3105 times
Thanks for looking at this. I would have expected the fuel slots to wrap to a second line, and I was convinced it did that in a much earlier version, maybe 0.18.

Re: Train GUI formatted incorrectly for one type of locomotive?

Posted: Sat Jan 07, 2023 4:26 pm
by Klonan
Well I have almost already fixed it in 1.2 with all the GUI cleanups,
I will add it to my TODO list
factorio-run_7oRyV6Ttfz.png
factorio-run_7oRyV6Ttfz.png (33.13 KiB) Viewed 3076 times

Re: Train GUI formatted incorrectly for one type of locomotive?

Posted: Sat Jan 07, 2023 4:41 pm
by FuryoftheStars
Klonan wrote: Sat Jan 07, 2023 4:26 pm Well I have almost already fixed it in 1.2 with all the GUI cleanups,
I will add it to my TODO list

factorio-run_7oRyV6Ttfz.png
Would it be possible to move the fuel burning bar to the next line rather than scrunching it up that small?

Re: Train GUI formatted incorrectly for one type of locomotive?

Posted: Sat Jan 07, 2023 4:46 pm
by Klonan
FuryoftheStars wrote: Sat Jan 07, 2023 4:41 pm
Klonan wrote: Sat Jan 07, 2023 4:26 pm Well I have almost already fixed it in 1.2 with all the GUI cleanups,
I will add it to my TODO list

factorio-run_7oRyV6Ttfz.png
Would it be possible to move the fuel burning bar to the next line rather than scrunching it up that small?
Sure, I will probably make it check if there are more than like, 5 slots, and if so, put it on another line

Re: Train GUI formatted incorrectly for one type of locomotive?

Posted: Sat Jan 07, 2023 6:27 pm
by FuryoftheStars
Klonan wrote: Sat Jan 07, 2023 4:46 pm
FuryoftheStars wrote: Sat Jan 07, 2023 4:41 pm
Klonan wrote: Sat Jan 07, 2023 4:26 pm Well I have almost already fixed it in 1.2 with all the GUI cleanups,
I will add it to my TODO list

factorio-run_7oRyV6Ttfz.png
Would it be possible to move the fuel burning bar to the next line rather than scrunching it up that small?
Sure, I will probably make it check if there are more than like, 5 slots, and if so, put it on another line
That sounds great! Thank you!

Re: [Klonan] Train GUI formatted incorrectly for one type of locomotive?

Posted: Mon Mar 20, 2023 3:05 am
by POPISowyNumer
Klonan wrote: Sat Jan 07, 2023 4:46 pm
FuryoftheStars wrote: Sat Jan 07, 2023 4:41 pm
Klonan wrote: Sat Jan 07, 2023 4:26 pm Well I have almost already fixed it in 1.2 with all the GUI cleanups,
I will add it to my TODO list

factorio-run_7oRyV6Ttfz.png
Would it be possible to move the fuel burning bar to the next line rather than scrunching it up that small?
Sure, I will probably make it check if there are more than like, 5 slots, and if so, put it on another line
If I may add up on this topic, would it be possible to also build in accommodation for really silly edge cases like this?
Image

EDIT: Someone who saw this comment assumed I was being silly.
To clarify on this, one trip of this ship back and forth from nearest stone patch consumes slightly above two thousand units of coal.

Re: [Klonan] Train GUI formatted incorrectly for one type of locomotive?

Posted: Thu Apr 27, 2023 5:26 am
by TheIronRelic
Just to build on this as well, in the case that there are also "used up fuel" slots as well, can they be moved onto the next line? Otherwise the window can get really wide as well. See https://mods.factorio.com/mod/IR3CargoShips for an example of a mod where it kind of causes some issues.

Re: [Klonan] Train GUI formatted incorrectly for one type of locomotive?

Posted: Thu Apr 27, 2023 2:27 pm
by Amarula
I do like the idea of treating fuel/used fuel in regular inventory style - fixed width, wrapping on to additional rows as needed. For the top row, I like how nullius shows the fuel burned status:
Nullius train fuel.png
Nullius train fuel.png (57.26 KiB) Viewed 2451 times

Re: [Klonan] Train GUI formatted incorrectly for one type of locomotive?

Posted: Sat Oct 19, 2024 1:27 am
by robot256
The current state of this issue is reasonably okay. The GUI still stretches wildly as it tries to keep all fuel slots and the currently burning progress bar on one line. The schedule GUI remains properly formatted regardless of outer frame width.
ship 30 fuel tab.png
ship 30 fuel tab.png (97.59 KiB) Viewed 313 times
ship 30 schedule tab.png
ship 30 schedule tab.png (32.03 KiB) Viewed 313 times

With default settings in Cargo Ships, you can't really tell there's a problem except for the tiny burning progress bar. Of course, if the GUI allowed it, we might make the default capacity larger.
ship 10 fuel tab.png
ship 10 fuel tab.png (85.94 KiB) Viewed 313 times
ship 10 schedule tab.png
ship 10 schedule tab.png (20.25 KiB) Viewed 313 times