[kovarex] [1.1.41] `game.show_message_dialog()` ignores `type="entity_info"`

Post Reply
Xorimuth
Filter Inserter
Filter Inserter
Posts: 623
Joined: Sat Mar 02, 2019 9:39 pm
Contact:

[kovarex] [1.1.41] `game.show_message_dialog()` ignores `type="entity_info"`

Post by Xorimuth »

Reproduction
Run the following whilst hovering over an entity:

Code: Select all

/c game.show_message_dialog{text = "Hello there", point_to={type="entity_info"}}
Expected result
Dialog appears by the entity tooltip.
Actual result
Dialog appears in the top left with no pointing arrow (exactly as if type="nowhere" had been used).
Screenshot 2021-09-23 at 19.20.56.png
Screenshot 2021-09-23 at 19.20.56.png (1.26 MiB) Viewed 1850 times
Changing "Entity tooltip on the side" makes no difference.

I don't need this for my own modding, but it is used near the beginning of tutorial level one:
Screenshot 2021-09-23 at 17.47.19.png
Screenshot 2021-09-23 at 17.47.19.png (5.53 MiB) Viewed 1850 times
My mods
Content: Freight Forwarding | Spidertron Patrols | Spidertron Enhancements | Power Overload
QoL: Factory Search | Remote Configuration | Module Inserter Simplified | Wire Shortcuts X | Ghost Warnings

User avatar
boskid
Factorio Staff
Factorio Staff
Posts: 2227
Joined: Thu Dec 14, 2017 6:56 pm
Contact:

Re: [1.1.41] `game.show_message_dialog()` ignores `type="entity_info"`

Post by boskid »

I see it is broken because of a "fix" from 82117.

In this particular case, when the game view is updated, there is a check if there is anything with modal focus and in such case it clears entity selection for the purpose of selectedInfoRenderer.

Xorimuth
Filter Inserter
Filter Inserter
Posts: 623
Joined: Sat Mar 02, 2019 9:39 pm
Contact:

Re: [1.1.41] `game.show_message_dialog()` ignores `type="entity_info"`

Post by Xorimuth »

boskid wrote:
Mon Oct 04, 2021 10:49 am
I see it is broken because of a "fix" from 82117.

In this particular case, when the game view is updated, there is a check if there is anything with modal focus and in such case it clears entity selection for the purpose of selectedInfoRenderer.
Personally I'd be inclined to completely remove entity_info and remove (or reword) that one dialog in the tutorial. I don't think it serves much purpose.
My mods
Content: Freight Forwarding | Spidertron Patrols | Spidertron Enhancements | Power Overload
QoL: Factory Search | Remote Configuration | Module Inserter Simplified | Wire Shortcuts X | Ghost Warnings

Xorimuth
Filter Inserter
Filter Inserter
Posts: 623
Joined: Sat Mar 02, 2019 9:39 pm
Contact:

Re: [kovarex] [1.1.41] `game.show_message_dialog()` ignores `type="entity_info"`

Post by Xorimuth »

This has now been fixed now so that it points to the top-right (where the tooltip would be). Still a bit weird but better than before :)
My mods
Content: Freight Forwarding | Spidertron Patrols | Spidertron Enhancements | Power Overload
QoL: Factory Search | Remote Configuration | Module Inserter Simplified | Wire Shortcuts X | Ghost Warnings

Post Reply

Return to “Assigned”