[boskid][1.1.33] Train with Destination Full even with Available Stop

[Adrenalex]

Howdy,

I ran into an issue where stops that I was copy pasting would have train limits 0/1 but the train(s) assigned to them would sit for a very long time at Destination Full and not supply them. Originally I thought it was indefinitely but in the 20 minutes I have been putting together this post, it decided it wanted to go to that stop. I've since reloaded the save several times and sometimes the train will move within the first 3-5 minutes and other times it feels much longer.

See the below 3 screenshots:

TrainBug1.png (2.86 MiB) Viewed 2487 times

TrainBug2.png (53.59 KiB) Viewed 2487 times

TrainBug3.png (1004.4 KiB) Viewed 2487 times

I've included two saves to download (Sorry they are large and heavily modded. It's an SE playthrough at 500+ hours):
1) Map with the problem on the Rocket Fuel Stop on Nauvis. I'm standing right next to said stop in this one. https://drive.google.com/file/d/14Ji9o8 ... sp=sharing
2) Map right before I place the new stations https://drive.google.com/file/d/1YE16Nb ... sp=sharing

Steps to Reproduce (There's a reference map at the bottom of the post to show where the stations I'm referring to are more easily)
1) Enter Map
2) Navigate to and copy (Ctrl + C) the two station setups on the end here (Rocket Resupply and Rocketfuel In 3-8)

Copy Stations.png (106.98 KiB) Viewed 2487 times

3) Navigate to the appropriate area and paste (Shift +LMB) them above and inline with the stations here

Paste Stations.png (303.61 KiB) Viewed 2487 times

4) The finished copy-paste should look like this

Finished CopyPaste Train.PNG (3.9 MiB) Viewed 2487 times

5) Use sat nav ghosts to finish connecting the rails with the station below it
6) A supply train will then come to build the ghosts after a few cycles of load/unload but I recommend popping into /editor mode and finishing the ghost rails to speed this up

Curiously, I was able to produce multiple results. When I tested, most of the time either the Rocket Fuel Stop or Rocket Resupply Stop can experience this by showing active but the trains still would say Destination Full. But sometimes the stops would work just fine. When the stops are immediately placed and "active" with a limit, the trains assigned to them won't say "No Path".

Reference Map:

Reference Map.PNG (1.17 MiB) Viewed 2487 times

I've done my best to provide all the steps I did. Hopefully this help to figure out what's going on and I know this can be a tedious reproduction. Please let me know if you'd like any additional information and thank you for all that you do.

[boskid]

Thanks for the reports. Issue is now fixed for 1.1.34.

It was related to building train stops next to a ghost rail because such train stops do not bind to rail yet and so the train did not transition from the destination_full state to no_path state because such train stops were skipped by the goal gathering code and that made train to believe that all the train stops are still full. When the rails were finally built, they did not cause any repath as it only happens for trains in the no_path state. After this fix, a train stop that is not connected to any rails will still be discovered and the train will enter a no_path state.