function util.combine_icons doesn't include icon_mipmaps

[bobingabout]

function util.combine_icons, in data/core/lualib/util.lua doesn't include a case to handle mipmaps.

Basically, in the "for _,icon_to_add in pairs(icons2) do" loop, just add a line that has icon.icon_mipmaps = icon_to_add.icon_mipmaps (probably directly after icon.size).

if it doesn't exist, icon_to_add.icon_mipmaps would just return nil, so icon.icon_mipmaps is set to nil, and not added, it's a purely optional tag for icons to have, and depending on the icon file, so you don't need an if else case to handle it like you do for shift and tint.

[posila]

Thanks for the report.
Fixed for 0.18.18

Frankly, I didn't even know util.combine_icons was a thing

[bobingabout]

Thanks for the report.
Fixed for 0.18.17

Frankly, I didn't even know util.combine_icons was a thing

It was added for the auto-barrel system to use in the case of a fluid having an icons= array instead of an icon.
I only really noticed the issue because I looked it up to use it for something myself, and although I'm not using icon_mipmaps in this case, I have on other layered icons, and they seem to work.

Anyway, thanks for the update.

[bobingabout]

also, you mean fixed for version 0.18.18, version 0.18.17 is the current version.