[kovarex] [0.17.49] Crash: this->reservedFor.isZero() == (this->reservedForCount == 0)

[talung]

This Crash occurs whenever I try to save the game after moving 2 rails and a chain signal.

It was happening in .48 as well and have it on stream: https://www.twitch.tv/videos/438363511?t=03h19m43s

There has been some sort of issue since .47 with removing rail signals, or marking for destruction, that have been causing crashing happening. Got most of it on streams this week.

Also, although originally running on a server, I had to switch to local only because it was causing crashes on that as well. Easier to recover on local than headless server. Ubuntu Server 4.15.18-10-pve

Current machine running Windows 10 Pro N, 1809

Please let me know if any more information is needed.

factorio-current.log

log file

(17.65 KiB) Downloaded 126 times

factorio-dump-current.dmp

(742.83 KiB) Downloaded 109 times

Game file is too big to upload here.. about 75Mb, please find dropbox link below.

https://www.dropbox.com/s/2krz202515ldv ... 7.zip?dl=0

Thanks

PS. I just had the crash confirmed by another player downloading the map and removing some rail and a signal.

[EoRaptor]

I tried the attached save.
Only managed to save the game after the LTN mod was disabled - the other mods were still active.

Hope this helps

[EoRaptor]

I tried a few more things to remove the mentioned tracks:
As removeing the LTN mod stops all trains, I tried putting all trains to manual - that allowed me to save the game as well after removeing the tracks.

Another option i tried was to make sure that block was not used for train-pathing by removing a few tracks in front of it. That worked as well.

Hope this helps

[kovarex]

Hello, I can't reproduce any crash after the other fixes made for rail signals for the next release, so I guess that it is fixed.
Although I don't really know if there is some special step I would have to do other than just opening the save, removing random rail and signal and saving.

[talung]

I will retest it on next release.

But it was really that simple.. open it, remove rail and signals then try to save.

Same method was repeated by EoRaptor, so if the changes made fix it, that will be awesome.

Thanks.

PS. After next release will let you know if resolved.

[talung]

Hi kovarex,

I just tried with 0.17.50 and it still does it.

Here is the log:

factorio-current.log

(11.03 KiB) Downloaded 104 times

and a screen shot of things i set for destruction that I removed:

Screenshot 2019-06-18 00.37.12.png (3.41 MiB) Viewed 3577 times

and the location in the actual factory.

Screenshot 2019-06-18 00.37.43.png (599.56 KiB) Viewed 3577 times

As soon as i remove those and try to save.. it crashes. Same save file as before.

Thanks. Please let me know if you need any more info.

EDIT: No mods have changed or updated, so everything is exactly the same.

[boskid]

inlined talung's log:

log

Code: Select all

0.000 2019-06-18 00:30:36; Factorio 0.17.50 (build 45742, win64, steam)

Code: Select all

c:\cygwin64\tmp\factorio-build-oyvgrk\src\rail\trainmanager.cpp (981): TrainManager::checkConsistency
c:\cygwin64\tmp\factorio-build-oyvgrk\src\rail\trainmanager.cpp (52): TrainManager::save
c:\cygwin64\tmp\factorio-build-oyvgrk\src\map\map.cpp (1276): Map::save
c:\cygwin64\tmp\factorio-build-oyvgrk\src\scenario\scenario.cpp (1001): Scenario::saveMap
c:\cygwin64\tmp\factorio-build-oyvgrk\src\scenario\scenario.cpp (897): Scenario::saveAs
c:\cygwin64\tmp\factorio-build-oyvgrk\src\scenario\parallelscenariosaver.cpp (99): ParallelScenarioSaver::doSave

Code: Select all

141.091 Error TrainManager.cpp:981: signal->reservedFor.isZero() was not true

-> indeed still crashes

---
Did above steps, managed to reproduce with different assertion failing:

my log

Code: Select all

0.003 2019-06-17 21:06:36; Factorio 0.17.50 (build 45742, win64, steam)

Code: Select all

c:\cygwin64\tmp\factorio-build-oyvgrk\src\rail\railblock.cpp (302): RailBlock::checkConsistency
c:\cygwin64\tmp\factorio-build-oyvgrk\src\rail\trainmanager.cpp (956): TrainManager::checkConsistency
c:\cygwin64\tmp\factorio-build-oyvgrk\src\rail\trainmanager.cpp (52): TrainManager::save
c:\cygwin64\tmp\factorio-build-oyvgrk\src\map\map.cpp (1276): Map::save
c:\cygwin64\tmp\factorio-build-oyvgrk\src\scenario\scenario.cpp (1001): Scenario::saveMap
c:\cygwin64\tmp\factorio-build-oyvgrk\src\scenario\scenario.cpp (897): Scenario::saveAs

Code: Select all

116.716 Error RailBlock.cpp:302: inboundSignal->getReservation() == nullptr was not true

---
going to prepare easy reproduction -> 72148

[kovarex]

Thanks for the prepared report, fixed for the next release.

[talung]

Thanks

[talung]

Just tried the new update .51 and can confirm... FIXED!

Thanks