Page 1 of 2

[0.17.39] Mods with icon beside their name not sorted correctly

Posted: Thu May 16, 2019 2:24 pm
by Pi-C
As suggested by Dominik, I'll post this as a bug report:

Mods that have an icon next to their name are listed after the alphabetically sorted mods in mod settings menus and in the mods manager:
modsettings.png
View of incorrectly sorted mod under mod settings
modsettings.png (110.05 KiB) Viewed 814 times
modmanager.png
View of incorrectly sorted mod in mods manager
modmanager.png (110.15 KiB) Viewed 814 times
Among the mods I'd installed, only Rocket-Silo Construction had icons as part of the name. So I figured I'd try to install all other mods released by its author. This is what the new list in the mods manager looks like:
modmanager2.png
View of many incorrectly sorted mods in mods manager
modmanager2.png (123.79 KiB) Viewed 814 times
Having Big-Monsters and Explosive Biters below the others seems awkward but can be explained by the icon before the name. When there's only an icon after the name, however, it looks wrong. Anyway, seems like these mods can't be sorted correctly because the names contain rich text.

Re: [0.17.39] Mods with icon beside their name not sorted correctly

Posted: Thu May 16, 2019 6:25 pm
by Rseding91
Thanks for the report however as the primary person who manages mods and works on the features put in for mods I'm going to say: play stupid games win stupid prizes.

I'm not going to implement some multiple hundreds of lines of code to handle sorting things like this. If mods put rich text bull shit in their mod names then they can deal with the fallout. Or I can disable it for mod names to be sure people don't do it.

Re: [0.17.39] Mods with icon beside their name not sorted correctly

Posted: Thu May 16, 2019 6:33 pm
by MasterBuilder
Rseding91 wrote:
Thu May 16, 2019 6:25 pm
I'm not going to implement some multiple hundreds of lines of code to handle sorting things like this. If mods put rich text bull shit in their mod names then they can deal with the fallout. Or I can disable it for mod names to be sure people don't do it.
What about some middle-ground:
Strip the rich text / images / colors / etc out of the text and sort with that? Stripping out [] with regex shouldn't be too hard.

This would do a 'good enough' sort, esp. given that most images happen to be at the end of the name.


Alternatively, you could add another field to info.json for authors to put the clean name to be used for sorting. If omitted, it would just fall back to the current sort.

Re: [0.17.39] Mods with icon beside their name not sorted correctly

Posted: Thu May 16, 2019 7:22 pm
by Rseding91
That's what I meant by 100s of lines of code to handle it.

Re: [0.17.39] Mods with icon beside their name not sorted correctly

Posted: Thu May 16, 2019 7:39 pm
by eradicator
Rseding91 wrote:
Thu May 16, 2019 6:25 pm
Or I can disable it for mod names to be sure people don't do it.
Better kill it now before the plague spreads. Before it kicks us back into the 90's.
top-10-worst-90s-website-designs-2.png
top-10-worst-90s-website-designs-2.png (160.93 KiB) Viewed 777 times

Re: [0.17.39] Mods with icon beside their name not sorted correctly

Posted: Thu May 16, 2019 9:21 pm
by steinio
Rseding91 wrote:
Thu May 16, 2019 6:25 pm
Thanks for the report however as the primary person who manages mods and works on the features put in for mods I'm going to say: play stupid games win stupid prizes.

I'm not going to implement some multiple hundreds of lines of code to handle sorting things like this. If mods put rich text bull shit in their mod names then they can deal with the fallout. Or I can disable it for mod names to be sure people don't do it.
I vote for disabling it for mod names.
It looks already awful and it got just started.
Imagine whole mod names consisting only of this icons...

Re: [0.17.39] Mods with icon beside their name not sorted correctly

Posted: Thu May 16, 2019 9:37 pm
by fishycat
steinio wrote:
Thu May 16, 2019 9:21 pm
Rseding91 wrote:
Thu May 16, 2019 6:25 pm
Thanks for the report however as the primary person who manages mods and works on the features put in for mods I'm going to say: play stupid games win stupid prizes.

I'm not going to implement some multiple hundreds of lines of code to handle sorting things like this. If mods put rich text bull shit in their mod names then they can deal with the fallout. Or I can disable it for mod names to be sure people don't do it.
I vote for disabling it for mod names.
It looks already awful and it got just started.
Imagine whole mod names consisting only of this icons...
+1

Re: [0.17.39] Mods with icon beside their name not sorted correctly

Posted: Thu May 16, 2019 9:40 pm
by orzelek
I was surprised after noticing that mod list is going rainbow/picture style.
Another vote to remove rich text from mod names.

Re: [0.17.39] Mods with icon beside their name not sorted correctly

Posted: Fri May 17, 2019 5:30 am
by Pi-C
eradicator wrote:
Thu May 16, 2019 7:39 pm
Better kill it now before the plague spreads. Before it kicks us back into the 90's.
That picture must be fake: In the 90s, websites used <marquee>, <blink>, and flashing backgrounds! :-D

About rich text in mod names: I think it's all about the right measure. Used sparingly, it could be used to some effect -- but there is a real danger that such a feature will be abused, and overused. Actually, rich text in mod names would only make sense (because that is the only places where it would be seen) in the mod manager/mod settings menus, right? But there, it breaks stuff, namely sorting. So I'm not sure how to argue for keeping it enabled …

Re: [0.17.39] Mods with icon beside their name not sorted correctly

Posted: Fri May 17, 2019 8:43 am
by Deadlock989
Yeah, ban it. It's ugly af.

Re: [0.17.39] Mods with icon beside their name not sorted correctly

Posted: Fri May 17, 2019 11:20 am
by Klonan
Rseding91 wrote:
Thu May 16, 2019 6:25 pm
Or I can disable it for mod names to be sure people don't do it.
+1

Re: [0.17.39] Mods with icon beside their name not sorted correctly

Posted: Fri May 17, 2019 12:01 pm
by mexmer
+2 for disabling RT

Re: Mods with icon beside their name not sorted correctly

Posted: Wed May 22, 2019 2:15 pm
by ZwerOxotnik
examples of mod names
Consequences

I want use rich text for localization.
If some mod developer did the mistake we can just to write to him if we really want it:
  • ~"Hey, your rich text breaks mods sorting in the mod list. Please, change your rich text or to make it better."
  • or simpler to send to him a link on this topic
  • or (for example) to create a special link/information for mod developers, players about rich text in the mod list or somewhere else
And also

Re: [0.17.39] Mods with icon beside their name not sorted correctly

Posted: Wed May 22, 2019 4:53 pm
by eradicator
Have you tried translating your mod name with a locale.cfg?

Code: Select all

[mod-name]
your-mod-name=translated-mod-name

[mod-description]
your-mod-name=translated-mod-description

Re: Mods with icon beside their name not sorted correctly

Posted: Wed May 22, 2019 5:10 pm
by ZwerOxotnik
I will show you fixing
Before
After
Screenshots: https://imgur.com/a/mrg4sZO

Re: [0.17.39] Mods with icon beside their name not sorted correctly

Posted: Wed May 22, 2019 5:16 pm
by eradicator
If you want the font contrast fixed you should submit a bug report instead of abusing rich text. That way it's fixed for everybody.

Re: Mods with icon beside their name not sorted correctly

Posted: Wed May 22, 2019 5:18 pm
by ZwerOxotnik
Do we need to remove the feature a result of a mod developer mistake?

Re: [0.17.39] Mods with icon beside their name not sorted correctly

Posted: Wed May 22, 2019 5:19 pm
by Deadlock989
ZwerOxotnik wrote:
Wed May 22, 2019 5:18 pm
Do we need to remove the feature a result of a mod developer mistake?
Apparently.

Re: [0.17.39] Mods with icon beside their name not sorted correctly

Posted: Wed May 22, 2019 5:26 pm
by eradicator
ZwerOxotnik wrote:
Wed May 22, 2019 5:18 pm
Do we need to remove the feature a result of a mod developer mistake?
I assume it was removed to preserve consistently readable menus for everyone.

Re: Mods with icon beside their name not sorted correctly

Posted: Wed May 22, 2019 5:34 pm
by ZwerOxotnik
eradicator wrote:
Wed May 22, 2019 5:26 pm
I assume it was removed to preserve consistently readable menus for everyone.
Players write bug reports to me when I made a mistake in my mod, but no one did in this case.