Page 1 of 1

[Oxyd] [0.17.2] [Linux] non-blocking-saving isn't non-blocking any more

Posted: Thu Feb 28, 2019 4:42 am
by quyxkh
Nonblocking autosaving's on in the config and the log says it's doing non-blocking saving, but the UI and sim freeze while the save's in progress, and the game's eating keystrokes again.
logfile

Re: [0.17.2] non-blocking-saving isn't non-blocking any more

Posted: Thu Feb 28, 2019 8:00 am
by Syhn
Does it say the server is not responding while saving? This may be what I am encountering, but wasn's sure if it was something wrong with my hardware.

Re: [0.17.2] non-blocking-saving isn't non-blocking any more

Posted: Thu Feb 28, 2019 8:49 am
by quyxkh
I'm doing this singleplayer, but if they introduced an unexpected lock around the saving it wouldn't be surprising if the server stopped responding for the duration too.

Re: [0.17.2] non-blocking-saving isn't non-blocking any more

Posted: Thu Feb 28, 2019 3:57 pm
by Syhn
Ah, I see. Yeah, I'm seeing the server halt for the duration of the save which causes the client to see the server "dropping."

Re: [Oxyd] [0.17.2] [Linux] non-blocking-saving isn't non-blocking any more

Posted: Sun Mar 31, 2019 3:19 am
by klugemonkey
017.23, I'm still getting 'Server not responding' message to all users when autosave occurs in non-blocking mode. It is so ridiculous, I've had all players get the watchdog dialog to exit or reconnect.

The performance of saving in general is much worse than 16.51. Anytime a player joins the delay for all other players is a significant interruption on the order of 3-10 seconds. It was annoying on 16.51 unless non-blocking saves were used and a ramdisk was utilized to minimize saves for the players joining, but now on 17.23, autosaves are blocking.

Not sure if ramdisk will improve on 17.23, but will test further to see if the issue is disk I/O or a synchronization issue.

Using linux as well.

Seems to be happening in AsyncScenarioSaver.cpp:144

Re: [Oxyd] [0.17.2] [Linux] non-blocking-saving isn't non-blocking any more

Posted: Sun Apr 07, 2019 9:58 pm
by SNACKaJACK
Is there any news on this issue? I'm encountering the same problems right now while setting up a server for 0.17.25. I would love for this feature to work again, I think it's an awesome quality of life improvement for multiplayer. Being interrupted every time someone joins or an auto-save is made gets frustrating really fast

Re: [Oxyd] [0.17.2] [Linux] non-blocking-saving isn't non-blocking any more

Posted: Thu Apr 11, 2019 8:31 am
by enoh
Hey,

Same issue on 0.17.28.

Re: [Oxyd] [0.17.2] [Linux] non-blocking-saving isn't non-blocking any more

Posted: Mon May 06, 2019 10:05 pm
by pickscrape
This appears to still be happening in 0.17.36.

Anyone know if the devs are aware of this or not, and if so, is it being worked on?

Re: [Oxyd] [0.17.2] [Linux] non-blocking-saving isn't non-blocking any more

Posted: Mon May 06, 2019 10:13 pm
by pickscrape
I just did a little digging into the release notes, based on this thread initially referencing 0.17.2. In that release, we have this entry:

"Fixed a crash when trying to use async-saving when hosting multiplayer games on Windows" (which links to this thread: 65146)

I wonder if the fix inadvertently made linux also fall back to blocking saves, even when non-blocking saves are enabled (and show as such in the log)?

Re: [Oxyd] [0.17.2] [Linux] non-blocking-saving isn't non-blocking any more

Posted: Mon Jun 10, 2019 4:14 pm
by Oxyd
Sorry about the delay. Fixed in 0.17.48.