Page 1 of 1

[Dominik] [0.16.36] Ctrl-backspace triggers temporary stall.

Posted: Mon Apr 23, 2018 8:53 am
by jercos
Affects all text fields tested, is reliable (not intermittent), fields tested are the console; inventory search; blueprint string import; and locomotive color. Affects at least steam-distributed binaries on Windows 7 x64.

To reproduce, with text cursor focus in any empty text field, press control-backspace (delete previous word). The field must be completely clear, control-backspace when the cursor is at the left of a field containing some text (even a single space) performs as expected rather than triggering the bug.

The result? The client takes 100% CPU for several seconds (seems variable between around 3 to 10) and many times will stall long enough to get dropped from the server. Updates are not painted during the stall, as shown in screenshot.

I expect the client to do nothing on receiving control-backspace on an empty text field.

Re: [0.16.36] Ctrl-backspace triggers temporary stall.

Posted: Mon Apr 23, 2018 8:54 am
by jercos
This worries me because of the implication that it might be under-running the text buffer searching for a word-ending or something... on some systems it could crash instead of stalling if that's the case.

Re: [Dominik][0.16.36] Ctrl-backspace triggers temporary stall.

Posted: Tue Apr 24, 2018 7:28 am
by Dominik
Yeah, totally sounds like some open cycle.

Re: [Dominik] [0.16.36] Ctrl-backspace triggers temporary stall.

Posted: Tue Apr 24, 2018 11:52 am
by wheybags
This was already fixed in 0.16.37.
Thanks for the report!

Re: [Dominik] [0.16.36] Ctrl-backspace triggers temporary stall.

Posted: Tue Apr 24, 2018 12:02 pm
by Dominik
A fine piece of work done today.