Page 1 of 1
[0.15.34] Some ogg files cause crash
Posted: Tue Aug 29, 2017 8:05 pm
by wvlad
Code: Select all
for i=1,31 do
data:extend(
{
{
type = "ambient-sound",
name = "FTL"..tostring(i),
track_type = "main-track",
sound =
{
filename = "__ambientjamsmod-tangerinemusiclabs__/FTL"..tostring(i)..".ogg"
}
}
})
end
Ogg files
https://1drv.ms/f/s!AhAvFYRsqyUIg7oYRLWgHq75JgbOIw
Re: [0.15.34] Some ogg files cause crash
Posted: Wed Aug 30, 2017 2:14 am
by impetus maximus
did you validate the ogg files?
Re: [0.15.34] Some ogg files cause crash
Posted: Wed Aug 30, 2017 7:45 am
by wvlad
No, I used AIMP converter to make them from mp3, they should be fine. The stack trace tells that the exception is thrown not by the codec but by factorio code.
I've found that everything works fine when I remove all tags from them. The tags support needs fixing.
Re: [0.15.34] Some ogg files cause crash
Posted: Wed Aug 30, 2017 8:07 am
by Rseding91
wvlad wrote:The stack trace tells that the exception is thrown not by the codec but by factorio code.
No, it crashes there because the codec is trying to do something it shouldn't be doing - read data that isn't available.
That's like saying "The car is defective, it blew up when I put nitroglycerin in the gas tank instead of normal gas"
That being said, is there any kind of ogg validation that can say the files you're using are conformant to the standard?
Re: [0.15.34] Some ogg files cause crash
Posted: Wed Aug 30, 2017 4:01 pm
by Philip017
Rseding91 wrote:
That's like saying "The car is defective, it blew up when I put nitroglycerin in the gas tank instead of normal gas"
rsedling you come up with some really good analogies and this one gave me a good laugh, thank you for that!
Re: [0.15.34] Some ogg files cause crash
Posted: Thu Aug 31, 2017 11:28 am
by kovarex
As it is suspected that it is most probably problem of the file itself, I'm moving it to pending.
If you provide invalid png, the game will not like it as well.
Re: [0.15.34] Some ogg files cause crash
Posted: Sat Sep 02, 2017 7:37 am
by wvlad
Is it invalid if it's opened by most players? I don't think so.
Is there a way to verify the files on windows?
Re: [0.15.34] Some ogg files cause crash
Posted: Sat Sep 02, 2017 1:04 pm
by posila
I found the problem.
Thanks for posting the report and giving us example of files that cause the crash. It is fixed for 0.16
Re: [0.15.34] Some ogg files cause crash
Posted: Sat Sep 02, 2017 1:13 pm
by impetus maximus
wvlad wrote:Is it invalid if it's opened by most players? I don't think so.
Is there a way to verify the files on windows?
well VLC can open files that don't conform to a standard.
check out
https://www.xiph.org/oggz/ they have windows binaries. no idea how to use them though.
