Page 1 of 1
[HanziQ][15.31] Extremely large research multiplier causes crash (MacOS)
Posted: Tue Aug 01, 2017 12:04 am
by archiecstll
When generating a new map, set an extremely large research multiplier. Once the map loads, open the research window. Game will crash if the multiplier is large enough. Otherwise, click on a tech that is more expensive to research than the initially selected one.
Re: [15.31] Extremely large research multiplier causes crash
Posted: Tue Aug 01, 2017 1:38 pm
by posila
Could not reproduce on Windows. I also don't see anything wrong around the place it crash on. I tried 123456789987654321123456789
Re: [15.31] Extremely large research multiplier causes crash
Posted: Tue Aug 01, 2017 2:05 pm
by kovarex
posila wrote:Could not reproduce on Windows. I also don't see anything wrong around the place it crash on. I tried 123456789987654321123456789
We should limit it to something reasonably anyway, more than a 100 or 1000 doesn't really make sense. Once the numbers become too large, doubles will not be able to do the small addition and the research would be frozen.
Re: [HanziQ][15.31] Extremely large research multiplier causes crash (MacOS)
Posted: Tue Aug 01, 2017 3:18 pm
by Bilka
If you do limit it, please document the max number in the lua api doc.
Re: [15.31] Extremely large research multiplier causes crash
Posted: Tue Aug 01, 2017 3:33 pm
by posila
kovarex wrote:We should limit it to something reasonably anyway, more than a 100 or 1000 doesn't really make sense. Once the numbers become too large, doubles will not be able to do the small addition and the research would be frozen.
Ok, limited it to 1000 for 0.15.32
Bilka wrote:If you do limit it, please document the max number in the lua api doc.
Ok, good call.