Page 1 of 1

[Rseding91] [for 0.16] [0.15.28] blueprint construction of same entity fails

Posted: Fri Jul 14, 2017 8:11 am
by gHoST INFERNO
Generally it is safe and works well to deconstruct a large area, and while this deconstruction is still going, put another blueprint over it to construct in its place. Some robots might have to wait for a while until they can build the new entity, but that's fine.

Things break when that new blueprint happens to build the same entity type in the same spot as is currently planned for deconstruction. In that case the entity ends up being deconstructed but is never rebuilt. This came up for me after having to move an already deployed large blueprint for straight train tracks over by a few tiles: To move all the ancillary stuff around the train tracks themselves (power, signals, some lights, etc.) I decided I'd just deconstruct the whole track and immediately after rebuild it, but moved slightly (along the train track). This meant most of the track track overlapped with where it was before (except at the ends), but all the stuff next to the train tracks moved a bit. This resulted in most of the train track being destructed, while the other entities around it didn't have this overlap and moved just fine.

It seems it would be better if (a) constructing the same entity type over an entity planned for deconstruction undoes the deconstruction-planning, though it would still need to adjust the configuration of the entity, if it is e.g. a combinator or something or (b) still deconstruct it, but then actually shortly after construct it again with the new config, like it would if it was a different entity type.


I tried to find an existing bug for this, as I assume I'm not the first one to find this issue, but I failed, so I'm filing it to be sure.

Thanks for an awesome game!

Re: [0.15.28] blueprint construction of same entity fails

Posted: Fri Jul 14, 2017 12:13 pm
by rorror
I can confirm this behavoir. but only noticed it while removing rails and directly placing a blueprint on it, bits of tracks where missing.

Re: [Rseding91] [for 0.16] [0.15.28] blueprint construction of same entity fails

Posted: Fri Jul 14, 2017 7:40 pm
by gHoST INFERNO
I definitely also had it happen to me with concrete tiles, but since you brought it up I'll try it later tonight or tomorrow with an entity like an inserter or a combinator and post the outcome here, unless somebody else posts a relevant update before.

Thanks for confirming for train tracks!

Re: [Rseding91] [for 0.16] [0.15.28] blueprint construction of same entity fails

Posted: Sun Jul 16, 2017 2:32 pm
by d3x0r
+1 for rails
viewtopic.php?f=47&t=50941

also rail signals, chain rail signals, concrete, construction concrete, brick path

I was doing a test, turns out a blueprint over itself shows buildings in blue, a blueprint over a deconstructed building shows green; except on those things that don't replace...

Looking at this a little more; not sure why some buildings have blue select around them... Oh, because of the substation.
everything over decon.jpg
everything over decon.jpg (258.63 KiB) Viewed 4217 times
Rocket silo prevents consturction of a blueprint over itself once placed (this is after the deconstruction/reconsturction is done...)
everything over recon.jpg
everything over recon.jpg (254.58 KiB) Viewed 4217 times
Hmm guess I missed belts; those work though I'm sure because you can even replace those in-place.

Re: [Rseding91] [for 0.16] [0.15.28] blueprint construction of same entity fails

Posted: Sun Jul 16, 2017 6:13 pm
by rorror
d3x0r wrote: Looking at this a little more; not sure why some buildings have blue select around them... Oh, because of the substation.
Well power poles do react a bit wierd with blueprints (could also be a point to look in to)
d3x0r wrote:
Hmm guess I missed belts; those work though I'm sure because you can even replace those in-place.
belts, underground and splitters are working, using that alot.

Re: [Rseding91] [for 0.16] [0.15.28] blueprint construction of same entity fails

Posted: Tue Jul 18, 2017 4:55 pm
by Rseding91
Thanks for the report. While this is working as intended it can be annoying so we've changed it so in 0.16 when you build a blueprint of rails over a rail to be deconstructed it cancels deconstruction.

Re: [Rseding91] [for 0.16] [0.15.28] blueprint construction of same entity fails

Posted: Tue Jul 18, 2017 5:46 pm
by d3x0r
Canceling the deconstruction is worse.
I want to replace the rails with different style rails; not leave what was there.
And what about rocket silo preventing placing a blueprint even when it's in the same place?

Re: [Rseding91] [for 0.16] [0.15.28] blueprint construction of same entity fails

Posted: Sat Jul 22, 2017 1:25 pm
by Optera
This happened to me for other entities than rails as well.
When placing a blueprint over an area marked for deconstruction I expect the blueprint to be built completely. Either by removing all entities first as ordered or being somewhat smart and cancel identical entities from being deconstructed and rebuilt.

Re: [Rseding91] [for 0.16] [0.15.28] blueprint construction of same entity fails

Posted: Sat Jul 22, 2017 1:33 pm
by d3x0r
Optera wrote:This happened to me for other entities than rails as well.
When placing a blueprint over an area marked for deconstruction I expect the blueprint to be built completely. Either by removing all entities first as ordered or being somewhat smart and cancel identical entities from being deconstructed and rebuilt.
well the actual behavior for those eneittis that don't behave as normal is that the ghost is not created over it. This would be true if concrete were replaced with hazard concrete or any of the things indiciated in the screen shots I posted.

There's no ghost put down to rebuilt. so it does all the desconconsturct first, but has nothing to construct afterward... cancelling deconstruct for identical entities is of course a clever thing to do; and thqt doesn't happen for anything ATM.