Page 2 of 4

Re: [Twinsen] [0.15.18] - Disabled/Unpowered Inserter Inserts Hand Content

Posted: Wed Jun 21, 2017 10:41 pm
by marvk4
I also second this be changed back, or at least be made into a checkbox to switch this new behaviour off and on.

Re: [Twinsen] [0.15.18] - Disabled/Unpowered Inserter Inserts Hand Content

Posted: Wed Jun 21, 2017 10:41 pm
by Killcreek2
kaldskryke wrote:
Killcreek2 wrote:Imho, worst patch since that one that accidentally corrupted savegames ... :shock:
I get you're upset, but I think this is a bit of an exaggeration. I was pretty dismayed to find a bunch of my stuff broken too, but this isn't anywhere close to the level of corrupting savegames.

I appreciate that this change gives us finer-grain control of inserters, but it complicates "1 pulse = 1 inserter movement" so much that I really hope the developers can give that functionality back to us with some kind of checkbox in the UI.
Well I did not say "as bad as" ~ I said "worst one since then". ;)
I welcome changes, improvements & updates, but I will speak my mind if I think it is a BAD change, or a step in the wrong direction [like this one is].

This really has broken sooo many useful setups, or made them massively more complex to do. & for no good reason.
Just think about a filter inserter ~ it can now get locked, holding an item that is no longer needed, and unable to pick up a different item type as it's hand is still full. Just one example of many available.

As a redditor remarked: "one tick pulse" to move A to B seems more intuitive to "n tick hold until hand is empty"

Re: [Twinsen] [0.15.18] - Disabled/Unpowered Inserter Inserts Hand Content

Posted: Wed Jun 21, 2017 11:21 pm
by Smokey0815
As MasterBuilder already mentioned, the classic circuit based train unloading is broken and there are usually quite a lot of these around my base. Just wanted to give an example for this. The bluebrint requires creative-mode: h**ps://mods.factorio.com/mods/Mooncat/creative-mode (sry, not allowed to give you a clickable url on my first post ^^)
Blueprint

Re: [Twinsen] [0.15.18] - Disabled/Unpowered Inserter Inserts Hand Content

Posted: Wed Jun 21, 2017 11:30 pm
by engin33rguy
I'm in favor of this change being reverted- It broke a ton of circuit setups around my factory. The only way I see this working is if we have the option to choose between which mode we want like others have mentioned. I use a setup similar to what OP had in his "bug" report but you guys already have a way in game to fix it- filter your train wagons! Then you can't get random garbage in it. Now that this "fix" got pushed, the ONLY thing that changes is we don't have to filter wagons. It's not like it improves loading efficiency because the inserter is still stuck holding the "wrong" item over the train wagon that you didn't want to put it into. I fail to see how this fixes anything that using filters in wagons didn't already do. All this seems to have done is broken tons of people's setups because one poster didn't filter their train wagons.

I get that this game is still in alpha and is subject to change at any time, but to be perfectly honest with you this is the first time I've been legitimately disappointed with an update you've pushed. It will take a lot of work to update my base (Especially since the power keeps cutting out and my fuel production is all messed up) so for now I'm rolling back to a previous version.

Re: [Twinsen] [0.15.18] - Disabled/Unpowered Inserter Inserts Hand Content

Posted: Thu Jun 22, 2017 12:04 am
by DerGraue
Please revert this change, it broke my entire base

or give us an option to reenable the old setting

Re: [Twinsen] [0.15.18] - Disabled/Unpowered Inserter Inserts Hand Content

Posted: Thu Jun 22, 2017 12:34 am
by otobot1
This "fix" broke every single train unloading station I have, my uranium production, and dozens of other things around my base. As mentioned before, the "problem" that the OP was having can be fixed by filtering wagons, or just planning your train network better. Please revert this "fix" ASAP. Until then, I'll be sticking with 15.21 because I can't be bothered to redesign all of my circuitry.

Re: [Twinsen] [0.15.18] - Disabled/Unpowered Inserter Inserts Hand Content

Posted: Thu Jun 22, 2017 12:36 am
by Mailbox23
Twinsen wrote:Both use cases don't seem too problematic to me. Like I said, it will break some things but i believe they can mostly be worked around.

I'll keep an eye on this thread. Depending on what people say I can keep or revert the change.

I am very much in favor of reverting the change or having an check-box option for the inserter to change between these modes. The change breaks a lot of simple inserter controls and seems to over-complicate nuclear control especially.

Re: [Twinsen] [0.15.18] - Disabled/Unpowered Inserter Inserts Hand Content

Posted: Thu Jun 22, 2017 12:39 am
by bradicai
Um... this breaks all sorts of things.

I believe the proper response to "my inserters are loading the incorrect materials onto trains" should be something along the lines of, "You can set an item type filter of a cargo train the same way you set your hotbar".

Re: [Twinsen] [0.15.18] - Disabled/Unpowered Inserter Inserts Hand Content

Posted: Thu Jun 22, 2017 12:49 am
by Ripshaft
Well I've seen a number of people talking about the change breaking their stuff but not really providing much useful detail so that the scope of impact can be established....

will be terse:

Circuit condition [everything] = 0, read hand contents, hold signal

Connect all inserters with wire on an unloading line

Effect - No inserter will grab more items until all hands are empty, leading to a reasonably balanced unloading of chests.



I can already think of alternate ways to wire my circuits to accomplish this same effect, but none of them are as piss-simple as the above option.

But I want to lay that out so that you get an idea how much this messes my stuff up - literally every place where I have multiple inserters depositing items onto a belt, and many areas where multiple chests are being loaded to then be unloaded to a common belt... this is an extremely impactful change.


HOWEVER, to be clear - I do not want to discourage the change based purely on impact, I think it makes more sense intuitively to disable the function of inserters when they are... disabled.. it does seem like the method I'm using shouldn't really work, it's just nice because it does and proves useful. Changing my setup is really not that much of a hassle, and blueprints make it easy to rapidly implement more complex wiring.

Though I think it's really important to get decent feedback on the perhaps unforeseen consequences of a change and how the community may experience it.


Anyhoo love what you guys do, even when you bring my mighty engine to ruin... it will rise again!

Re: [Twinsen] [0.15.18] - Disabled/Unpowered Inserter Inserts Hand Content

Posted: Thu Jun 22, 2017 1:23 am
by Killcreek2
Ripshaft wrote:Well I've seen a number of people talking about the change breaking their stuff but not really providing much useful detail so that the scope of impact can be established....
Good point.
However, it is hard to cite / screenshot a specific example from the hundreds of now-broken circuit / logistics enabled inserters scattered around the entire factory, which is in the middle of a main-power blackout & under biter assault on all sides... ;)
Ripshaft wrote:will be terse:
Circuit condition [everything] = 0, read hand contents, hold signal
Connect all inserters with wire on an unloading line
Effect - No inserter will grab more items until all hands are empty, leading to a reasonably balanced unloading of chests.

Would work, but would be as slow as the slowest inserter. Previous behaviour allowed maximum speed for all the inserters, very easily.
Replicating that max throughput with this new behaviour will require a time-delay signal = to the time it takes the inserter to rotate. Going chest-to-chest is predictable timings, but belt-to-chest is rather variable and a whole lot more complex.
Even a 1-tick pulse that is stored until the hand is empty requires an additional combinator per inserter.

"1-tick pulse = 1 inserter rotation & dropoff" is so much simpler, easier to remember, build, and upgrade [as different inserter types would need different timings].

Re: [Twinsen] [0.15.18] - Disabled/Unpowered Inserter Inserts Hand Content

Posted: Thu Jun 22, 2017 1:25 am
by golfmiketango
So, to convince an inserter to move a single item, this means we need to know the rotation timings. But this is a function of where on the arc of motion the inserter was rotated to when it was disabled. As this information is not available to the circuit network directly, I guess this means we must track the rotation ourselves, by remembering how long the inserter was rotating for...., which really starts to feel like I've entered a long, dark tunnel.

Are people really correct that inserters pulse when they pick up and not when they drop? By any chance, was that changed to solve this? In my distelzombie-ish nuclear build, I have a two-combinator solution to this problem based on the assumption that they pulse when they drop and it does seem to work. But two combinators per inserter feels like a lot compared to the zero combinators per inserter it took formerly. (EDIT: it seems there was a bug in that; now I'm convinced they indeed pulse when they pick up. So I guess I'll need to use "hold"... requiring ... a third combinator per inserter? Hopefully not, so back to the drawing board...).

My first impression is: this partially defeats the purpose of configurable inserter stack counts, and puts me back in the 0.14 situation, where excessive cleverness is required to get anything done with exact-item-count precision using circuit-network-controlled inserter enablement. Very possibly, however, I just need to think about it harder, or I should really be thinking in terms of set-filters instead of enablement, now, or something like that....

Admittedly, it's a bit hard to think clearly about such things when all the lights are out and aliens are tearing my lasers to bits... maybe I'll warm up to it once that phase of the adjustment is over :). I can, indeed, think of some ways to exploit this which formerly would have been impossible.

Re: [Twinsen] [0.15.18] - Disabled/Unpowered Inserter Inserts Hand Content

Posted: Thu Jun 22, 2017 1:49 am
by looney
IMHO *if* you want to keep any of this change, then I would implement something like; A pulse will enable the inserter, only if the inserter cannot drop the current item and is therefore waiting for something, should it check the enable condition again.

Re: [Twinsen] [0.15.18] - Disabled/Unpowered Inserter Inserts Hand Content

Posted: Thu Jun 22, 2017 2:16 am
by golfmiketango
looney wrote:IMHO *if* you want to keep any of this change, then I would implement something like; A pulse will enable the inserter, only if the inserter cannot drop the current item and is therefore waiting for something, should it check the enable condition again.
Perhaps a better way would be to offer two modes, say, "pulse enable," in which inserters queue stack-size-or-less insertion requests every tick, and "hold enable" which behaves like 0.15.22. But that would complicate the already record-holding-ly-complex circuit interaction configuration gui of inserters, which seems like a less-than-wonderful thing.

Re: [Twinsen] [0.15.18] - Disabled/Unpowered Inserter Inserts Hand Content

Posted: Thu Jun 22, 2017 2:37 am
by MrGrim
This increases the complexity of a lot of circuits using things like decider combinator feedback counters by forcing an edge detector to turn a pulse into a sustained signal, and even then, as others have pointed out, you can't be sure when the inserter is done and stop it before it picks up another item.

The OP's problem wasn't the inserters behavior. The OP's problem is an off by one error. They should have disabled the inserter as it was moving the last item, not when it picked up the overflow item.

Please revert.

Re: [Twinsen] [0.15.18] - Disabled/Unpowered Inserter Inserts Hand Content

Posted: Thu Jun 22, 2017 3:12 am
by Philip017
+1 for revert this change,

possible options:
- add a check box to allow dropping on second pulse,
- add option to return inserter to pickup location on deactivation. (it no longer operates on a pulse, and requires a hold signal, it could simply rotate back to the pickup location on deactivation, still holding it's item(s), it could pickup a new stack when reactivated, thus the item(s) are not inserted into the entity until the activation signal is sent and held again)
- have option to operate on either a pulse or a hold signal.

although i do love the ability to have the inserter move on a pulse now instead of a hold signal, by default.

EDIT:
also to answer the OP's problem, i filter my wagons to not have items in them i don't want.

also i have over 2000hrs in the game. and have learned quite a few things, making this change in the game overly complicates many simple inserter circuits. many examples of them have been documented already here. yes there are work arounds, but tutorials will have to be rewritten for things like the balanced loader/unloader that many people frequently use as one example. i understand why this could be a good change, but there also many ways that this is a bad change, there are work arounds to each situation, but so far the majority seems to be that this change should be reverted. and i wholly agree. you could always add option(s) to make them work in either situation.

Re: [Twinsen] [0.15.18] - Disabled/Unpowered Inserter Inserts Hand Content

Posted: Thu Jun 22, 2017 4:09 am
by ElPresidente
please revert this asap or add checkbox to disable.

Re: [Twinsen] [0.15.18] - Disabled/Unpowered Inserter Inserts Hand Content

Posted: Thu Jun 22, 2017 4:50 am
by Uggeli
this broke everything at my base

Re: [Twinsen] [0.15.18] - Disabled/Unpowered Inserter Inserts Hand Content

Posted: Thu Jun 22, 2017 5:02 am
by chrisgbk
Twinsen wrote:Both use cases don't seem too problematic to me. Like I said, it will break some things but i believe they can mostly be worked around.

I'll keep an eye on this thread. Depending on what people say I can keep or revert the change.
I'd like to suggest reverting the change, but add additional functionality to cover the case presented in the thread:

Add a checkbox labelled "Reset when disabled"

Checking this checkbox would cause the inserter, if it is disabled while it is holding something, to attempt to put it back where it picked it up from immediately. If it can't place the item in the chest/on the belt, the inserter will simply continue holding the item until it is enabled again, at which point it will skip the pickup step and immediately spin and try to place the item.

Re: [Twinsen] [0.15.18] - Disabled/Unpowered Inserter Inserts Hand Content

Posted: Thu Jun 22, 2017 6:04 am
by Ripshaft
Hm, seems people mostly use a method I never did.. what I described is much simpler as you dont need a decider or arithmetic combinator but that pulse one sounds better.

For the people having trouble with a workaround, not sure how common this is, but I'm guessing most people are familiar with how to use an arithmetic combinator to evenly load chests - you can use the exact same method to evenly unload chests too, just flip the direction from <= 0 to >= 0 on the unloading inserters....

That seemed alot easier to explain in my head, hopefully that helps a handful of people who know what I'm talking about lol


Welp, bout an hour into changing all my circuits, almost got like... some stuff working again =p

Re: [Twinsen] [0.15.18] - Disabled/Unpowered Inserter Inserts Hand Content

Posted: Thu Jun 22, 2017 8:35 am
by bzzz
chrisgbk wrote:Add a checkbox labelled "Reset when disabled"
I really like this idea as a clear solution for both of the problems.