Page 1 of 1

[0.14.14][Twinsen] max_upload_in_kilobytes_per_second

Posted: Sun Oct 23, 2016 8:28 pm
by fluffle
HI,

Setting max_upload_in_kilobytes_per_second to a non-zero value appears to prevent players who connect from downloading the map. I've only tested the values "0", where the map downloads fine, and "64", where the map sits forever at 0% transferred. This is a new server, the map is 700kb and should have transferred in 12 seconds or so with this limit. Here's the server logs for one connect attempt:

Code: Select all

2506.263 Info ServerMultiplayerManager.cpp:652: mapTick(19) changing state from(InGame) to(InGameSavingMap)
2506.280 Info ServerMultiplayerManager.cpp:736: mapTick(19) received stateChanged peerID(1) oldState(Ready) newState(ConnectedWaitingForMap)
2506.434 Info ServerMultiplayerManager.cpp:773: MapTick(19) Serving map(/srv/factorio/temp/mp-save-0.zip) for peer(1) size(771664) crc(3992105767)
2506.434 Info ServerMultiplayerManager.cpp:652: mapTick(19) changing state from(InGameSavingMap) to(InGame)
2506.495 Info ServerMultiplayerManager.cpp:736: mapTick(22) received stateChanged peerID(1) oldState(ConnectedWaitingForMap) newState(ConnectedDownloadingMap)
2744.542 Info ServerMultiplayerManager.cpp:816: Disconnect notification for peer (1)
2744.542 Info ServerMultiplayerManager.cpp:736: mapTick(14304) received stateChanged peerID(1) oldState(ConnectedDownloadingMap) newState(DisconnectScheduled)
2744.560 Info ServerSynchronizer.cpp:539: nextHeartbeatSequenceNumber(81147) removing peer(1).
FWIW the server is on my local LAN, running in a docker container. I tested with both Arumba's "bobs + angels" MP modpack and a small assortment of mods we used for a previous map in 0.13.x:
  • AutoTrash_1.0.1.zip
  • RailTanker_1.4.0.zip
  • YARM_0.7.107.zip
  • long-reach_0.0.6.zip
  • upgrade-planner_1.2.13.zip
I have not tried setting this option with a completely vanilla server. If you want me to do any testing or have any sneaky debug flags that might help figure out what's going on, let me know.

Cheers,
--fluffle

Re: [0.14.14] max_upload_in_kilobytes_per_second

Posted: Sun Oct 23, 2016 11:09 pm
by Loewchen
Please post the complete log of server and peer.

Re: [0.14.14] max_upload_in_kilobytes_per_second

Posted: Mon Oct 24, 2016 12:41 am
by Rseding91
The name is wrong :D

It should actually be "max_upload_in_bytes_per_second" as that's how it's implemented right now. Setting it to 64 with a 700 KB map means it would take 186.6 minutes to transfer.

Re: [0.14.14][Twinsen] max_upload_in_kilobytes_per_second

Posted: Mon Oct 24, 2016 8:58 am
by Loewchen

Re: [0.14.14] max_upload_in_kilobytes_per_second

Posted: Mon Oct 24, 2016 9:16 am
by Twinsen
Rseding91 wrote:The name is wrong :D
No it's not. There was a bug that made limits under 101KB/s not work.

Fixed in Version: 0.14.15.

Re: [0.14.14][Twinsen] max_upload_in_kilobytes_per_second

Posted: Mon Oct 24, 2016 7:04 pm
by fluffle
Thanks, and sorry for the dupe. Your forum search did not find the other one despite me searching for both max_upload_in_kilobytes_per_second and "max_upload_in_kilobytes_per_second". I probably should have just used Google :-)