Page 1 of 1

[Rseding91] inventory_size limit 256

Posted: Sun Jul 10, 2016 9:31 pm
by binbinhfr
Hi,

it seems that player inventory_size is limited to 256. The problem is that if you go further than this value (using several mods, armor, etc.. that can go higher), then the size of your inventory is decreased of 256.
example : if you reach 300, your invenoty becomes 300-256 = 44. It would be better to just limit the number to 256 if the sum of everything goes higher, no ?

Re: inventory_size limit 256

Posted: Sun Jul 10, 2016 9:33 pm
by Klonan
Thanks for the report,

This is kinda funny :D
I think maybe inventory size should be... uncapped somewhat, we'll see what happens

Re: inventory_size limit 256

Posted: Sun Jul 10, 2016 9:40 pm
by binbinhfr
Ha ha !
I already manage to get memory crash with factorio making to big LUA lists, so I guess that even uncapped, the inventory size will have some technical limits ;-)

Re: inventory_size limit 256

Posted: Mon Jul 11, 2016 8:18 am
by Rseding91
Can you give me steps to reproduce the issue? Inventory size should work correctly up until uint16_t or 65536 before it wraps around to 0.

Re: [Rseding91] inventory_size limit 256

Posted: Mon Jul 11, 2016 8:21 am
by Rseding91
Nevermind, I found the issue :)

Re: [Rseding91] inventory_size limit 256

Posted: Mon Jul 11, 2016 8:51 am
by binbinhfr
65536 before it wraps around to 0.
So if I set it to 65537, there will still be a bug ??? I make a report right now !!!! ;-)

Re: [Rseding91] inventory_size limit 256

Posted: Mon Jul 11, 2016 9:13 am
by Rseding91
binbinhfr wrote:
65536 before it wraps around to 0.
So if I set it to 65537, there will still be a bug ??? I make a report right now !!!! ;-)
No, if you set it to that it will overflow as designed. No bug. Everything has its limits.

Re: [Rseding91] inventory_size limit 256

Posted: Mon Jul 11, 2016 10:37 am
by Rseding91
Fixed for 0.13.8.

Re: [Rseding91] inventory_size limit 256

Posted: Mon Jul 11, 2016 11:16 am
by binbinhfr
Rseding91 wrote:Fixed for 0.13.8.
Did I miss 0.13.7 ???
Or maybe it will come out in a few hours... :-)